Skip to contentSkip to conversation

Input: rpckbd - fix a leak of the IRQ during init failure

PATCH Applied Axel Lin 2 participants 2 messages Apr 3, 2011

Subsystems (2)
HID Input drivers
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 Input: rpckbd - fix a leak of the IRQ during init failure

In rpckbd_open prror path, free_irq() was using NULL rather than the driver data as the data pointer so free_irq() wouldn't have matched.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/input/serio/rpckbd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/input/serio/rpckbd.c +1 -1
index 9da6fbc..7ec3c97 100644
@@ -90,7 +90,7 @@ static int rpckbd_open(struct serio *port)
 
 	if (request_irq(IRQ_KEYBOARDTX, rpckbd_tx, 0, "rpckbd", port) != 0) {
 		printk(KERN_ERR "rpckbd.c: Could not allocate keyboard transmit IRQ\n");
-		free_irq(IRQ_KEYBOARDRX, NULL);
+		free_irq(IRQ_KEYBOARDRX, port);
 		return -EBUSY;
 	}
Signature · 1 line
1.7.1
maintainer Applied
#1 lore raw
Quoted 4 lines · Axel Lin

In rpckbd_open prror path, free_irq() was using NULL rather than the driver data as the data pointer so free_irq() wouldn't have matched.

Signed-off-by Axel Lin <[email protected]>

Applied, thanks Axel.

Signature · 1 line
Dmitry