Skip to contentSkip to conversation

mkfs.minix: add support for minix3 fs

PATCH In review Davidlohr Bueso 1 participant 2 messages Mar 31, 2011 – Apr 6, 2011 1 message not in the archive Util-Linux package

lore
Share & tools
lore

Davidlohr Bueso

author
#0 lore raw

PATCH 3/3 mkfs.minix: add support for minix3 fs

Add Minix filesystem v3 support. This version allows up to 60 character name files, instead of 30 for older versions. We can also specify the block size to be used (with the new -B option). Additionally, three new options were added to specify the fs version to be created (-1, -2, -3).

Signed-off-by Davidlohr Bueso <[email protected]>
---
 disk-utils/Makefile.am  |    2 +-
 disk-utils/mkfs.minix.c |  351 ++++++++++++++++++++++++++++++-----------------
 2 files changed, 223 insertions(+), 130 deletions(-)
disk-utils/Makefile.am +1 -1
index 5df8064..cd07169 100644
@@ -1,6 +1,6 @@
 include $(top_srcdir)/config/include-Makefile.am
 
-utils_common = $(top_srcdir)/lib/blkdev.c
+utils_common = $(top_srcdir)/lib/blkdev.c $(top_srcdir)/lib/strutils.c
 if LINUX
 utils_common += $(top_srcdir)/lib/linux_version.c
 endif
disk-utils/mkfs.minix.c +222 -129

654 lines not on this page · raw message

Signature · 1 line
1.7.1

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#2 lore raw
Quoted 2 lines · Karel Zak
Quoted 1 line · Davidlohr Bueso

#define INODE_SIZE (sizeof(struct minix_inode))

...

Quoted 9 lines

Oh.. Davidlohr, you forgot regression test ;-) What about to add

        mkfs.minix -{1,2,3}

to tests/ts/minix/mkfs{1,2,3} ?

It would be also nice to add MINIX3_SUPER_MAGIC to fsck.minix and print a warning that v3 is unsupported (yet?).

I had a feeling you would dislike the sloppy code (which was already a part of mkfs.minix), so heck, let's invade it massively, like partx. Like you mention, we need to go through several patches, which I will be sending you over the next few days, this way it might be a bit easier to merge.

Thanks,
Davidlohr