Skip to contentSkip to conversation

arm: Fix .size directive for xscale_dma_a0_map_area

PATCH New Ben Hutchings 1 participant 2 messages Mar 12, 2011 – Apr 7, 2011 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: Fix .size directive for xscale_dma_a0_map_area

gas used to accept (and ignore?) .size directives which referred to undefined symbols, as this does. In binutils 2.21 these are treated as fatal errors.

---
I missed this one previously because my 5-minute script didn't recognise the ENDPROC macro as generating a .size directive.

Ben.

 arch/arm/mm/proc-xscale.S |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mm/proc-xscale.S +1 -1
index 5a37c5e..ab00b59 100644
@@ -395,7 +395,7 @@ ENTRY(xscale_dma_a0_map_area)
 	teq	r2, #DMA_TO_DEVICE
 	beq	xscale_dma_clean_range
 	b	xscale_dma_flush_range
-ENDPROC(xscsale_dma_a0_map_area)
+ENDPROC(xscale_dma_a0_map_area)
 
 /*
  *	dma_unmap_area(start, size, dir)
Signature · 1 line
1.7.4.1
#1 lore raw

PATCH 1/1 arm: Fix .size directive for xscale_dma_a0_map_area

Quoted 3 lines · Ben Hutchings

gas used to accept (and ignore?) .size directives which referred to undefined symbols, as this does. In binutils 2.21 these are treated as fatal errors.

Please acknowledge and send this upstream.

You also haven't responded to my patch fixing .size directives for __arm{7,9}tdmi_proc_info.

Ben.

Quoted 23 lines

---
I missed this one previously because my 5-minute script didn't recognise the ENDPROC macro as generating a .size directive.

Ben.

 arch/arm/mm/proc-xscale.S |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mm/proc-xscale.S +1 -1
index 5a37c5e..ab00b59 100644
@@ -395,7 +395,7 @@ ENTRY(xscale_dma_a0_map_area)
 	teq	r2, #DMA_TO_DEVICE
 	beq	xscale_dma_clean_range
 	b	xscale_dma_flush_range
-ENDPROC(xscsale_dma_a0_map_area)
+ENDPROC(xscale_dma_a0_map_area)
 
 /*
  *	dma_unmap_area(start, size, dir)
Signature · 9 lines
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 828 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110408/e0707e03/attachment.sig>