Skip to contentSkip to conversation

omap3-sgx-modules: Update TI816x Module Location and Platform variables.

PATCH In review Siddharth Heroor 3 participants 7 messages Apr 9, 2011 – Apr 18, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 omap3-sgx-modules: Update TI816x Module Location and Platform variables.

From: Siddharth Heroor <[email protected]>

* With Graphics SDK 4.03.00.02, TI816x module location and platform has been made more generic - ti81xx. This is to support TI814x which uses exactly the same SGX core as TI816x.

---
 .../omap3-sgx-modules_1.6.16.3977.bb               |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
recipes/powervr-drivers/omap3-sgx-modules_1.6.16.3977.bb +2 -2
index 867e21d..5a59883 100644
@@ -31,10 +31,10 @@ PVRBUILD = "release"
 PACKAGE_STRIP = "no"
 
 TI_PLATFORM_omap3 = "omap3630"
-TI_PLATFORM_ti816x = "ti8168"
+TI_PLATFORM_ti816x = "ti81xx"
 
 MODULESLOCATION_omap3 = "dc_omap3430_linux"
-MODULESLOCATION_ti816x = "dc_ti8168_linux"
+MODULESLOCATION_ti816x = "dc_ti81xx_linux"
 
 MAKE_TARGETS = " BUILD=${PVRBUILD} TI_PLATFORM=${TI_PLATFORM}"
 
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 2/3 libgles-omap3: Correct libraries for TI816x.

From: Siddharth Heroor <[email protected]>

* Explicitly set ES6LOCATION.
* Split OMAP3 and TI816x BINLOCATION. TI816x uses ES6.x libraries.

---
 .../powervr-drivers/libgles-omap3_4.03.00.02.bb    |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
recipes/powervr-drivers/libgles-omap3_4.03.00.02.bb +3 -1
index e4daa23..1e9d829 100644
@@ -1,11 +1,13 @@
 # untested and huge change from 1.4.x
 DEFAULT_PREFERENCE = "-1"
 
-BINLOCATION = "${S}/gfx_rel_es3.x"
+BINLOCATION_omap3  = "${S}/gfx_rel_es3.x"
+BINLOCATION_ti816x = "${S}/gfx_rel_es6.x"
 
 ES2LOCATION = "${S}/gfx_rel_es2.x"
 ES3LOCATION = "${S}/gfx_rel_es3.x"
 ES5LOCATION = "${S}/gfx_rel_es5.x"
+ES6LOCATION = "${S}/gfx_rel_es6.x"
 
 require libgles-omap3.inc
 
Signature · 1 line
1.7.0.4
#2 lore raw

PATCH 3/3 libgles-omap3: Remove SGX Fixup for TI816x.

In reply to Siddharth Heroor

From: Siddharth Heroor <[email protected]>

* Unlike OMAP3, the SGX core has not undergone revisions in TI816x. The libraries for TI816x are also fixed and do not need fixup based on revision of the SGX core.

---
 recipes/powervr-drivers/libgles-omap3/rc.pvr |   10 +++-------
 1 files changed, 3 insertions(+), 7 deletions(-)
recipes/powervr-drivers/libgles-omap3/rc.pvr +3 -7
index 395d085..1b141a0 100755
@@ -90,15 +90,11 @@ case $CPUTYPE in
 	devmem2 0x48180900 w 0x2
 	devmem2 0x48180920 w 0x2
 
+	sleep 2
+
 	ES_REVISION="$(devmem2 0x56000014 | sed -e s:0x00010205:5: -e s:0x00010201:3: -e s:0x00010003:2: | tail -n1 | awk -F': ' '{print $2}')"
 
-	if [ "${ES_REVISION}" != "${SAVED_ESREVISION}" ] ; then
-		echo -n "Starting SGX fixup for"
-		echo " ES${ES_REVISION}.x"
-		cp -a /usr/lib/ES${ES_REVISION}.0/* /usr/lib
-		cp -a /usr/bin/ES${ES_REVISION}.0/* /usr/bin	
-		echo "${ES_REVISION}" > /etc/powervr-esrev
-	fi
+	echo "${ES_REVISION}" > /etc/powervr-esrev
 	/usr/bin/pvrsrvinit
 
 	;;
Signature · 1 line
1.7.0.4
#3 lore raw

Re: [PATCH 3/3] libgles-omap3: Remove SGX Fixup for TI816x.

Quoted 5 lines · Siddharth Heroor

From: Siddharth Heroor <[email protected]>

* Unlike OMAP3, the SGX core has not undergone revisions in TI816x. The libraries for TI816x are also fixed and do not need fixup based on revision of the SGX core.

Sid,

So, you are modifying generic rc script, which still apllies to OMAP3 platforms, by removing fixups used in OMAP3... Is that correct?

Signature · 1 line
Denys
Quoted 36 lines
---
 recipes/powervr-drivers/libgles-omap3/rc.pvr |   10 +++-------
 1 files changed, 3 insertions(+), 7 deletions(-)
recipes/powervr-drivers/libgles-omap3/rc.pvr +3 -7
index 395d085..1b141a0 100755
@@ -90,15 +90,11 @@ case $CPUTYPE in
 	devmem2 0x48180900 w 0x2
 	devmem2 0x48180920 w 0x2
 
+	sleep 2
+
 	ES_REVISION="$(devmem2 0x56000014 | sed -e s:0x00010205:5: -e s:0x00010201:3: -e s:0x00010003:2: | tail -n1 | awk -F': ' '{print $2}')"
 
-	if [ "${ES_REVISION}" != "${SAVED_ESREVISION}" ] ; then
-		echo -n "Starting SGX fixup for"
-		echo " ES${ES_REVISION}.x"
-		cp -a /usr/lib/ES${ES_REVISION}.0/* /usr/lib
-		cp -a /usr/bin/ES${ES_REVISION}.0/* /usr/bin	
-		echo "${ES_REVISION}" > /etc/powervr-esrev
-	fi
+	echo "${ES_REVISION}" > /etc/powervr-esrev
 	/usr/bin/pvrsrvinit
 
 	;;
Signature · 7 lines
1.7.0.4


_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
#4 lore raw

Re: [PATCH 3/3] libgles-omap3: Remove SGX Fixup for TI816x.

Quoted 11 lines · Denys Dmytriyenko
Quoted 5 lines · Siddharth Heroor

From: Siddharth Heroor <[email protected]>

* Unlike OMAP3, the SGX core has not undergone revisions in TI816x. The libraries for TI816x are also fixed and do not need fixup based on revision of the SGX core.

Sid,

So, you are modifying generic rc script, which still apllies to OMAP3 platforms, by removing fixups used in OMAP3... Is that correct?

The rc script has a switch case for different cputypes. This patch only modifies the TI816x case. OMAP3 parts of the rc script are not modified.

Quoted 47 lines

--
Denys

Quoted 32 lines

---
 recipes/powervr-drivers/libgles-omap3/rc.pvr |   10 +++-------

 1 files changed, 3 insertions(+), 7 deletions(-)
recipes/powervr-drivers/libgles-omap3/rc.pvr +0 -0
index 395d085..1b141a0 100755
@@ -90,15 +90,11 @@ case $CPUTYPE in

      devmem2 0x48180900 w 0x2
      devmem2 0x48180920 w 0x2

+     sleep 2
+
      ES_REVISION="$(devmem2 0x56000014 | sed -e s:0x00010205:5: -e s:0x00010201:3: -e s:0x00010003:2: | tail -n1 | awk -F': ' '{print $2}')"

-     if [ "${ES_REVISION}" != "${SAVED_ESREVISION}" ] ; then
-             echo -n "Starting SGX fixup for"
-             echo " ES${ES_REVISION}.x"
-             cp -a /usr/lib/ES${ES_REVISION}.0/* /usr/lib
-             cp -a /usr/bin/ES${ES_REVISION}.0/* /usr/bin
-             echo "${ES_REVISION}" > /etc/powervr-esrev
-     fi
+     echo "${ES_REVISION}" > /etc/powervr-esrev /usr/bin/pvrsrvinit

      ;;
--
1.7.0.4

Quoted 4 lines

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Signature · 1 line
Sid
#5 lore raw

Re: [PATCH 3/3] libgles-omap3: Remove SGX Fixup for TI816x.

In reply to Siddharth Heroor

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 7 lines · Siddharth Heroor

From: Siddharth Heroor <[email protected]>

* Unlike OMAP3, the SGX core has not undergone revisions in TI816x. The libraries for TI816x are also fixed and do not need fixup based on revision of the SGX core.

So, I'm back from travelling now and I'll have to NAK this patch:

1) it assumes netra will never have an sgx core update and makes it diverge from the other platforms.

2) it adds a useless 2 second boot delay

So the net result is a harder to maintain slower version of the scripts, which is not acceptable.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNqzLnMkyGM64RGpERAgHyAKCXhRIKrqjA1FMKG+nJ8U2d+rAfYgCfSxEf cywcK4FZnaGd12H1+B9fk4Q=
=goBu
-----END PGP SIGNATURE-----

#6 lore raw

Re: [PATCH 3/3] libgles-omap3: Remove SGX Fixup for TI816x.

Quoted 14 lines · Koen Kooi

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 7 lines · Siddharth Heroor

From: Siddharth Heroor <[email protected]>

* Unlike OMAP3, the SGX core has not undergone revisions in TI816x. The libraries for TI816x are also fixed and do not need fixup based on revision of the SGX core.

So, I'm back from travelling now and I'll have to NAK this patch:

Quoted 7 lines

1) it assumes netra will never have an sgx core update and makes it diverge from the other platforms.

2) it adds a useless 2 second boot delay

So the net result is a harder to maintain slower version of the scripts, which is not acceptable.

The SGX core revision being read by devmem2 returns 5, but the correct version of SGX libraries for TI816x is ES6.x. So, the original pvr-init script copies the libraries from ES5.x and overwrites the correctly installed libraries as part of boot. I will need to check with the 3D Graphics SDK team on why the 2 second delay is required (its present in targetfs/38xx-demo).

Quoted 14 lines

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNqzLnMkyGM64RGpERAgHyAKCXhRIKrqjA1FMKG+nJ8U2d+rAfYgCfSxEf cywcK4FZnaGd12H1+B9fk4Q=
=goBu
-----END PGP SIGNATURE-----

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Signature · 1 line
Sid