Skip to contentSkip to conversation

sched: Move wq_worker_waking to the correct site

tip:sched/locking tip-bot for Peter Zijlstra 2 participants 3 messages Apr 14, 2011

lore
Share & tools
lore
#0 lore raw
Commit-ID:  c2f7115e2e52a6c187b8c1f54f0e4970bb677be0
Gitweb:     http://git.kernel.org/tip/c2f7115e2e52a6c187b8c1f54f0e4970bb677be0
Author:     Peter Zijlstra <[email protected]>
AuthorDate: Wed, 13 Apr 2011 13:28:56 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Thu, 14 Apr 2011 08:52:33 +0200

sched: Move wq_worker_waking to the correct site

wq_worker_waking_up() needs to match wq_worker_sleeping(), since the latter is only called on deactivate, move the former near activate.

---
 kernel/sched.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)
kernel/sched.c +4 -3
index 55cc503..81ab58e 100644
@@ -2421,6 +2421,10 @@ static inline void ttwu_activate(struct task_struct *p, struct rq *rq,
 		schedstat_inc(p, se.statistics.nr_wakeups_remote);
 
 	activate_task(rq, p, en_flags);
+
+	/* if a worker is waking up, notify workqueue */
+	if (p->flags & PF_WQ_WORKER)
+		wq_worker_waking_up(p, cpu_of(rq));
 }
 
 static inline void ttwu_post_activation(struct task_struct *p, struct rq *rq,
@@ -2445,9 +2449,6 @@ static inline void ttwu_post_activation(struct task_struct *p, struct rq *rq,
 		rq->idle_stamp = 0;
 	}
 #endif
-	/* if a worker is waking up, notify workqueue */
-	if ((p->flags & PF_WQ_WORKER) && success)
-		wq_worker_waking_up(p, cpu_of(rq));
 }
 
 /**