Skip to contentSkip to conversation

soc: amlogic: pm-domains: use always-on flag

PATCH In review Kevin Hilman 2 participants 2 messages Sep 21, 2020 – Sep 23, 2020 Arm/Amlogic Meson SoC support

lore
Share & tools
lore

Kevin Hilman

author maintainer
#0 lore raw

PATCH 1/1 soc: amlogic: pm-domains: use always-on flag

Rather than use a governor to keep these domains always-on, instead use the flag GENPD_FLAG_ALWAYS_ON. This has the same effect, but with much lower overhead since the governor path is not used at all.

---
 drivers/soc/amlogic/meson-ee-pwrc.c     | 4 ++--
 drivers/soc/amlogic/meson-gx-pwrc-vpu.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/soc/amlogic/meson-ee-pwrc.c +2 -2
index 43665b77aa9e..a8f18bb17491 100644
@@ -433,8 +433,8 @@ static int meson_ee_pwrc_init_domain(struct platform_device *pdev,
 		if (ret)
 			return ret;
 
-		ret = pm_genpd_init(&dom->base, &pm_domain_always_on_gov,
-				    false);
+		dom->base.flags = GENPD_FLAG_ALWAYS_ON;
+		ret = pm_genpd_init(&dom->base, NULL, false);
 		if (ret)
 			return ret;
 	} else {
drivers/soc/amlogic/meson-gx-pwrc-vpu.c +2 -2
index 511b6856225d..21b4bc811c00 100644
@@ -339,8 +339,8 @@ static int meson_gx_pwrc_vpu_probe(struct platform_device *pdev)
 			return ret;
 	}
 
-	pm_genpd_init(&vpu_pd->genpd, &pm_domain_always_on_gov,
-		      powered_off);
+	vpu_pd->genpd.flags = GENPD_FLAG_ALWAYS_ON;
+	pm_genpd_init(&vpu_pd->genpd, NULL, powered_off);
 
 	return of_genpd_add_provider_simple(pdev->dev.of_node,
 					    &vpu_pd->genpd);
Signature · 7 lines
2.28.0


_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic
Acked-by on v1 1/1
#1 lore raw
Quoted 31 lines · Kevin Hilman

Rather than use a governor to keep these domains always-on, instead use the flag GENPD_FLAG_ALWAYS_ON. This has the same effect, but with much lower overhead since the governor path is not used at all.

---
 drivers/soc/amlogic/meson-ee-pwrc.c     | 4 ++--
 drivers/soc/amlogic/meson-gx-pwrc-vpu.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/soc/amlogic/meson-ee-pwrc.c +2 -2
index 43665b77aa9e..a8f18bb17491 100644
@@ -433,8 +433,8 @@ static int meson_ee_pwrc_init_domain(struct platform_device *pdev,
 		if (ret)
 			return ret;
 
-		ret = pm_genpd_init(&dom->base, &pm_domain_always_on_gov,
-				    false);
+		dom->base.flags = GENPD_FLAG_ALWAYS_ON;
+		ret = pm_genpd_init(&dom->base, NULL, false);
 		if (ret)
 			return ret;
 	} else {
drivers/soc/amlogic/meson-gx-pwrc-vpu.c +0 -0
index 511b6856225d..21b4bc811c00 100644

drivers/soc/amlogic/meson-gx-pwrc-vpu.c static int meson_gx_pwrc_vpu_probe(struct platform_device *pdev) · line 346

Quoted 10 lines
drivers/soc/amlogic/meson-gx-pwrc-vpu.c +2 -2
@@ -339,8 +339,8 @@ static int meson_gx_pwrc_vpu_probe(struct platform_device *pdev)
 			return ret;
 	}
 
-	pm_genpd_init(&vpu_pd->genpd, &pm_domain_always_on_gov,
-		      powered_off);
+	vpu_pd->genpd.flags = GENPD_FLAG_ALWAYS_ON;
+	pm_genpd_init(&vpu_pd->genpd, NULL, powered_off);
 
 	return of_genpd_add_provider_simple(pdev->dev.of_node,
 					    &vpu_pd->genpd);

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic