Skip to contentSkip to conversation

gpio: pca953x: Use handle_simple_irq instead of handle_edge_irq

PATCH New Erik Botö 1 participant 1 message Apr 26, 2011 GPIO

lore
Share & tools
lore

Erik Botö

author
#0 lore raw

PATCH 1/1 gpio: pca953x: Use handle_simple_irq instead of handle_edge_irq

Make pca953x driver use the simple irq handler since no hardware control is necessary and the driver lacks an irq_ack function. handle_edge_irq() calls chip->irq_ack() which crashes since this function does not exist.

---

drivers/gpio/pca953x.c +1 -1
index 7630ab7..78a8439 100644
@@ -397,7 +397,7 @@ static int pca953x_irq_setup(struct pca953x_chip *chip,
 
 			irq_set_chip_data(irq, chip);
 			irq_set_chip_and_handler(irq, &pca953x_irq_chip,
-						 handle_edge_irq);
+						 handle_simple_irq);
 #ifdef CONFIG_ARM
 			set_irq_flags(irq, IRQF_VALID);
 #else