perf misc cleanup

PATCH In review Lin Ming 4 participants 9 messages Apr 29, 2011 – May 10, 2011 perf events

lore

Share & tools

lore

Lin Ming

author

2011-04-29 08:33 UTC #0 lore raw

cover perf misc cleanup

Hi, Arnaldo

Could you take below 2 one-line patches?

[RESEND PATCH 1/2] perf probe: Fix the missed parameter initialization
[PATCH 2/2] perf annotate: Remove duplicate header file

Thanks,
Lin Ming

Lin Ming

author

2011-04-29 08:33 UTC #1 lore raw

PATCH RESEND 1/2 perf probe: Fix the missed parameter initialization

pubname_callback_param::found should be initialized to 0 in fastpath lookup.

Signed-off-by Lin Ming <[email protected]>

---
 tools/perf/util/probe-finder.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

tools/perf/util/probe-finder.c +1 -0

index a7c7145..3b9d0b8 100644
@@ -1538,6 +1538,7 @@ static int find_probes(int fd, struct probe_finder *pf)
 			.file	  = pp->file,
 			.cu_die	  = &pf->cu_die,
 			.sp_die	  = &pf->sp_die,
+			.found	  = 0,
 		};
 		struct dwarf_callback_param probe_param = {
 			.data = pf,

Signature · 1 line

1.7.4.4

Ingo Molnar

2011-04-29 09:44 UTC #2 lore raw

Re: [RESEND PATCH 1/2] perf probe: Fix the missed parameter initialization

Quoted 12 lines · Lin Ming

pubname_callback_param::found should be initialized to 0 in fastpath lookup.
Signed-off-by Lin Ming <[email protected]>
---
 tools/perf/util/probe-finder.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
tools/perf/util/probe-finder.c +0 -0
index a7c7145..3b9d0b8 100644

tools/perf/util/probe-finder.c static int find_probes(int fd, struct probe_finder *pf) · line 1541

Quoted 4 lines

tools/perf/util/probe-finder.c +1 -0

@@ -1538,6 +1538,7 @@ static int find_probes(int fd, struct probe_finder *pf)
 			.file	  = pp->file,
 			.cu_die	  = &pf->cu_die,
 			.sp_die	  = &pf->sp_die,
+			.found	  = 0,

Hm, why is this a 'misc cleanup'? If this field is uninitialized (it does appear so) and we rely on the field then right now this is a bug and the fix should be pushed to perf/urgent.

Thanks,

Ingo

Lin Ming

author

2011-04-29 13:18 UTC #3 lore raw

Re: [RESEND PATCH 1/2] perf probe: Fix the missed parameter initialization

Quoted 9 lines · Ingo Molnar

Quoted 7 lines · Lin Ming
pubname_callback_param::found should be initialized to 0 in fastpath lookup.
Signed-off-by Lin Ming <[email protected]>
---
 tools/perf/util/probe-finder.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Quoted 11 lines

tools/perf/util/probe-finder.c static int find_probes(int fd, struct probe_finder *pf) · line 1541
Quoted 9 lines
tools/perf/util/probe-finder.c +1 -0
index a7c7145..3b9d0b8 100644
@@ -1538,6 +1538,7 @@ static int find_probes(int fd, struct probe_finder *pf)
 			.file	  = pp->file,
 			.cu_die	  = &pf->cu_die,
 			.sp_die	  = &pf->sp_die,
+			.found	  = 0,
Hm, why is this a 'misc cleanup'? If this field is uninitialized (it does

I should call it 'misc cleanup and fix'.

Quoted 2 lines

appear so) and we rely on the field then right now this is a bug and the fix should be pushed to perf/urgent.

Indeed.

Quoted 4 lines

Thanks,
Ingo

Arnaldo Carvalho de Melo

2011-04-29 17:33 UTC #4 lore raw

Re: [RESEND PATCH 1/2] perf probe: Fix the missed parameter initialization

In reply to Lin Ming

Em Fri, Apr 29, 2011 at 08:41:57AM +0000, Lin Ming escreveu:

Quoted 1 line

pubname_callback_param::found should be initialized to 0 in fastpath lookup.

Is this really needed? Or is this just to stress it, for documentational purposes?

Quoted 19 lines

Signed-off-by Lin Ming <[email protected]>

---
 tools/perf/util/probe-finder.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

tools/perf/util/probe-finder.c +1 -0

index a7c7145..3b9d0b8 100644
@@ -1538,6 +1538,7 @@ static int find_probes(int fd, struct probe_finder *pf)
 			.file	  = pp->file,
 			.cu_die	  = &pf->cu_die,
 			.sp_die	  = &pf->sp_die,
+			.found	  = 0,
 		};
 		struct dwarf_callback_param probe_param = {
 			.data = pf,

Signature · 1 line

1.7.4.4

Lin Ming

author

2011-04-30 04:14 UTC #5 lore raw

Re: [RESEND PATCH 1/2] perf probe: Fix the missed parameter initialization

Quoted 6 lines · Arnaldo Carvalho de Melo

Em Fri, Apr 29, 2011 at 08:41:57AM +0000, Lin Ming escreveu:
Quoted 1 line
pubname_callback_param::found should be initialized to 0 in fastpath lookup.
Is this really needed? Or is this just to stress it, for documentational purposes?

Yes, this is really needed.

It should be initialized to 0, and pubname_search_cb will set it to 1 if the function is found.

Quoted 20 lines

Signed-off-by Lin Ming <[email protected]>

---
 tools/perf/util/probe-finder.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

tools/perf/util/probe-finder.c +1 -0

index a7c7145..3b9d0b8 100644
@@ -1538,6 +1538,7 @@ static int find_probes(int fd, struct probe_finder *pf)
 			.file	  = pp->file,
 			.cu_die	  = &pf->cu_die,
 			.sp_die	  = &pf->sp_die,
+			.found	  = 0,
 		};
 		struct dwarf_callback_param probe_param = {
 			.data = pf,

Signature · 1 line

1.7.4.4

Lin Ming

2011-05-10 13:43 UTC #6 lore raw

Re: [RESEND PATCH 1/2] perf probe: Fix the missed parameter initialization

Quoted 5 lines · Lin Ming

Quoted 4 lines · Arnaldo Carvalho de Melo
Em Fri, Apr 29, 2011 at 08:41:57AM +0000, Lin Ming escreveu:
Quoted 1 line
pubname_callback_param::found should be initialized to 0 in fastpath lookup.

Quoted 7 lines

Quoted 2 lines
Is this really needed? Or is this just to stress it, for documentational purposes?
Yes, this is really needed.
It should be initialized to 0, and pubname_search_cb will set it to 1 if the function is found.

ping ...

Signature · 1 line

Lin Ming -- Intel Open Source Technology Center

tip-bot for Lin Ming

author

2011-05-10 20:13 UTC #7 lore raw

[tip:perf/core] perf probe: Fix the missed parameter initialization

In reply to Lin Ming

Commit-ID:  2b348a77981227c6b64fb9cf19f7c711a6806bc9
Gitweb:     http://git.kernel.org/tip/2b348a77981227c6b64fb9cf19f7c711a6806bc9
Author:     Lin Ming <[email protected]>
AuthorDate: Fri, 29 Apr 2011 08:41:57 +0000
Committer:  Ingo Molnar <[email protected]>
CommitDate: Tue, 10 May 2011 17:06:23 +0200

perf probe: Fix the missed parameter initialization

pubname_callback_param::found should be initialized to 0 in fastpath lookup, the structure is on the stack and uninitialized otherwise.

Signed-off-by Lin Ming <[email protected]>

Cc Arnaldo Carvalho de Melo <[email protected]>

Link http://lkml.kernel.org/r/[email protected] open here

Signed-off-by Ingo Molnar <[email protected]>

---
 tools/perf/util/probe-finder.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

tools/perf/util/probe-finder.c +1 -0

index a7c7145..3b9d0b8 100644
@@ -1538,6 +1538,7 @@ static int find_probes(int fd, struct probe_finder *pf)
 			.file	  = pp->file,
 			.cu_die	  = &pf->cu_die,
 			.sp_die	  = &pf->sp_die,
+			.found	  = 0,
 		};
 		struct dwarf_callback_param probe_param = {
 			.data = pf,

Lin Ming

author

2011-04-29 08:33 UTC #8 lore raw

PATCH 2/2 perf annotate: Remove duplicate header file

In reply to Lin Ming

annotate.h was included twice, remove one.

Signed-off-by Lin Ming <[email protected]>

---
 tools/perf/util/ui/browsers/annotate.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

tools/perf/util/ui/browsers/annotate.c +0 -1

index 15633d6..4bb69e8 100644
@@ -1,7 +1,6 @@
 #include "../browser.h"
 #include "../helpline.h"
 #include "../libslang.h"
-#include "../../annotate.h"
 #include "../../hist.h"
 #include "../../sort.h"
 #include "../../symbol.h"

Signature · 1 line

1.7.4.4