Input: h3600_ts: fix a leak of the IRQ during init failure

PATCH New Axel Lin 1 participant 1 message May 1, 2011

Subsystems (2)

HID Input drivers

lore

Share & tools

lore

Axel Lin

author

2011-05-01 16:13 UTC #0 lore raw

PATCH 1/1 Input: h3600_ts: fix a leak of the IRQ during init failure

In h3600ts_connect error path, free_irq() was using ts->dev rather than the &ts->dev as the data pointer so free_irq() wouldn't have matched.

Signed-off-by Axel Lin <[email protected]>

---
 drivers/input/touchscreen/h3600_ts_input.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

drivers/input/touchscreen/h3600_ts_input.c +2 -2

index 45f93d0..e45ae38 100644
@@ -424,8 +424,8 @@ static int h3600ts_connect(struct serio *serio, struct serio_driver *drv)
 
 fail4:	serio_close(serio);
 fail3:	serio_set_drvdata(serio, NULL);
-	free_irq(IRQ_GPIO_BITSY_NPOWER_BUTTON, ts->dev);
-fail2:	free_irq(IRQ_GPIO_BITSY_ACTION_BUTTON, ts->dev);
+	free_irq(IRQ_GPIO_BITSY_NPOWER_BUTTON, &ts->dev);
+fail2:	free_irq(IRQ_GPIO_BITSY_ACTION_BUTTON, &ts->dev);
 fail1:	input_free_device(input_dev);
 	kfree(ts);
 	return err;

Signature · 1 line

1.7.1