Skip to contentSkip to conversation

x264_r2245: do not override `DEPENDS` for x86

PATCH In review Bob Foerster 2 participants 5 messages May 8, 2011 – May 9, 2011

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 x264_r2245: do not override `DEPENDS` for x86

The recipe intended to add "yasm-native" to the dependencies on x86, but it set DEPENDS_x86 = "yasm-native" which obliterated the base dependencies. On a fresh build, this package was failing since it was trying to build before the compiler was ready.

Depends is now set with DEPENDS_append_x86, which leaves the base dependencies intact.

---
 recipes/vlc/x264_r2245.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
recipes/vlc/x264_r2245.bb +1 -1
index 0cffea3..21e5a0e 100644
@@ -23,7 +23,7 @@ X264_ECFLAGS_mipsel = "-fPIC"
 X264_DISABLE_ASM = "--disable-asm"
 # use assembler written functions for those archs supporting this
 X264_DISABLE_ASM_x86 = ""
-DEPENDS_x86 = "yasm-native"
+DEPENDS_append_x86 = " yasm-native"
 
 EXTRA_OECONF = '--enable-shared ${X264_DISABLE_ASM} --extra-cflags="${X264_ECFLAGS}"'
 
Signature · 1 line
1.7.1
Acked-by on v2 1/1
#1 lore raw

Dear Bob,

Am Sonntag, den 08.05.2011, 07:00 -0400 schrieb Bob Foerster:

Quoted 7 lines

The recipe intended to add "yasm-native" to the dependencies on x86, but it set DEPENDS_x86 = "yasm-native" which obliterated the base dependencies. On a fresh build, this package was failing since it was trying to build before the compiler was ready.

Depends is now set with DEPENDS_append_x86, which leaves the base dependencies intact.

Btw. What MACHINE and DISTRIBUTION do you use?

Quoted 10 lines
---
 recipes/vlc/x264_r2245.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
recipes/vlc/x264_r2245.bb +0 -0
index 0cffea3..21e5a0e 100644

recipes/vlc/x264_r2245.bb X264_ECFLAGS_mipsel = "-fPIC" · line 28

Quoted 7 lines
recipes/vlc/x264_r2245.bb +1 -1
@@ -23,7 +23,7 @@ X264_ECFLAGS_mipsel = "-fPIC"
 X264_DISABLE_ASM = "--disable-asm"
 # use assembler written functions for those archs supporting this
 X264_DISABLE_ASM_x86 = ""
-DEPENDS_x86 = "yasm-native"
+DEPENDS_append_x86 = " yasm-native"
 
 EXTRA_OECONF = '--enable-shared ${X264_DISABLE_ASM} --extra-cflags="${X264_ECFLAGS}"'

Thanks,

Paul

#2 lore raw
Quoted 9 lines · Paul Menzel

Dear Bob,

Am Sonntag, den 08.05.2011, 07:00 -0400 schrieb Bob Foerster:

Quoted 5 lines

The recipe intended to add "yasm-native" to the dependencies on x86, but it set DEPENDS_x86 = "yasm-native" which obliterated the base dependencies. On a fresh build, this package was failing since it was trying to build before the compiler was ready.

Quoted 5 lines
Quoted 2 lines

Depends is now set with DEPENDS_append_x86, which leaves the base dependencies intact.

Btw. What MACHINE and DISTRIBUTION do you use?

machine=x86, distro=custom

Quoted 33 lines
Quoted 11 lines
---
 recipes/vlc/x264_r2245.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
recipes/vlc/x264_r2245.bb +0 -0
index 0cffea3..21e5a0e 100644

recipes/vlc/x264_r2245.bb X264_ECFLAGS_mipsel = "-fPIC" · line 28

Quoted 7 lines
recipes/vlc/x264_r2245.bb +1 -1
@@ -23,7 +23,7 @@ X264_ECFLAGS_mipsel = "-fPIC"
 X264_DISABLE_ASM = "--disable-asm"
 # use assembler written functions for those archs supporting this
 X264_DISABLE_ASM_x86 = ""
-DEPENDS_x86 = "yasm-native"
+DEPENDS_append_x86 = " yasm-native"
 
 EXTRA_OECONF = '--enable-shared ${X264_DISABLE_ASM}

--extra-cflags="${X264_ECFLAGS}"'

Thanks,

Paul

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

#3 lore raw

Am Sonntag, den 08.05.2011, 07:33 -0400 schrieb Robert Foerster:

Quoted 8 lines · Paul Menzel
Quoted 7 lines

Am Sonntag, den 08.05.2011, 07:00 -0400 schrieb Bob Foerster:

Quoted 5 lines

The recipe intended to add "yasm-native" to the dependencies on x86, but it set DEPENDS_x86 = "yasm-native" which obliterated the base dependencies. On a fresh build, this package was failing since it was trying to build before the compiler was ready.

Quoted 27 lines
Quoted 4 lines
Quoted 2 lines

Depends is now set with DEPENDS_append_x86, which leaves the base dependencies intact.

Btw. What MACHINE and DISTRIBUTION do you use?

machine=x86, distro=custom

Quoted 20 lines
Quoted 10 lines
---
 recipes/vlc/x264_r2245.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
recipes/vlc/x264_r2245.bb +0 -0
index 0cffea3..21e5a0e 100644

recipes/vlc/x264_r2245.bb X264_ECFLAGS_mipsel = "-fPIC" · line 28

Quoted 7 lines
recipes/vlc/x264_r2245.bb +1 -1
@@ -23,7 +23,7 @@ X264_ECFLAGS_mipsel = "-fPIC"
 X264_DISABLE_ASM = "--disable-asm"
 # use assembler written functions for those archs supporting this
 X264_DISABLE_ASM_x86 = ""
-DEPENDS_x86 = "yasm-native"
+DEPENDS_append_x86 = " yasm-native"
 
 EXTRA_OECONF = '--enable-shared ${X264_DISABLE_ASM}

--extra-cflags="${X264_ECFLAGS}"'

I pushed your patch upstream in 0409d1d9 [1].

Please update the patch queue [2] with for example the following command.

	$ pwclient update -s Accepted -c 0409d1d98a400c56d348de1f49c8a09f38b52fba 3385

I do not have the rights to change the state of patches I did not submit.

Thanks,

Paul

[1] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=0409d1d98a400c56d348de1f49c8a09f38b52fba
[2] http://openembedded.org/index.php/Patchwork

#4 lore raw
Quoted 39 lines · Paul Menzel

Am Sonntag, den 08.05.2011, 07:33 -0400 schrieb Robert Foerster:

Quoted 8 lines · Paul Menzel
Quoted 7 lines

Am Sonntag, den 08.05.2011, 07:00 -0400 schrieb Bob Foerster:

Quoted 5 lines

The recipe intended to add "yasm-native" to the dependencies on x86, but it set DEPENDS_x86 = "yasm-native" which obliterated the base dependencies. On a fresh build, this package was failing since it was trying to build before the compiler was ready.

Quoted 27 lines
Quoted 4 lines
Quoted 2 lines

Depends is now set with DEPENDS_append_x86, which leaves the base dependencies intact.

Btw. What MACHINE and DISTRIBUTION do you use?

machine=x86, distro=custom

Quoted 20 lines
Quoted 10 lines
---
 recipes/vlc/x264_r2245.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
recipes/vlc/x264_r2245.bb +0 -0
index 0cffea3..21e5a0e 100644

recipes/vlc/x264_r2245.bb X264_ECFLAGS_mipsel = "-fPIC" · line 28

Quoted 7 lines
recipes/vlc/x264_r2245.bb +1 -1
@@ -23,7 +23,7 @@ X264_ECFLAGS_mipsel = "-fPIC"
 X264_DISABLE_ASM = "--disable-asm"
 # use assembler written functions for those archs supporting this
 X264_DISABLE_ASM_x86 = ""
-DEPENDS_x86 = "yasm-native"
+DEPENDS_append_x86 = " yasm-native"
 
 EXTRA_OECONF = '--enable-shared ${X264_DISABLE_ASM}

--extra-cflags="${X264_ECFLAGS}"'

I pushed your patch upstream in 0409d1d9 [1].

Quoted 11 lines

Please update the patch queue [2] with for example the following command.

       $ pwclient update -s Accepted -c
0409d1d98a400c56d348de1f49c8a09f38b52fba 3385

I do not have the rights to change the state of patches I did not submit.

Done. Thanks, Paul!

Quoted 15 lines

Thanks,

Paul

[1]
http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=0409d1d98a400c56d348de1f49c8a09f38b52fba
[2] http://openembedded.org/index.php/Patchwork

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel