remove unused parameters from sched_fork() and wake_up_new_task()

PATCH In review Samir Bellabes 1 participant 2 messages May 11, 2011 – May 12, 2011

Subsystems (3)

MM core Scheduler exec and binfmt

lore

Share & tools

lore

Samir Bellabes

author

2011-05-11 16:18 UTC #0 lore raw

PATCH 1/1 remove unused parameters from sched_fork() and wake_up_new_task()

sched_fork() and wake_up_new_task() are defined with a parameter 'unsigned long clone_flags', which is unused.
This patch removes the parameters.

Signed-off-by Samir Bellabes <[email protected]>

---
 include/linux/sched.h |    5 ++---
 kernel/fork.c         |    4 ++--
 kernel/sched.c        |    4 ++--
 3 files changed, 6 insertions(+), 7 deletions(-)

include/linux/sched.h +2 -3

index 4ec2c02..fef4a76 100644
@@ -2057,14 +2057,13 @@ extern void xtime_update(unsigned long ticks);
 
 extern int wake_up_state(struct task_struct *tsk, unsigned int state);
 extern int wake_up_process(struct task_struct *tsk);
-extern void wake_up_new_task(struct task_struct *tsk,
-				unsigned long clone_flags);
+extern void wake_up_new_task(struct task_struct *tsk);
 #ifdef CONFIG_SMP
  extern void kick_process(struct task_struct *tsk);
 #else
  static inline void kick_process(struct task_struct *tsk) { }
 #endif
-extern void sched_fork(struct task_struct *p, int clone_flags);
+extern void sched_fork(struct task_struct *p);
 extern void sched_dead(struct task_struct *p);
 
 extern void proc_caches_init(void);

kernel/fork.c +2 -2

index e7548de..7c440fa 100644
@@ -1153,7 +1153,7 @@ static struct task_struct *copy_process(unsigned long clone_flags,
 #endif
 
 	/* Perform scheduler related setup. Assign this task to a CPU. */
-	sched_fork(p, clone_flags);
+	sched_fork(p);
 
 	retval = perf_event_init_task(p);
 	if (retval)

@@ -1464,7 +1464,7 @@ long do_fork(unsigned long clone_flags,
 		 */
 		p->flags &= ~PF_STARTING;
 
-		wake_up_new_task(p, clone_flags);
+		wake_up_new_task(p);
 
 		tracehook_report_clone_complete(trace, regs,
 						clone_flags, nr, p);

kernel/sched.c +2 -2

index 4801363..3105b01 100644
@@ -2626,7 +2626,7 @@ static void __sched_fork(struct task_struct *p)
 /*
  * fork()/clone()-time setup:
  */
-void sched_fork(struct task_struct *p, int clone_flags)
+void sched_fork(struct task_struct *p)
 {
 	int cpu = get_cpu();

@@ -2707,7 +2707,7 @@ void sched_fork(struct task_struct *p, int clone_flags)
  * that must be done for every newly created context, then puts the task
  * on the runqueue and wakes it.
  */
-void wake_up_new_task(struct task_struct *p, unsigned long clone_flags)
+void wake_up_new_task(struct task_struct *p)
 {
 	unsigned long flags;
 	struct rq *rq;

Signature · 1 line

1.7.4.1

tip-bot for Samir Bellabes

author

2011-05-12 13:04 UTC #1 lore raw

[tip:sched/core] sched: Remove unused parameters from sched_fork() and wake_up_new_task()

Commit-ID:  3e51e3edfd81bfd9853ad7de91167e4ce33d0fe7
Gitweb:     http://git.kernel.org/tip/3e51e3edfd81bfd9853ad7de91167e4ce33d0fe7
Author:     Samir Bellabes <[email protected]>
AuthorDate: Wed, 11 May 2011 18:18:05 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Thu, 12 May 2011 09:36:37 +0200

sched: Remove unused parameters from sched_fork() and wake_up_new_task()

sched_fork() and wake_up_new_task() are defined with a parameter 'unsigned long clone_flags', which is unused.

This patch removes the parameters.

Signed-off-by Samir Bellabes <[email protected]>

Acked-by Peter Zijlstra <[email protected]>

Link http://lkml.kernel.org/r/[email protected] open here

Signed-off-by Ingo Molnar <[email protected]>

---
 include/linux/sched.h |    5 ++---
 kernel/fork.c         |    4 ++--
 kernel/sched.c        |    4 ++--
 3 files changed, 6 insertions(+), 7 deletions(-)

include/linux/sched.h +2 -3

index 6b4280b..12211e1 100644
@@ -2051,14 +2051,13 @@ extern void xtime_update(unsigned long ticks);
 
 extern int wake_up_state(struct task_struct *tsk, unsigned int state);
 extern int wake_up_process(struct task_struct *tsk);
-extern void wake_up_new_task(struct task_struct *tsk,
-				unsigned long clone_flags);
+extern void wake_up_new_task(struct task_struct *tsk);
 #ifdef CONFIG_SMP
  extern void kick_process(struct task_struct *tsk);
 #else
  static inline void kick_process(struct task_struct *tsk) { }
 #endif
-extern void sched_fork(struct task_struct *p, int clone_flags);
+extern void sched_fork(struct task_struct *p);
 extern void sched_dead(struct task_struct *p);
 
 extern void proc_caches_init(void);

kernel/fork.c +2 -2

index aca6287..2b44d82 100644
@@ -1152,7 +1152,7 @@ static struct task_struct *copy_process(unsigned long clone_flags,
 #endif
 
 	/* Perform scheduler related setup. Assign this task to a CPU. */
-	sched_fork(p, clone_flags);
+	sched_fork(p);
 
 	retval = perf_event_init_task(p);
 	if (retval)

@@ -1463,7 +1463,7 @@ long do_fork(unsigned long clone_flags,
 		 */
 		p->flags &= ~PF_STARTING;
 
-		wake_up_new_task(p, clone_flags);
+		wake_up_new_task(p);
 
 		tracehook_report_clone_complete(trace, regs,
 						clone_flags, nr, p);

kernel/sched.c +2 -2

index da93381..f9778c0 100644
@@ -2741,7 +2741,7 @@ static void __sched_fork(struct task_struct *p)
 /*
  * fork()/clone()-time setup:
  */
-void sched_fork(struct task_struct *p, int clone_flags)
+void sched_fork(struct task_struct *p)
 {
 	unsigned long flags;
 	int cpu = get_cpu();

@@ -2823,7 +2823,7 @@ void sched_fork(struct task_struct *p, int clone_flags)
  * that must be done for every newly created context, then puts the task
  * on the runqueue and wakes it.
  */
-void wake_up_new_task(struct task_struct *p, unsigned long clone_flags)
+void wake_up_new_task(struct task_struct *p)
 {
 	unsigned long flags;
 	struct rq *rq;