Skip to contentSkip to conversation

mioa701: move gpio-pullup functionality to gpio-vbus

PATCH New Dmitry Eremin-Solenikov 2 participants 3 messages May 18, 2011 – May 21, 2011

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mioa701: move gpio-pullup functionality to gpio-vbus

gpio-vbus can (and should?) handle D+ pullup gpio for us. Move gpio-pullup handling to gpio-vbus and stop providing udc_info as it's empty now.

---
 arch/arm/mach-pxa/mioa701.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)
arch/arm/mach-pxa/mioa701.c +1 -6
index 05f9efb..239d81e 100644
@@ -402,14 +402,10 @@ static void gsm_exit(void)
 /*
  * USB UDC
  */
-static struct pxa2xx_udc_mach_info mioa701_udc_info = {
-	.gpio_pullup	  = GPIO22_USB_ENABLE,
-};
-
 struct gpio_vbus_mach_info gpio_vbus_data = {
 	.gpio_vbus = GPIO13_nUSB_DETECT,
 	.gpio_vbus_inverted = 1,
-	.gpio_pullup = -1,
+	.gpio_pullup = GPIO22_USB_ENABLE,
 };
 
 /*
@@ -797,7 +793,6 @@ static void __init mioa701_machine_init(void)
 	pxa_set_fb_info(NULL, &mioa701_pxafb_info);
 	pxa_set_mci_info(&mioa701_mci_info);
 	pxa_set_keypad_info(&mioa701_keypad_info);
-	pxa_set_udc_info(&mioa701_udc_info);
 	pxa_set_ac97_info(&mioa701_ac97_info);
 	pm_power_off = mioa701_poweroff;
 	arm_pm_restart = mioa701_restart;
Signature · 1 line
1.7.4.4
maintainer
#1 lore raw

PATCH 1/1 mioa701: move gpio-pullup functionality to gpio-vbus

Quoted 2 lines · Dmitry Eremin-Solenikov

gpio-vbus can (and should?) handle D+ pullup gpio for us. Move gpio-pullup handling to gpio-vbus and stop providing udc_info as it's empty now.

No sorry, NAK.

As a matter of fact, even if gpio-vbus driver handles correctly the VBUS sensing and D+ line powering, it still lacks the suspend / resume handling to "disconnect the D+ line" on suspend and reconnect it on "resume". That's the reason I nack this patch, as for me, gpio-vbus and pxa27x-udc are not yet iso functional.

If I was provided proof that this is innoccuous (ie. there is no power draw possible in suspend, or that the resume procedure still works with gpio-vbus), then I'll ack the patch.

Cheers.

--
Robert

#2 lore raw

PATCH 1/1 mioa701: move gpio-pullup functionality to gpio-vbus

Quoted 11 lines · Robert Jarzmik
Quoted 3 lines · Dmitry Eremin-Solenikov

gpio-vbus can (and should?) handle D+ pullup gpio for us. Move gpio-pullup handling
to gpio-vbus and stop providing udc_info as it's empty now.

No sorry, NAK.

As a matter of fact, even if gpio-vbus driver handles correctly the VBUS sensing and D+ line powering, it still lacks the suspend / resume handling to "disconnect the D+ line" on suspend and reconnect it on "resume". That's the reason I nack this patch, as for me, gpio-vbus and pxa27x-udc are not yet iso functional.

gpio-vbus handles D+ line. It doesn't handle suspend.
BTW: do you mean system suspend (via pm->suspend), or USB suspend (via USB SUSPEND interrupt)

Quoted 3 lines

If I was provided proof that this is innoccuous (ie. there is no power draw possible in suspend, or that the resume procedure still works with gpio-vbus), then I'll ack the patch.

Hmm. I'll think about suspend issue (if you give me more info), but only you can test the resume. Could you please test it?

Signature · 2 lines
With best wishes
Dmitry