Skip to contentSkip to conversation

apr-util: disable odbc support to avoid QA error

PATCH In review Steffen Sledz 2 participants 4 messages May 23, 2011 – May 25, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 apr-util: disable odbc support to avoid QA error

The odbc checker part of the configure script seems to be buggy and may add host pathes to compiler and linker options:

--------->snip<--------
checking for odbc_config... /usr/bin/odbc_config
adding "-I/usr/include" to CPPFLAGS
adding "-L/usr/lib" to LDFLAGS
setting LIBS to "-L/usr/lib -lodbc"
--------->snip<--------

---
 recipes/apr/apr-util_1.3.10.bb |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
recipes/apr/apr-util_1.3.10.bb +2 -1
index ee32ddd..32b568e 100644
@@ -3,7 +3,7 @@ SECTION = "libs"
 DEPENDS = "apr expat gdbm"
 LICENSE = "Apache License, Version 2.0"
 
-PR = "r0"
+PR = "r1"
 
 SRC_URI = "${APACHE_MIRROR}/apr/${P}.tar.gz \
            file://configfix.patch \
@@ -15,6 +15,7 @@ EXTRA_OECONF = "--with-apr=${STAGING_BINDIR_CROSS}/apr-1-config \
 		--without-sqlite2 \
 		--without-sqlite3 \
 		--without-pgsql \
+		--without-odbc \
 		--with-expat=${STAGING_DIR_HOST}${layout_prefix}"
 
 SRC_URI[md5sum] = "82acd25cf3df8c72eba44eaee8b80c19"
Signature · 1 line
1.7.1
#1 lore raw
Quoted 11 lines · Steffen Sledz

The odbc checker part of the configure script seems to be buggy and may add host pathes to compiler and linker options:

--------->snip<--------
checking for odbc_config... /usr/bin/odbc_config
adding "-I/usr/include" to CPPFLAGS adding "-L/usr/lib" to LDFLAGS
setting LIBS to "-L/usr/lib -lodbc"
--------->snip<--------

If there are no NAKs i'll push this commit tonight to enable the build on linux distros like openSUSE which fail at the moment.

Steffen

Signature · 7 lines
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:[email protected]
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058
Acked-by on v1 1/1
#2 lore raw
In reply to Steffen Sledz

Am Montag, den 23.05.2011, 16:07 +0200 schrieb Steffen Sledz:

Quoted 2 lines

The odbc checker part of the configure script seems to be buggy and may add host pathes to compiler and linker options:

s/patches/paths/

Quoted 7 lines

--------->snip<--------
checking for odbc_config... /usr/bin/odbc_config
adding "-I/usr/include" to CPPFLAGS
adding "-L/usr/lib" to LDFLAGS
setting LIBS to "-L/usr/lib -lodbc"
--------->snip<--------

Did you report that problem upstream?

Why is that a QA error? I would have guessed that the compilation would fail.

Quoted 19 lines
---
 recipes/apr/apr-util_1.3.10.bb |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
recipes/apr/apr-util_1.3.10.bb +1 -1
index ee32ddd..32b568e 100644
@@ -3,7 +3,7 @@ SECTION = "libs"
 DEPENDS = "apr expat gdbm"
 LICENSE = "Apache License, Version 2.0"
 
-PR = "r0"
+PR = "r1"
 
 SRC_URI = "${APACHE_MIRROR}/apr/${P}.tar.gz \
            file://configfix.patch \

recipes/apr/apr-util_1.3.10.bb EXTRA_OECONF = "--with-apr=${STAGING_BINDIR_CROSS}/apr-1-config \ · line 21

Quoted 7 lines
recipes/apr/apr-util_1.3.10.bb +1 -0
@@ -15,6 +15,7 @@ EXTRA_OECONF = "--with-apr=${STAGING_BINDIR_CROSS}/apr-1-config \
 		--without-sqlite2 \
 		--without-sqlite3 \
 		--without-pgsql \
+		--without-odbc \
 		--with-expat=${STAGING_DIR_HOST}${layout_prefix}"
 
 SRC_URI[md5sum] = "82acd25cf3df8c72eba44eaee8b80c19"

Anyway, since odbc_config does not seem to be packaged for OpenEmbedded, disabling that option seems like a sane thing.

Thanks,

Paul

#3 lore raw

Am 24.05.2011 22:58, schrieb Paul Menzel:

Quoted 5 lines

Am Montag, den 23.05.2011, 16:07 +0200 schrieb Steffen Sledz:

Quoted 2 lines

The odbc checker part of the configure script seems to be buggy and may add host pathes to compiler and linker options:

s/patches/paths/

s/pathes/paths/ ;-)

Quoted 9 lines
Quoted 6 lines

--------->snip<--------
checking for odbc_config... /usr/bin/odbc_config
adding "-I/usr/include" to CPPFLAGS
adding "-L/usr/lib" to LDFLAGS
setting LIBS to "-L/usr/lib -lodbc"
--------->snip<--------

Why is that a QA error? I would have guessed that the compilation would fail.

I'm not at the HEAD of org.openembedded.dev but i got this fatal without my patch:

--------->snip<--------
FATAL: This autoconf log indicates errors, it looked at host includes.
Rerun configure task after fixing this. The path was '/home/sledz/work/HydraIP/OE/tmp.6/work/armv5te-angstrom-linux-gnueabi/apr-util-1.3.10-r0/apr-util-1.3.10'
ERROR: Error in executing python function in: /home/sledz/work/openembedded/recipes/apr/apr-util_1.3.10.bb
ERROR: Exception:<type 'exceptions.SystemExit'> Message:1
ERROR: Printing the environment of the function
ERROR: Function do_qa_configure failed
ERROR: TaskFailed event exception, aborting
ERROR: Build of /home/sledz/work/openembedded/recipes/apr/apr-util_1.3.10.bb do_qa_configure failed
NOTE: package apr-util-1.3.10-r0: task do_configure: Succeeded
ERROR: Task 12 (/home/sledz/work/openembedded/recipes/apr/apr-util_1.3.10.bb, do_qa_configure) failed with 256
ERROR: '/home/sledz/work/openembedded/recipes/apr/apr-util_1.3.10.bb' failed
NOTE: Running task 625 of 635 (ID: 12, /home/sledz/work/openembedded/recipes/apr/apr-util_1.3.10.bb, do_qa_configure)
NOTE: package apr-util-1.3.10-r0: task do_qa_configure: Started
FATAL: This autoconf log indicates errors, it looked at host includes.
Rerun configure task after fixing this. The path was '/home/sledz/work/HydraIP/OE/tmp.6/work/armv5te-angstrom-linux-gnueabi/apr-util-1.3.10-r0/apr-util-1.3.10'
ERROR: '/home/sledz/work/openembedded/recipes/apr/apr-util_1.3.10.bb' failed
--------->snip<--------

Quoted 4 lines

Anyway, since odbc_config does not seem to be packaged for OpenEmbedded, disabling that option seems like a sane thing.

Thanx and pushed.

Steffen

Signature · 7 lines
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:[email protected]
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058