Skip to contentSkip to conversation

drivers/misc: fix a memory leak in spear_pcie_gadget_probe error path

PATCH In review Axel Lin 2 participants 2 messages May 25, 2011 Char and misc drivers

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 drivers/misc: fix a memory leak in spear_pcie_gadget_probe error path

In the case of goto err_kzalloc, we should kfree target.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/misc/spear13xx_pcie_gadget.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/misc/spear13xx_pcie_gadget.c +1 -1
index 7aded90..cfbddbe 100644
@@ -845,7 +845,7 @@ err_iounmap:
 err_iounmap_app:
 	iounmap(config->va_app_base);
 err_kzalloc:
-	kfree(config);
+	kfree(target);
 err_rel_res:
 	release_mem_region(res1->start, resource_size(res1));
 err_rel_res0:
Signature · 1 line
1.7.1
#1 lore raw
Quoted 2 lines · Axel Lin

In the case of goto err_kzalloc, we should kfree target.

Yes, you are right. Its a mistake.

Regards
Pratyush

Quoted 18 lines
Signed-off-by Axel Lin <[email protected]>
---
 drivers/misc/spear13xx_pcie_gadget.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/misc/spear13xx_pcie_gadget.c +1 -1
index 7aded90..cfbddbe 100644
@@ -845,7 +845,7 @@ err_iounmap:
 err_iounmap_app:
 	iounmap(config->va_app_base);
 err_kzalloc:
-	kfree(config);
+	kfree(target);
 err_rel_res:
 	release_mem_region(res1->start, resource_size(res1));
 err_rel_res0: