Skip to contentSkip to conversation

phyCORE-i.MX27: Keep frequency multiplier enabled to be able to do a warmstart

PATCH Applied Juergen Beisert 3 participants 3 messages Nov 25, 2010 – Aug 25, 2011 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 phyCORE-i.MX27: Keep frequency multiplier enabled to be able to do a warmstart

commit 7d25a0552dd3a4b65412ae1cbf8f9ca8a88b5d27

Author: Juergen Beisert <[email protected]>
Date:   Thu Nov 25 17:49:11 2010 +0100

Keep frequency multiplier enabled to be able to do a warmstart

The wachtdog's reset does only reset the ARM core, not the whole silicon. But the PLLs seems to do some strange things: It seems they switch back to the low frequency reference when the watchdog barks. But in the case the frequency multiplier is off (not used due to 26 MHz reference usage) the machine stops, because the PLLs are stopping due to the lack of a reference frequency. As the power on reset will set the FPM_EN bit again, a power cycle brings the machine back to life.
By keeping the frequency multiplier enabled, also a warmstart triggered by the watchdog can restart the machine now.

arch/arm/boards/pcm038/pll.h +2 -0
index 13a7989..15b94cf 100644
@@ -36,6 +36,7 @@
 		CSCR_MCU_SEL | /* 26 MHz reference */ \
 		CSCR_ARM_DIV(0) | /* CPU runs at MPLL/3 clock */ \
 		CSCR_AHB_DIV(1) | /* AHB runs at MPLL/6 clock */ \
+		CSCR_FPM_EN | \
 		CSCR_SPEN |		\
 		CSCR_MPEN)
 
@@ -51,6 +52,7 @@
 		CSCR_ARM_SRC_MPLL | /* use main MPLL clock */ \
 		CSCR_ARM_DIV(0) | /* CPU run at full MPLL clock */ \
 		CSCR_AHB_DIV(1) | /* AHB runs at MPLL/6 clock */ \
+		CSCR_FPM_EN | /* do not disable it! */ \
 		CSCR_SPEN |		\
 		CSCR_MPEN)
 
Signature · 9 lines
Pengutronix e.K.                              | Juergen Beisert             |
Linux Solutions for Science and Industry      | Phone: +49-8766-939 228     |
Vertretung Sued/Muenchen, Germany             | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686              | http://www.pengutronix.de/  |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#1 lore raw

Are there any reasons why this patch was not added to the barebox? It works fine for us.

Teresa

Am Donnerstag, den 25.11.2010, 17:52 +0100 schrieb Juergen Beisert:

Quoted 32 lines

commit 7d25a0552dd3a4b65412ae1cbf8f9ca8a88b5d27

Author: Juergen Beisert <[email protected]>
Date:   Thu Nov 25 17:49:11 2010 +0100

Keep frequency multiplier enabled to be able to do a warmstart

The wachtdog's reset does only reset the ARM core, not the whole silicon. But the PLLs seems to do some strange things: It seems they switch back to the low frequency reference when the watchdog barks. But in the case the frequency multiplier is off (not used due to 26 MHz reference usage) the machine stops, because the PLLs are stopping due to the lack of a reference frequency. As the power on reset will set the FPM_EN bit again, a power cycle brings the machine back to life.
By keeping the frequency multiplier enabled, also a warmstart triggered by the watchdog can restart the machine now.

arch/arm/boards/pcm038/pll.h +1 -0
index 13a7989..15b94cf 100644
@@ -36,6 +36,7 @@
 		CSCR_MCU_SEL | /* 26 MHz reference */ \
 		CSCR_ARM_DIV(0) | /* CPU runs at MPLL/3 clock */ \
 		CSCR_AHB_DIV(1) | /* AHB runs at MPLL/6 clock */ \
+		CSCR_FPM_EN | \
 		CSCR_SPEN |		\
 		CSCR_MPEN)
 

arch/arm/boards/pcm038/pll.h line 58

Quoted 7 lines
arch/arm/boards/pcm038/pll.h +1 -0
@@ -51,6 +52,7 @@
 		CSCR_ARM_SRC_MPLL | /* use main MPLL clock */ \
 		CSCR_ARM_DIV(0) | /* CPU run at full MPLL clock */ \
 		CSCR_AHB_DIV(1) | /* AHB runs at MPLL/6 clock */ \
+		CSCR_FPM_EN | /* do not disable it! */ \
 		CSCR_SPEN |		\
 		CSCR_MPEN)
 

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

Applied
#2 lore raw
In reply to Juergen Beisert
Quoted 16 lines · Juergen Beisert

commit 7d25a0552dd3a4b65412ae1cbf8f9ca8a88b5d27

Author: Juergen Beisert <[email protected]>
Date:   Thu Nov 25 17:49:11 2010 +0100

Keep frequency multiplier enabled to be able to do a warmstart

The wachtdog's reset does only reset the ARM core, not the whole silicon. But the PLLs seems to do some strange things: It seems they switch back to the low frequency reference when the watchdog barks. But in the case the frequency multiplier is off (not used due to 26 MHz reference usage) the machine stops, because the PLLs are stopping due to the lack of a reference frequency. As the power on reset will set the FPM_EN bit again, a power cycle brings the machine back to life.
By keeping the frequency multiplier enabled, also a warmstart triggered by the watchdog can restart the machine now.

Quoted 1 line

Applied to master. Maintainer was asleep for a long long time.

Sascha

Quoted 33 lines
arch/arm/boards/pcm038/pll.h +2 -0
index 13a7989..15b94cf 100644
@@ -36,6 +36,7 @@
 		CSCR_MCU_SEL | /* 26 MHz reference */ \
 		CSCR_ARM_DIV(0) | /* CPU runs at MPLL/3 clock */ \
 		CSCR_AHB_DIV(1) | /* AHB runs at MPLL/6 clock */ \
+		CSCR_FPM_EN | \
 		CSCR_SPEN |		\
 		CSCR_MPEN)
 
@@ -51,6 +52,7 @@
 		CSCR_ARM_SRC_MPLL | /* use main MPLL clock */ \
 		CSCR_ARM_DIV(0) | /* CPU run at full MPLL clock */ \
 		CSCR_AHB_DIV(1) | /* AHB runs at MPLL/6 clock */ \
+		CSCR_FPM_EN | /* do not disable it! */ \
 		CSCR_SPEN |		\
 		CSCR_MPEN)
 
Signature · 10 lines
-- 
Pengutronix e.K.                              | Juergen Beisert             |
Linux Solutions for Science and Industry      | Phone: +49-8766-939 228     |
Vertretung Sued/Muenchen, Germany             | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686              | http://www.pengutronix.de/  |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox