misc fixed to compile uclibc in thumb mode and fix prserv

PATCH Applied Khem Raj 4 participants 6 messages May 28, 2011 – May 29, 2011

lore

Share & tools

lore

Khem Raj

author

2011-05-28 02:48 UTC #0 lore raw

cover misc fixed to compile uclibc in thumb mode and fix prserv

The following changes since commit ae1ba18f70c0dac5bed376f6677258c33290ce30:

uclibc: Add disabled COMPILE_IN_THUMB_MODE to uClibc.machine for all ARM configurations (2011-05-27 19:41:33 -0700)

are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib kraj/misc-fixes
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=kraj/misc-fixes

Khem Raj (2):
uclibc: Add disabled COMPILE_IN_THUMB_MODE to uClibc.machine for all
ARM configurations
package.bbclass,prserv.bbclass: Compare USE_PR_SERV with "1" or "0"

 meta/classes/package.bbclass                       |    2 +-
 meta/classes/prserv.bbclass                        |    2 +-
 .../uclibc/uclibc-git/arm/uClibc.machine           |    1 +
 .../uclibc/uclibc-git/armv5te/uClibc.machine       |    1 +
 .../uclibc/uclibc-git/nslu2be/uClibc.machine       |    1 +
 .../uclibc/uclibc-git/qemuarm/uClibc.machine       |    1 +
 6 files changed, 6 insertions(+), 2 deletions(-)

Signature · 1 line

1.7.4.1

Khem Raj

author

2011-05-28 02:48 UTC #1 lore raw

PATCH 1/2 uclibc: Add disabled COMPILE_IN_THUMB_MODE to uClibc.machine for all ARM configurations

This entry need to exist so that it can be manipulated later to decide if uclibc is to be compiled in thumb mode or arm mode

Signed-off-by Khem Raj <[email protected]>

---
 .../uclibc/uclibc-git/arm/uClibc.machine           |    1 +
 .../uclibc/uclibc-git/armv5te/uClibc.machine       |    1 +
 .../uclibc/uclibc-git/nslu2be/uClibc.machine       |    1 +
 .../uclibc/uclibc-git/qemuarm/uClibc.machine       |    1 +
 4 files changed, 4 insertions(+), 0 deletions(-)

meta/recipes-core/uclibc/uclibc-git/arm/uClibc.machine +1 -0

index 293f384..92ee868 100644
@@ -33,6 +33,7 @@ TARGET_ARCH="arm"
 FORCE_OPTIONS_FOR_ARCH=y
 # CONFIG_ARM_OABI is not set
 CONFIG_ARM_EABI=y
+# COMPILE_IN_THUMB_MODE is not set
 USE_BX=y
 CONFIG_GENERIC_ARM=y
 # CONFIG_ARM610 is not set

meta/recipes-core/uclibc/uclibc-git/armv5te/uClibc.machine +1 -0

index eb76f34..b012a38 100644
@@ -36,6 +36,7 @@ TARGET_ARCH="arm"
 FORCE_OPTIONS_FOR_ARCH=y
 # CONFIG_ARM_OABI is not set
 CONFIG_ARM_EABI=y
+# COMPILE_IN_THUMB_MODE is not set
 USE_BX=y
 CONFIG_GENERIC_ARM=y
 # CONFIG_ARM610 is not set

meta/recipes-core/uclibc/uclibc-git/nslu2be/uClibc.machine +1 -0

index f5aa134..6b07dd5 100644
@@ -33,6 +33,7 @@ TARGET_ARCH="arm"
 FORCE_OPTIONS_FOR_ARCH=y
 # CONFIG_ARM_OABI is not set
 CONFIG_ARM_EABI=y
+# COMPILE_IN_THUMB_MODE is not set
 USE_BX=y
 # CONFIG_GENERIC_ARM is not set
 # CONFIG_ARM610 is not set

meta/recipes-core/uclibc/uclibc-git/qemuarm/uClibc.machine +1 -0

index 7154278..2242dc9 100644
@@ -36,6 +36,7 @@ TARGET_ARCH="arm"
 FORCE_OPTIONS_FOR_ARCH=y
 # CONFIG_ARM_OABI is not set
 CONFIG_ARM_EABI=y
+# COMPILE_IN_THUMB_MODE is not set
 USE_BX=y
 # CONFIG_GENERIC_ARM is not set
 # CONFIG_ARM610 is not set

Signature · 1 line

1.7.4.1

Khem Raj

author

2011-05-28 02:48 UTC #2 lore raw

PATCH 2/2 package.bbclass, prserv.bbclass: Compare USE_PR_SERV with "1" or "0"

Value of USE_PR_SERV is either "1" or "0" looking at
settings in bitbake.conf
USE_PR_SERV = "${@[1,0][(bb.data.getVar('PRSERV_HOST',d,1) is None) or (bb.data.getVar('PRSERV_PORT',d,1) is None)]}" So we compare the strings

Signed-off-by Khem Raj <[email protected]>

---
 meta/classes/package.bbclass |    2 +-
 meta/classes/prserv.bbclass  |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

meta/classes/package.bbclass +1 -1

index a1b9482..1e6a872 100644
@@ -330,7 +330,7 @@ def runtime_mapping_rename (varname, d):
 #
 
 python package_get_auto_pr() {
-	if d.getVar('USE_PR_SERV', True):
+	if d.getVar('USE_PR_SERV', True) != "0":
 		auto_pr=prserv_get_pr_auto(d)
 		if auto_pr is None:
 			bb.fatal("Can NOT get auto PR revision from remote PR service")

meta/classes/prserv.bbclass +1 -1

index de46ff6..18b8589 100644
@@ -12,7 +12,7 @@ def prserv_make_conn(d):
     return conn
 
 def prserv_get_pr_auto(d):
-    if not d.getVar('USE_PR_SERV', True):
+    if d.getVar('USE_PR_SERV', True) != "0":
         bb.warn("Not using network based PR service")
         return None

Signature · 1 line

1.7.4.1

Koen Kooi

Tested-by on v1 2/2

2011-05-28 07:53 UTC #3 lore raw

Re: [PATCH 2/2] package.bbclass, prserv.bbclass: Compare USE_PR_SERV with "1" or "0"

Op 28 mei 2011, om 04:44 heeft Khem Raj het volgende geschreven:

Quoted 6 lines

Value of USE_PR_SERV is either "1" or "0" looking at
settings in bitbake.conf
USE_PR_SERV = "${@[1,0][(bb.data.getVar('PRSERV_HOST',d,1) is None) or (bb.data.getVar('PRSERV_PORT',d,1) is None)]}" So we compare the strings
Signed-off-by Khem Raj <[email protected]>

Fixes the problem for me:

Tested-by Koen Kooi <[email protected]>

Quoted 39 lines

---

meta/classes/package.bbclass |    2 +-
meta/classes/prserv.bbclass  |    2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

meta/classes/package.bbclass +1 -1

index a1b9482..1e6a872 100644
@@ -330,7 +330,7 @@ def runtime_mapping_rename (varname, d):
 #
 
 python package_get_auto_pr() {
-	if d.getVar('USE_PR_SERV', True):
+	if d.getVar('USE_PR_SERV', True) != "0":
 		auto_pr=prserv_get_pr_auto(d)
 		if auto_pr is None:
 			bb.fatal("Can NOT get auto PR revision from remote PR service")

meta/classes/prserv.bbclass +0 -0

index de46ff6..18b8589 100644
@@ -12,7 +12,7 @@ def prserv_make_conn(d):
    return conn

def prserv_get_pr_auto(d):

meta/classes/prserv.bbclass +1 -1

-    if not d.getVar('USE_PR_SERV', True):
+    if d.getVar('USE_PR_SERV', True) != "0":
        bb.warn("Not using network based PR service")
        return None

Signature · 8 lines

-- 
1.7.4.1


_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Martin Jansa

Tested-by

2011-05-28 08:11 UTC #4 lore raw

Re: [PATCH 2/2] package.bbclass, prserv.bbclass: Compare USE_PR_SERV with "1" or "0"

Quoted 8 lines · Koen Kooi

Op 28 mei 2011, om 04:44 heeft Khem Raj het volgende geschreven:
Quoted 5 lines
Value of USE_PR_SERV is either "1" or "0" looking at
settings in bitbake.conf
USE_PR_SERV = "${@[1,0][(bb.data.getVar('PRSERV_HOST',d,1) is None) or (bb.data.getVar('PRSERV_PORT',d,1) is None)]}" So we compare the strings

Quoted 5 lines

Quoted 1 line
Signed-off-by Khem Raj <[email protected]>
Fixes the problem for me:
Tested-by Koen Kooi <[email protected]>

For me too:

Tested-by Martin Jansa <[email protected]>

Quoted 45 lines

Quoted 39 lines

---

meta/classes/package.bbclass |    2 +-
meta/classes/prserv.bbclass  |    2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

meta/classes/package.bbclass +1 -1

index a1b9482..1e6a872 100644
@@ -330,7 +330,7 @@ def runtime_mapping_rename (varname, d):
 #
 
 python package_get_auto_pr() {
-	if d.getVar('USE_PR_SERV', True):
+	if d.getVar('USE_PR_SERV', True) != "0":
 		auto_pr=prserv_get_pr_auto(d)
 		if auto_pr is None:
 			bb.fatal("Can NOT get auto PR revision from remote PR service")

meta/classes/prserv.bbclass +0 -0

index de46ff6..18b8589 100644
@@ -12,7 +12,7 @@ def prserv_make_conn(d):
    return conn

def prserv_get_pr_auto(d):

meta/classes/prserv.bbclass +1 -1

-    if not d.getVar('USE_PR_SERV', True):
+    if d.getVar('USE_PR_SERV', True) != "0":
        bb.warn("Not using network based PR service")
        return None

Signature · 8 lines

-- 
1.7.4.1


_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Signature · 1 line

Martin 'JaMa' Jansa     jabber: [email protected]

Richard Purdie

Applied

2011-05-29 08:44 UTC #5 lore raw

In reply to Khem Raj

Quoted 4 lines · Khem Raj

The following changes since commit ae1ba18f70c0dac5bed376f6677258c33290ce30:
uclibc: Add disabled COMPILE_IN_THUMB_MODE to uClibc.machine for all ARM configurations (2011-05-27 19:41:33 -0700)

Quoted 8 lines

are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib kraj/misc-fixes
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=kraj/misc-fixes
Khem Raj (2):
uclibc: Add disabled COMPILE_IN_THUMB_MODE to uClibc.machine for all
ARM configurations
package.bbclass,prserv.bbclass: Compare USE_PR_SERV with "1" or "0"

Merged to master, thanks.

Richard