Skip to contentSkip to conversation

8250_pci: Fix build warning

PATCH In review Borislav Petkov 2 participants 3 messages May 30, 2011 – Jun 7, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 8250_pci: Fix build warning

Fix

drivers/tty/serial/8250_pci.c:1457: warning: initialization from incompatible pointer type

by constifying the serial board :).

Cc Antony Pavlov <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
---
 drivers/tty/serial/8250_pci.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/tty/serial/8250_pci.c +2 -2
index 4b4968a..c9c9e6f 100644
@@ -973,8 +973,8 @@ ce4100_serial_setup(struct serial_private *priv,
 
 static int
 pci_omegapci_setup(struct serial_private *priv,
-		      struct pciserial_board *board,
-		      struct uart_port *port, int idx)
+		   const struct pciserial_board *board,
+		   struct uart_port *port, int idx)
 {
 	return setup_port(priv, port, 2, idx * 8, 0);
 }
Signature · 1 line
1.7.5.rc1.16.g9db1
#1 lore raw

Hey Greg,

can you please pick this one up - warning is still present in -rc2 so it looks like no one else fixed it yet :).

Thanks.

Quoted 32 lines · Borislav Petkov

Fix

drivers/tty/serial/8250_pci.c:1457: warning: initialization from incompatible pointer type

by constifying the serial board :).

Cc Antony Pavlov <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
---
 drivers/tty/serial/8250_pci.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/tty/serial/8250_pci.c +2 -2
index 4b4968a..c9c9e6f 100644
@@ -973,8 +973,8 @@ ce4100_serial_setup(struct serial_private *priv,
 
 static int
 pci_omegapci_setup(struct serial_private *priv,
-		      struct pciserial_board *board,
-		      struct uart_port *port, int idx)
+		   const struct pciserial_board *board,
+		   struct uart_port *port, int idx)
 {
 	return setup_port(priv, port, 2, idx * 8, 0);
 }
Signature · 1 line
1.7.5.rc1.16.g9db1
Signature · 2 lines
Regards/Gruss,
    Boris.
#2 lore raw
Quoted 4 lines · Borislav Petkov

Hey Greg,

can you please pick this one up - warning is still present in -rc2 so it looks like no one else fixed it yet :).

Sorry, bad jet-lag at the moment, I have it in my "to-apply" queue, along with about 8 different copies of it from different people, and I'll get to it in a short while.

greg k-h