Skip to contentSkip to conversation

Arch: x86: process: Fix a compilation warning.

PATCH In review Rohit Yadav 6 participants 10 messages May 30, 2011 x86

lore
Share & tools
lore

Rohit Yadav

author
#0 lore raw

PATCH 1/1 Arch: x86: process: Fix a compilation warning.

Remove unknown escape sequence \i in idle_setup.

Signed-off-by Rohit Yadav <[email protected]>
---
 arch/x86/kernel/process.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/process.c +1 -1
index 426a5b6..ed2da29 100644
@@ -642,7 +642,7 @@ static int __init idle_setup(char *str)
 		boot_option_idle_override = IDLE_POLL;
 	} else if (!strcmp(str, "mwait")) {
 		boot_option_idle_override = IDLE_FORCE_MWAIT;
-		WARN_ONCE(1, "\idle=mwait\" will be removed in 2012\"\n");
+		WARN_ONCE(1, "idle=mwait\" will be removed in 2012\"\n");
 	} else if (!strcmp(str, "halt")) {
 		/*
 		 * When the boot option of idle=halt is added, halt is
Signature · 1 line
1.7.4.1
#1 lore raw

arch/x86/kernel/process.c static int __init idle_setup(char *str) · line 645

Quoted 4 lines · Rohit Yadav

Remove unknown escape sequence \i in idle_setup.

arch/x86/kernel/process.c +1 -1
-		WARN_ONCE(1, "\idle=mwait\" will be removed in 2012\"\n");
+		WARN_ONCE(1, "idle=mwait\" will be removed in 2012\"\n");

I think what was *intended* was:

WARN_ONCE(1, "\"idle=mwait\" will be removed in 2012\n");

author
#2 lore raw
Quoted 3 lines

I think what was *intended* was:

WARN_ONCE(1, "\"idle=mwait\" will be removed in 2012\n");

Sure, anyway it was just an exercise, writing and submitting my first Linux kernel patch.
Attached: New patch.

From ab493b2af1d6fe6792b21fe01608ac2277cc79e7 Mon Sep 17 00:00:00 2001
From: Rohit Yadav <[email protected]>
Date: Mon, 30 May 2011 22:16:54 +0530
Subject: [PATCH] Arch: x86: process: Fix a compilation warning.

Remove unknown escape sequence \i in idle_setup.

Signed-off-by Rohit Yadav <[email protected]>
---
 arch/x86/kernel/process.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/process.c +1 -1
index 426a5b6..ed2da29 100644
@@ -642,7 +642,7 @@ static int __init idle_setup(char *str)
 		boot_option_idle_override = IDLE_POLL;
 	} else if (!strcmp(str, "mwait")) {
 		boot_option_idle_override = IDLE_FORCE_MWAIT;
-		WARN_ONCE(1, "\idle=mwait\" will be removed in 2012\"\n");
+		WARN_ONCE(1, "\"idle=mwait\" will be removed in 2012.\n");
 	} else if (!strcmp(str, "halt")) {
 		/*
 		 * When the boot option of idle=halt is added, halt is
Signature · 1 line
1.7.4.1
#3 lore raw
Quoted 1 line · Rohit Yadav

Attached: New patch.

Still needs help:

arch/x86/kernel/process.c static int __init idle_setup(char *str) · line 645

Quoted 4 lines

Remove unknown escape sequence \i in idle_setup.

arch/x86/kernel/process.c +1 -1
-		WARN_ONCE(1, "\idle=mwait\" will be removed in 2012\"\n");
+		WARN_ONCE(1, "\"idle=mwait\" will be removed in 2012.\n");

Changelog should say "Fix mismatched escaped quotes to resolve compiler warning" or similar. You should explain *what* the patch does (fix the quotes) and *why* (because it's broken and won't compile).

#4 lore raw
Quoted 6 lines · On Mon, May 30, 2011 at 02:11:39PM -0400, [email protected] wrote:
Quoted 1 line · Rohit Yadav

Attached: New patch.

Still needs help:

Quoted 8 lines

arch/x86/kernel/process.c static int __init idle_setup(char *str) · line 645

Quoted 4 lines

Remove unknown escape sequence \i in idle_setup.

arch/x86/kernel/process.c +1 -1
-		WARN_ONCE(1, "\idle=mwait\" will be removed in 2012\"\n");
+		WARN_ONCE(1, "\"idle=mwait\" will be removed in 2012.\n");

Changelog should say "Fix mismatched escaped quotes to resolve compiler warning" or similar. You should explain *what* the patch does (fix the quotes) and *why* (because it's broken and won't compile).

Yep, all valid points. Another one would be to search whether this got already fixed before wasting effort:

http://git.kernel.org/tip/598e887d8b01655780c81cc86a9e7820ed091580

But it's not like there's nothing else that needs fixing in Linux. I'd suggest using the new 'make W=' (do 'make help' for more info) build option to build single objects and have gcc do more extensive checks. Some of them actually are valid and need fixing.

Thanks.

Signature · 8 lines
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
#6 lore raw
Quoted 9 lines · On Tue, 31 May 2011 01:22:54 +0530 Rohit Yadav wrote:
Quoted 4 lines

Yep, all valid points. Another one would be to search whether this got already fixed before wasting effort:

http://git.kernel.org/tip/598e887d8b01655780c81cc86a9e7820ed091580

What is the best way to search if something got fixed? There are plenty of repositories at git.kernel.org
I'm using this one:
http://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git

There are > 100 git trees, so just pick a few, like acpi, tip, arm, etc., and check them (I wouldn't expect anyone to check _all_ of them).

Or you could check mailing list archives: see here:
http://marc.info/?l=linux-kernel&m=130675351609350&w=2

It would be good IMO if -tip had a commits mailing list like stable and -mm and mainline do.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

#8 lore raw
In reply to Rohit Yadav
Quoted 9 lines · Rohit Yadav
Quoted 4 lines

Yep, all valid points. Another one would be to search whether this got already fixed before wasting effort:

http://git.kernel.org/tip/598e887d8b01655780c81cc86a9e7820ed091580

What is the best way to search if something got fixed? There are plenty of repositories at git.kernel.org
I'm using this one:
http://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git

Well, you either subscribe to lkml and search in your archives for it or use your favourite search engine - they're usu. indexing lkml pretty fast.

For example, google already indexed your mail I'm replying to and returns it as the first result:

http://www.google.com/search?q=rohit+yadav+if+something+got+fixed

Signature · 8 lines
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
#9 lore raw
In reply to Rohit Yadav
Quoted 10 lines · Rohit Yadav
Quoted 4 lines

Yep, all valid points. Another one would be to search whether this got already fixed before wasting effort:

http://git.kernel.org/tip/598e887d8b01655780c81cc86a9e7820ed091580

What is the best way to search if something got fixed? There are plenty of repositories at git.kernel.org
I'm using this one:
http://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git

Checking linux-next is usually a good idea:
http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=summary

Signature · 3 lines
Jesper Juhl <[email protected]>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.