rtl8192se replacing rtl8192e?
I'm happy to see rtl8192se in Linux 3.0-rc1. I noticed that it claims PCI device ID 10ec:8192, which is already claimed by staging driver rtl8192e. Is it intended to replace that driver, or are there two different devices with that ID which they will distinguish in their probe functions?
If is intended to replace rtl8192e, shouldn't it also claim these device IDs?
/* Corega */
{ PCI_DEVICE(0x07aa, 0x0044) },
{ PCI_DEVICE(0x07aa, 0x0047) },Ben.
Signature · 2 lines
Ben Hutchings Once a job is fouled up, anything done to improve it makes it worse.
Quoted 6 lines · Ben Hutchings
I'm happy to see rtl8192se in Linux 3.0-rc1. I noticed that it claims PCI device ID 10ec:8192, which is already claimed by staging driver rtl8192e. Is it intended to replace that driver, or are there two different devices with that ID which they will distinguish in their probe functions?
Quoted 6 lines
If is intended to replace rtl8192e, shouldn't it also claim these device IDs?
/* Corega */ { PCI_DEVICE(0x07aa, 0x0044) }, { PCI_DEVICE(0x07aa, 0x0047) },
The RTL8192E is a different device than the RTL8192SE, thus rtl8192se will not replace rtl8192e. The way to tell them apart is the PCIe revision id. At present, I don't have a method to use that info to load the correct driver, but I will be working on it. In addition, I need to acquire an RTL8192E.
No, rtl8192se should not claim those Corega devices.
Larry
Quoted 10 lines · Larry Finger
Quoted 9 lines · Ben Hutchings
I'm happy to see rtl8192se in Linux 3.0-rc1. I noticed that it claims PCI device ID 10ec:8192, which is already claimed by staging driver rtl8192e. Is it intended to replace that driver, or are there two different devices with that ID which they will distinguish in their probe functions?
If is intended to replace rtl8192e, shouldn't it also claim these device IDs?
Quoted 8 lines
Quoted 3 lines
/* Corega */ { PCI_DEVICE(0x07aa, 0x0044) }, { PCI_DEVICE(0x07aa, 0x0047) },The RTL8192E is a different device than the RTL8192SE, thus rtl8192se will not replace rtl8192e. The way to tell them apart is the PCIe revision id. At present, I don't have a method to use that info to load the correct driver, but I will be working on it.
It doesn't matter too much if both drivers get loaded, so long as their respective probe() functions fail cleanly and return -ENODEV when called for the wrong device.
Quoted 3 lines
In addition, I need to acquire an RTL8192E.
No, rtl8192se should not claim those Corega devices.
Thanks.
Ben.
Signature · 2 lines
Ben Hutchings Once a job is fouled up, anything done to improve it makes it worse.
Quoted 15 lines · Ben Hutchings
Quoted 14 lines · Larry Finger
Quoted 12 lines · Ben Hutchings
I'm happy to see rtl8192se in Linux 3.0-rc1. I noticed that it claims PCI device ID 10ec:8192, which is already claimed by staging driver rtl8192e. Is it intended to replace that driver, or are there two different devices with that ID which they will distinguish in their probe functions?
If is intended to replace rtl8192e, shouldn't it also claim these device IDs?
/* Corega */ { PCI_DEVICE(0x07aa, 0x0044) }, { PCI_DEVICE(0x07aa, 0x0047) },
Quoted 8 lines
Quoted 4 lines
The RTL8192E is a different device than the RTL8192SE, thus rtl8192se will not replace rtl8192e. The way to tell them apart is the PCIe revision id. At present, I don't have a method to use that info to load the correct driver, but I will be working on it.
It doesn't matter too much if both drivers get loaded, so long as their respective
probe()functions fail cleanly and return-ENODEVwhen called for the wrong device.
Yes, I understand the issue and I have trial patches but no hardware for testing.
Larry