xpad: Add support for two more dance pads and one more guitar
Subsystems (2)
PATCH 1/1 xpad: Add support for two more dance pads and one more guitar
Hi.
Please find attached a patch that adds support for some xbox 360 stuff I bought for my kids.
/Magnus Hörlin
drivers/input/joystick/xpad.c +5 -1
@@ -154,10 +154,13 @@ { 0x0f30, 0x8888, "BigBen XBMiniPad Controller", 0, XTYPE_XBOX }, { 0x102c, 0xff0c, "Joytech Wireless Advanced Controller", 0, XTYPE_XBOX }, { 0x12ab, 0x8809, "Xbox DDR dancepad", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX }, + { 0x12ab, 0x0004, "Honey Bee Xbox360 dancepad", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX360 }, + { 0x0e6f, 0x0105, "HSM3 Xbox360 dancepad", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX360 }, { 0x1430, 0x4748, "RedOctane Guitar Hero X-plorer", 0, XTYPE_XBOX360 }, { 0x1430, 0x8888, "TX6500+ Dance Pad (first generation)", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX }, { 0x146b, 0x0601, "BigBen Interactive XBOX 360 Controller", 0, XTYPE_XBOX360 }, { 0x045e, 0x028e, "Microsoft X-Box 360 pad", 0, XTYPE_XBOX360 }, + { 0x1bad, 0x0002, "Harmonix Rock Band Guitar", 0, XTYPE_XBOX360 }, { 0x1bad, 0x0003, "Harmonix Rock Band Drumkit", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX360 }, { 0x0f0d, 0x0016, "Hori Real Arcade Pro.EX", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOX360 }, { 0x0f0d, 0x000d, "Hori Fighting Stick EX2", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOX360 },
@@ -236,9 +239,10 @@XPAD_XBOX360_VENDOR (0x046d ),/* Logitech X-Box 360 style controllers */ XPAD_XBOX360_VENDOR (0x0738 ),/* Mad Catz X-Box 360 controllers */ XPAD_XBOX360_VENDOR (0x0e6f ),/* 0x0e6f X-Box 360 controllers */ +XPAD_XBOX360_VENDOR (0x12ab ),/* X-Box 360 dance pads */ XPAD_XBOX360_VENDOR (0x1430 ),/* RedOctane X-Box 360 controllers */ XPAD_XBOX360_VENDOR (0x146b ),/* BigBen Interactive Controllers */ -XPAD_XBOX360_VENDOR (0x1bad ),/* Rock Band Drums */ +XPAD_XBOX360_VENDOR (0x1bad ),/* Harminix Rock Band Guitar and Drums */ XPAD_XBOX360_VENDOR(0x0f0d), /* Hori Controllers */ { } };
Dmitry Torokhov
maintainerHi Magnus,
Quoted 5 lines · Magnus Hörlin
Hi.
Please find attached a patch that adds support for some xbox 360 stuff I bought for my kids.
/Magnus Hörlin
Thank you for your patch, but before I can apply it could you please give me your "signed-off-by: " please (see Documentation/SubmittingPatches item #12).
Thanks.
Signature · 5 lines
Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi. Sorry for not having RTFM. Now I have.
Thanks,
/Magnus
Signed-off-by Magnus Hörlin <[email protected]>
drivers/input/joystick/xpad.c renamed from drivers/input/joystick/xpad.c.orig +5 -1
@@ -154,10 +154,13 @@ static const struct xpad_device { { 0x0f30, 0x8888, "BigBen XBMiniPad Controller", 0, XTYPE_XBOX }, { 0x102c, 0xff0c, "Joytech Wireless Advanced Controller", 0, XTYPE_XBOX }, { 0x12ab, 0x8809, "Xbox DDR dancepad", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX }, + { 0x12ab, 0x0004, "Honey Bee Xbox360 dancepad", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX360 }, + { 0x0e6f, 0x0105, "HSM3 Xbox360 dancepad", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX360 }, { 0x1430, 0x4748, "RedOctane Guitar Hero X-plorer", 0, XTYPE_XBOX360 }, { 0x1430, 0x8888, "TX6500+ Dance Pad (first generation)", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX }, { 0x146b, 0x0601, "BigBen Interactive XBOX 360 Controller", 0, XTYPE_XBOX360 }, { 0x045e, 0x028e, "Microsoft X-Box 360 pad", 0, XTYPE_XBOX360 }, + { 0x1bad, 0x0002, "Harmonix Rock Band Guitar", 0, XTYPE_XBOX360 }, { 0x1bad, 0x0003, "Harmonix Rock Band Drumkit", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX360 }, { 0x0f0d, 0x0016, "Hori Real Arcade Pro.EX", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOX360 }, { 0x0f0d, 0x000d, "Hori Fighting Stick EX2", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOX360 },
@@ -236,9 +239,10 @@ static struct usb_device_id xpad_table [XPAD_XBOX360_VENDOR (0x046d ),/* Logitech X-Box 360 style controllers */ XPAD_XBOX360_VENDOR (0x0738 ),/* Mad Catz X-Box 360 controllers */ XPAD_XBOX360_VENDOR (0x0e6f ),/* 0x0e6f X-Box 360 controllers */ +XPAD_XBOX360_VENDOR (0x12ab ),/* X-Box 360 dance pads */ XPAD_XBOX360_VENDOR (0x1430 ),/* RedOctane X-Box 360 controllers */ XPAD_XBOX360_VENDOR (0x146b ),/* BigBen Interactive Controllers */ -XPAD_XBOX360_VENDOR (0x1bad ),/* Rock Band Drums */ +XPAD_XBOX360_VENDOR (0x1bad ),/* Harminix Rock Band Guitar and Drums */ XPAD_XBOX360_VENDOR(0x0f0d), /* Hori Controllers */ { } };
Christoph Fritz
Reviewed-bydrivers/input/joystick/xpad.c static const struct xpad_device { · line 158
Quoted 2 lines · Magnus Hörlin
drivers/input/joystick/xpad.c renamed from drivers/input/joystick/xpad.c.orig +2
-0+ { 0x12ab, 0x0004, "Honey Bee Xbox360 dancepad", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX360 }, + { 0x0e6f, 0x0105, "HSM3 Xbox360 dancepad", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX360 },
Nice to see that MAP_DPAD_TO_BUTTONS is used.
Reviewed-by Christoph Fritz <[email protected]>
Thanks,
-- Christoph
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 8 lines · Christoph Fritz
drivers/input/joystick/xpad.c static const struct xpad_device { · line 158
Quoted 2 lines · Magnus Hörlin
drivers/input/joystick/xpad.c renamed from drivers/input/joystick/xpad.c.orig +2
-0+ { 0x12ab, 0x0004, "Honey Bee Xbox360 dancepad", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX360 }, + { 0x0e6f, 0x0105, "HSM3 Xbox360 dancepad", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX360 },Nice to see that
MAP_DPAD_TO_BUTTONSis used.Reviewed-by Christoph Fritz <[email protected]>
Applied to 'next', thanks Magnus.
Signature · 5 lines
Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Am Dienstag, 31. Mai 2011, 08:36:39 schrieb Magnus Hörlin:
Quoted 6 lines
Hi.
Please find attached a patch that adds support for some xbox 360 stuff I bought for my kids.
/Magnus Hörlin
Thank you for making this patch.
Could you resend it with a "Signed-off-by:" YOUR_MAIL line?
Regards
Oliver
Signature · 10 lines
- - - SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) Maxfeldstraße 5 90409 Nürnberg Germany - - - -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html