Skip to contentSkip to conversation

Print the pixel clock of each mode.

PATCH In review [email protected] 2 participants 2 messages May 30, 2011 – May 31, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Print the pixel clock of each mode.

From: Sun Yi <[email protected]>

---
 tests/testdisplay.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)
tests/testdisplay.c +4 -3
index 41a5753..1efc6e5 100644
@@ -157,7 +157,7 @@ struct connector {
 
 static void dump_mode(drmModeModeInfo *mode)
 {
-	printf("  %s %d %d %d %d %d %d %d %d %d 0x%x 0x%x\n",
+	printf("  %s %d %d %d %d %d %d %d %d %d 0x%x 0x%x %d\n",
 	       mode->name,
 	       mode->vrefresh,
 	       mode->hdisplay,
@@ -169,7 +169,8 @@ static void dump_mode(drmModeModeInfo *mode)
 	       mode->vsync_end,
 	       mode->vtotal,
 	       mode->flags,
-	       mode->type);
+	       mode->type,
+	       mode->clock);
 }
 
 static void dump_connectors(void)
@@ -201,7 +202,7 @@ static void dump_connectors(void)
 
 		printf("  modes:\n");
 		printf("  name refresh (Hz) hdisp hss hse htot vdisp "
-		       "vss vse vtot flags type\n");
+		       "vss vse vtot flags type clock\n");
 		for (j = 0; j < connector->count_modes; j++)
 			dump_mode(&connector->modes[j]);
 
Signature · 1 line
1.7.5.1
Reviewed-by on v1 1/1
#1 lore raw

Dear Sun,

Am Montag, den 30.05.2011, 23:55 +0800 schrieb [email protected]:

Quoted 1 line

From: Sun Yi <[email protected]>

is a Signed-off-by line needed to get your patch accepted? You can add it automatically passing -s to git commit or git format-patch.

Additionally next time you could add an example output before and after your change to the commit message.

Quoted 28 lines
---
 tests/testdisplay.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)
tests/testdisplay.c +3 -2
index 41a5753..1efc6e5 100644
@@ -157,7 +157,7 @@ struct connector {
 
 static void dump_mode(drmModeModeInfo *mode)
 {
-	printf("  %s %d %d %d %d %d %d %d %d %d 0x%x 0x%x\n",
+	printf("  %s %d %d %d %d %d %d %d %d %d 0x%x 0x%x %d\n",
 	       mode->name,
 	       mode->vrefresh,
 	       mode->hdisplay,
@@ -169,7 +169,8 @@ static void dump_mode(drmModeModeInfo *mode)
 	       mode->vsync_end,
 	       mode->vtotal,
 	       mode->flags,
-	       mode->type);
+	       mode->type,
+	       mode->clock);
 }
 
 static void dump_connectors(void)

tests/testdisplay.c static void dump_connectors(void) · line 208

Quoted 8 lines
tests/testdisplay.c +1 -1
@@ -201,7 +202,7 @@ static void dump_connectors(void)
 
 		printf("  modes:\n");
 		printf("  name refresh (Hz) hdisp hss hse htot vdisp "
-		       "vss vse vtot flags type\n");
+		       "vss vse vtot flags type clock\n");
 		for (j = 0; j < connector->count_modes; j++)
 			dump_mode(&connector->modes[j]);
 

Thanks,

Paul

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx