Skip to contentSkip to conversation

tm6000: Cleaned up code style in tm6000-dbv.c

PATCH New Curtis McEnroe 1 participant 4 messages Jun 3, 2011 Staging

lore
Share & tools
lore

Curtis McEnroe

author
#0 lore raw

PATCH 2/5 tm6000: Cleaned up code style in tm6000-dbv.c

Replaced usage of __FUNCTION__ with __func__

Signed-off-by Curtis McEnroe <[email protected]>
---
 drivers/staging/tm6000/tm6000-dvb.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)
drivers/staging/tm6000/tm6000-dvb.c +5 -5
index ff04c89..0e0dfce 100644
@@ -98,7 +98,7 @@ static void tm6000_urb_received(struct urb *urb)
 	if (dev->dvb->streams > 0) {
 		ret = usb_submit_urb(urb, GFP_ATOMIC);
 		if (ret < 0) {
-			printk(KERN_ERR "tm6000:  error %s\n", __FUNCTION__);
+			printk(KERN_ERR "tm6000:  error %s\n", __func__);
 			kfree(urb->transfer_buffer);
 			usb_free_urb(urb);
 		}

@@ -111,7 +111,7 @@ int tm6000_start_stream(struct tm6000_core *dev)
 	unsigned int pipe, size;
 	struct tm6000_dvb *dvb = dev->dvb;
 
-	printk(KERN_INFO "tm6000: got start stream request %s\n", __FUNCTION__);
+	printk(KERN_INFO "tm6000: got start stream request %s\n", __func__);
 
 	if (dev->mode != TM6000_MODE_DIGITAL) {
 		tm6000_init_digital_mode(dev);

@@ -145,7 +145,7 @@ int tm6000_start_stream(struct tm6000_core *dev)
 	ret = usb_clear_halt(dev->udev, pipe);
 	if (ret < 0) {
 		printk(KERN_ERR "tm6000: error %i in %s during pipe reset\n",
-							ret, __FUNCTION__);
+							ret, __func__);
 		return ret;
 	} else
 		printk(KERN_ERR "tm6000: pipe resetted\n");

@@ -185,7 +185,7 @@ int tm6000_start_feed(struct dvb_demux_feed *feed)
 	struct dvb_demux *demux = feed->demux;
 	struct tm6000_core *dev = demux->priv;
 	struct tm6000_dvb *dvb = dev->dvb;
-	printk(KERN_INFO "tm6000: got start feed request %s\n", __FUNCTION__);
+	printk(KERN_INFO "tm6000: got start feed request %s\n", __func__);
 
 	mutex_lock(&dvb->mutex);
 	if (dvb->streams == 0) {

@@ -205,7 +205,7 @@ int tm6000_stop_feed(struct dvb_demux_feed *feed)
 	struct tm6000_core *dev = demux->priv;
 	struct tm6000_dvb *dvb = dev->dvb;
 
-	printk(KERN_INFO "tm6000: got stop feed request %s\n", __FUNCTION__);
+	printk(KERN_INFO "tm6000: got stop feed request %s\n", __func__);
 
 	mutex_lock(&dvb->mutex);
Signature · 1 line
1.7.5.2
author
#1 lore raw

PATCH 3/5 tm6000: Cleaned up code style in tm6000-i2c.c

Replaced __FUNCTION__ with __func__

Signed-off-by Curtis McEnroe <[email protected]>
---
 drivers/staging/tm6000/tm6000-i2c.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/tm6000/tm6000-i2c.c +1 -1
index 8828c12..5a651ea 100644
@@ -40,7 +40,7 @@ MODULE_PARM_DESC(i2c_debug, "enable debug messages [i2c]");
 
 #define i2c_dprintk(lvl, fmt, args...) if (i2c_debug >= lvl) do { \
 			printk(KERN_DEBUG "%s at %s: " fmt, \
-			dev->name, __FUNCTION__ , ##args); } while (0)
+			dev->name, __func__, ##args); } while (0)
 
 static int tm6000_i2c_send_regs(struct tm6000_core *dev, unsigned char addr,
 				__u8 reg, char *buf, int len)
Signature · 1 line
1.7.5.2
author
#2 lore raw

PATCH 4/5 tm6000: Clean up code style in tm6000-input.c

In reply to Curtis McEnroe

Removed unnecessary braces.

Signed-off-by Curtis McEnroe <[email protected]>
---
 drivers/staging/tm6000/tm6000-input.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
drivers/staging/tm6000/tm6000-input.c +1 -2
index dae2f1f..70a2c5f 100644
@@ -449,9 +449,8 @@ int tm6000_ir_fini(struct tm6000_core *dev)
 
 	rc_unregister_device(ir->rc);
 
-	if (ir->int_urb) {
+	if (ir->int_urb)
 		tm6000_ir_int_stop(dev);
-	}
 
 	kfree(ir);
 	dev->ir = NULL;
Signature · 1 line
1.7.5.2
author
#3 lore raw

PATCH 5/5 tm6000: Cleaned up code style in tm6000-alsa.c

In reply to Curtis McEnroe

Fixed all errors but one (possibly a mistake by the checker) reported by the checker.

Signed-off-by Curtis McEnroe <[email protected]>
---
 drivers/staging/tm6000/tm6000-alsa.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
drivers/staging/tm6000/tm6000-alsa.c +4 -4
index 2b96047..ddfd7c3 100644
@@ -18,7 +18,7 @@
 #include <linux/slab.h>
 #include <linux/vmalloc.h>
 
-#include <asm/delay.h>
+#include <linux/delay.h>
 #include <sound/core.h>
 #include <sound/pcm.h>
 #include <sound/pcm_params.h>

@@ -255,7 +255,7 @@ static int tm6000_fillbuf(struct tm6000_core *core, char *buf, int size)
 			length * stride);
 
 #ifndef NO_PCM_LOCK
-       snd_pcm_stream_lock(substream);
+	snd_pcm_stream_lock(substream);
 #endif
 
 	chip->buf_pos += length;

@@ -269,7 +269,7 @@ static int tm6000_fillbuf(struct tm6000_core *core, char *buf, int size)
 	}
 
 #ifndef NO_PCM_LOCK
-       snd_pcm_stream_unlock(substream);
+	snd_pcm_stream_unlock(substream);
 #endif
 
 	if (period_elapsed)

@@ -461,7 +461,7 @@ int tm6000_audio_init(struct tm6000_core *dev)
 	if (rc < 0)
 		goto error_chip;
 
-	dprintk(1,"Registered audio driver for %s\n", card->longname);
+	dprintk(1, "Registered audio driver for %s\n", card->longname);
 
 	return 0;
Signature · 1 line
1.7.5.2