mtd: pxa3xx_nand: remove unused variable 'mtd'
Subsystems (2)
PATCH 1/1 mtd: pxa3xx_nand: remove unused variable 'mtd'
Remove unused variable 'mtd' to eliminate below warning.
CC drivers/mtd/nand/pxa3xx_nand.odrivers/mtd/nand/pxa3xx_nand.c: In function 'pxa3xx_nand_suspend':drivers/mtd/nand/pxa3xx_nand.c:1167: warning: unused variable 'mtd' drivers/mtd/nand/pxa3xx_nand.c: In function 'pxa3xx_nand_resume':drivers/mtd/nand/pxa3xx_nand.c:1180: warning: unused variable 'mtd'
--- drivers/mtd/nand/pxa3xx_nand.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/mtd/nand/pxa3xx_nand.c +0 -2
@@ -1164,7 +1164,6 @@ static int pxa3xx_nand_probe(struct platform_device *pdev)static int pxa3xx_nand_suspend (struct platform_device *pdev,pm_message_t state) {struct pxa3xx_nand_info *info =platform_get_drvdata (pdev); -struct mtd_info *mtd = info->mtd;if (info->state) {dev_err (&pdev->dev,"driver busy, state = %d\n" , info->state);
@@ -1177,7 +1176,6 @@ static int pxa3xx_nand_suspend(struct platform_device *pdev, pm_message_t state)static int pxa3xx_nand_resume (struct platform_device *pdev) {struct pxa3xx_nand_info *info =platform_get_drvdata (pdev); -struct mtd_info *mtd = info->mtd;nand_writel (info,NDTR0CS0 , info->ndtr0cs0);nand_writel (info,NDTR1CS0 , info->ndtr1cs0);
Signature · 1 line
1.7.4.1
Hi Alex,
Quoted 7 lines · Axel Lin
Remove unused variable 'mtd' to eliminate below warning.
CC drivers/mtd/nand/pxa3xx_nand.o
drivers/mtd/nand/pxa3xx_nand.c: In function 'pxa3xx_nand_suspend':drivers/mtd/nand/pxa3xx_nand.c:1167: warning: unused variable 'mtd'drivers/mtd/nand/pxa3xx_nand.c: In function 'pxa3xx_nand_resume':drivers/mtd/nand/pxa3xx_nand.c:1180: warning: unused variable 'mtd'
Do you actually use this driver? I'm asking because there's some sort of nasty regression in the changes between 2.6.38 and 2.6.39 which makes the driver fail to work on my PXA300 based board. Lei and me tried to nail these issues down, but we didn't succeed yet.
Daniel
Quoted 4 lines
Do you actually use this driver? I'm asking because there's some sort of nasty regression in the changes between 2.6.38 and 2.6.39 which makes the driver fail to work on my PXA300 based board. Lei and me tried to nail these issues down, but we didn't succeed yet.
hi Daniel,
I no longer have the device handy.
Last time I use this driver on a pxa310 device is running on 2.6.37 kernel.
Regards,
Axel
(cc Lei Wen)
Quoted 9 lines · Axel Lin
Remove unused variable 'mtd' to eliminate below warning.
CC drivers/mtd/nand/pxa3xx_nand.o
drivers/mtd/nand/pxa3xx_nand.c: In function 'pxa3xx_nand_suspend':drivers/mtd/nand/pxa3xx_nand.c:1167: warning: unused variable 'mtd'drivers/mtd/nand/pxa3xx_nand.c: In function 'pxa3xx_nand_resume':drivers/mtd/nand/pxa3xx_nand.c:1180: warning: unused variable 'mtd'Signed-off-by Axel Lin <[email protected]>
Lei, I had the same patch queued up on my side and dropped it now. Can you apply this one?
Thanks,
Daniel
Quoted 35 lines
---
drivers/mtd/nand/pxa3xx_nand.c | 2 --1 files changed, 0 insertions(+), 2 deletions(-)drivers/mtd/nand/pxa3xx_nand.c +0
-3@@ -1164,7 +1164,6 @@ static int pxa3xx_nand_probe(struct platform_device *pdev) static int pxa3xx_nand_suspend(struct platform_device *pdev, pm_message_t state) { struct pxa3xx_nand_info *info = platform_get_drvdata(pdev); - struct mtd_info *mtd = info->mtd; if (info->state) { dev_err(&pdev->dev, "driver busy, state = %d\n", info->state);@@ -1177,7 +1176,6 @@ static int pxa3xx_nand_suspend(struct platform_device *pdev, pm_message_t state) static int pxa3xx_nand_resume(struct platform_device *pdev) { struct pxa3xx_nand_info *info = platform_get_drvdata(pdev); - struct mtd_info *mtd = info->mtd; nand_writel(info, NDTR0CS0, info->ndtr0cs0); nand_writel(info, NDTR1CS0, info->ndtr1cs0); --1.7.4.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Artem Bityutskiy
AppliedQuoted 9 lines · Axel Lin
Remove unused variable 'mtd' to eliminate below warning.
CC
drivers/mtd/nand/pxa3xx_nand.odrivers/mtd/nand/pxa3xx_nand.c: In function 'pxa3xx_nand_suspend':drivers/mtd/nand/pxa3xx_nand.c:1167: warning: unused variable 'mtd'drivers/mtd/nand/pxa3xx_nand.c: In function 'pxa3xx_nand_resume':drivers/mtd/nand/pxa3xx_nand.c:1180: warning: unused variable 'mtd'Signed-off-by Axel Lin <[email protected]>
Pushed to l2-mtd-2.6.git, thanks!
Signature · 2 lines
Best Regards, Artem Bityutskiy (Артём Битюцкий)