Skip to contentSkip to conversation

matrix_gui: Update SRCREV

PATCH In review Jeff Lance 3 participants 5 messages Jun 6, 2011 – Jun 7, 2011

lore
Share & tools
lore

Jeff Lance

author
#0 lore raw

PATCH 1/1 matrix_gui: Update SRCREV

* Adding arm only multimedia apps to am37x
* Wifi updates to am37x, am180x
* Adding to am180x, am37x, am35x, beagle:
* Oprofile example

Signed-off-by Jeff Lance <[email protected]>

---
 recipes/ti/matrix-gui-common_1.4.bb |    4 ++--
 recipes/ti/matrix-gui-e_1.3.bb      |    4 ++--
 recipes/ti/matrix-gui_1.3.bb        |    4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)
recipes/ti/matrix-gui-common_1.4.bb +2 -2
index 6f7376d..0b4b25b 100644
@@ -4,5 +4,5 @@ require matrix-gui-common.inc
 # prebuilt version in the repository.
 RRECOMMENDS_${PN} = "am-sysinfo"
 
-SRCREV = "249"
-PR = "${INC_PR}.10"
+SRCREV = "257"
+PR = "${INC_PR}.11"
recipes/ti/matrix-gui-e_1.3.bb +2 -2
index 8f2df1c..a6eb17f 100644
@@ -1,5 +1,5 @@
 require matrix-gui-e.inc
 
-SRCREV = "249"
-PR = "${INC_PR}.9"
+SRCREV = "257"
+PR = "${INC_PR}.10"
 
recipes/ti/matrix-gui_1.3.bb +2 -2
index f7e56a3..51678df 100644
@@ -1,4 +1,4 @@
 require matrix-gui.inc
 
-SRCREV = "249"
-PR = "${INC_PR}.5"
+SRCREV = "257"
+PR = "${INC_PR}.6"
Signature · 1 line
1.7.0.4
Reviewed-by on v1 1/1
#1 lore raw

Dear Jeff,

Am Montag, den 06.06.2011, 09:15 -0500 schrieb Jeff Lance:

you can make the commit subject more informational by writing the following.

matrix_gui: Update SRCREV to revision 257

Quoted 4 lines

* Adding arm only multimedia apps to am37x
* Wifi updates to am37x, am180x
* Adding to am180x, am37x, am35x, beagle:
* Oprofile example

do you copy those lines from git log? git log adds indentation in front of the commit message. Please use git format-patch.

Quoted 1 line

Signed-off-by Jeff Lance <[email protected]>

A colon »:« is missing and it is formatting strangely. Please use the option -s.

As I wrote often enough please make sure the From and Signed-off-by field match.

Quoted 11 lines
---
 recipes/ti/matrix-gui-common_1.4.bb |    4 ++--
 recipes/ti/matrix-gui-e_1.3.bb      |    4 ++--
 recipes/ti/matrix-gui_1.3.bb        |    4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)
recipes/ti/matrix-gui-common_1.4.bb +0 -0
index 6f7376d..0b4b25b 100644

recipes/ti/matrix-gui-common_1.4.bb require matrix-gui-common.inc · line 7

Quoted 6 lines
recipes/ti/matrix-gui-common_1.4.bb +1 -2
@@ -4,5 +4,5 @@ require matrix-gui-common.inc
 # prebuilt version in the repository.
 RRECOMMENDS_${PN} = "am-sysinfo"
 
-SRCREV = "249"
-PR = "${INC_PR}.10"
+SRCREV = "257"

Would it be beneficial to add SRCREV to matrix-gui.inc and require that everywhere?

Quoted 18 lines
recipes/ti/matrix-gui-common_1.4.bb +1 -0
+PR = "${INC_PR}.11"
recipes/ti/matrix-gui-e_1.3.bb +2 -2
index 8f2df1c..a6eb17f 100644
@@ -1,5 +1,5 @@
 require matrix-gui-e.inc
 
-SRCREV = "249"
-PR = "${INC_PR}.9"
+SRCREV = "257"
+PR = "${INC_PR}.10"
 
recipes/ti/matrix-gui_1.3.bb +0 -0
index f7e56a3..51678df 100644

recipes/ti/matrix-gui_1.3.bb line 4

Quoted 6 lines
recipes/ti/matrix-gui_1.3.bb +2 -2
@@ -1,4 +1,4 @@
 require matrix-gui.inc
 
-SRCREV = "249"
-PR = "${INC_PR}.5"
+SRCREV = "257"
+PR = "${INC_PR}.6"

I did not build or runtest though.

Thanks,

Paul

author
#2 lore raw

Paul,

Thanks for the help. I will use -s now. Previously I was hand typing in the commit message.
I will resubmit a corrected version of this patch.

Jeff Lance

Quoted 88 lines · Paul Menzel

Dear Jeff,

Am Montag, den 06.06.2011, 09:15 -0500 schrieb Jeff Lance:

you can make the commit subject more informational by writing the following.

matrix_gui: Update SRCREV to revision 257

Quoted 4 lines

* Adding arm only multimedia apps to am37x
* Wifi updates to am37x, am180x
* Adding to am180x, am37x, am35x, beagle:
* Oprofile example

do you copy those lines from git log? git log adds indentation in front of the commit message. Please use git format-patch.

Quoted 1 line

Signed-off-by Jeff Lance <[email protected]>

A colon »:« is missing and it is formatting strangely. Please use the option -s.

As I wrote often enough please make sure the From and Signed-off-by field match.

recipes/ti/

Quoted 7 lines
---
 recipes/ti/matrix-gui-common_1.4.bb |    4 ++--
 recipes/ti/matrix-gui-e_1.3.bb      |    4 ++--
 recipes/ti/matrix-gui_1.3.bb        |    4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)
recipes/ti/ renamed from recipes/ti/matrix-gui-common_1.4.bb +0 -0

matrix-gui-common_1.4.bb

recipes/ti/matrix-gui-common_1.4.bb require matrix-gui-common.inc · line 7

Quoted 10 lines

index 6f7376d..0b4b25b 100644

recipes/ti/matrix-gui-common_1.4.bb +1 -2
@@ -4,5 +4,5 @@ require matrix-gui-common.inc
 # prebuilt version in the repository.
 RRECOMMENDS_${PN} = "am-sysinfo"
 
-SRCREV = "249"
-PR = "${INC_PR}.10"
+SRCREV = "257"

Would it be beneficial to add SRCREV to matrix-gui.inc and require that everywhere?

recipes/ti/

Quoted 2 lines
recipes/ti/matrix-gui-common_1.4.bb +1 -0
+PR = "${INC_PR}.11"
recipes/ti/ renamed from recipes/ti/matrix-gui-e_1.3.bb +0 -0

matrix-gui-e_1.3.bb

Quoted 16 lines

index 8f2df1c..a6eb17f 100644

recipes/ti/matrix-gui-e_1.3.bb +2 -2
@@ -1,5 +1,5 @@
 require matrix-gui-e.inc
 
-SRCREV = "249"
-PR = "${INC_PR}.9"
+SRCREV = "257"
+PR = "${INC_PR}.10"
 
recipes/ti/matrix-gui_1.3.bb +0 -0
index f7e56a3..51678df 100644

recipes/ti/matrix-gui_1.3.bb line 4

Quoted 6 lines
recipes/ti/matrix-gui_1.3.bb +2 -2
@@ -1,4 +1,4 @@
 require matrix-gui.inc
 
-SRCREV = "249"
-PR = "${INC_PR}.5"
+SRCREV = "257"
+PR = "${INC_PR}.6"

I did not build or runtest though.

Thanks,

Paul

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

#3 lore raw
Quoted 5 lines · Jeff Lance

Paul,

Thanks for the help. I will use -s now. Previously I was hand typing in the commit message.
I will resubmit a corrected version of this patch.

I agree with all Paul's comments, except the one requiring From and SoB fields to match - in some cases it's not possible, especially when people try to avoid inline patches being mangled by corporate mail servers...

Signature · 1 line
Denys
Quoted 95 lines
Quoted 78 lines · Paul Menzel

Dear Jeff,

Am Montag, den 06.06.2011, 09:15 -0500 schrieb Jeff Lance:

you can make the commit subject more informational by writing the following.

matrix_gui: Update SRCREV to revision 257

Quoted 4 lines

* Adding arm only multimedia apps to am37x
* Wifi updates to am37x, am180x
* Adding to am180x, am37x, am35x, beagle:
* Oprofile example

do you copy those lines from git log? git log adds indentation in front of the commit message. Please use git format-patch.

Quoted 1 line

Signed-off-by Jeff Lance <[email protected]>

A colon ?:? is missing and it is formatting strangely. Please use the option -s.

As I wrote often enough please make sure the From and Signed-off-by field match.

recipes/ti/

Quoted 7 lines
---
 recipes/ti/matrix-gui-common_1.4.bb |    4 ++--
 recipes/ti/matrix-gui-e_1.3.bb      |    4 ++--
 recipes/ti/matrix-gui_1.3.bb        |    4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)
recipes/ti/ renamed from recipes/ti/matrix-gui-common_1.4.bb +0 -0

matrix-gui-common_1.4.bb

recipes/ti/matrix-gui-common_1.4.bb require matrix-gui-common.inc · line 7

Quoted 10 lines

index 6f7376d..0b4b25b 100644

recipes/ti/matrix-gui-common_1.4.bb +1 -2
@@ -4,5 +4,5 @@ require matrix-gui-common.inc
 # prebuilt version in the repository.
 RRECOMMENDS_${PN} = "am-sysinfo"
 
-SRCREV = "249"
-PR = "${INC_PR}.10"
+SRCREV = "257"

Would it be beneficial to add SRCREV to matrix-gui.inc and require that everywhere?

recipes/ti/

Quoted 2 lines
recipes/ti/matrix-gui-common_1.4.bb +1 -0
+PR = "${INC_PR}.11"
recipes/ti/ renamed from recipes/ti/matrix-gui-e_1.3.bb +0 -0

matrix-gui-e_1.3.bb

Quoted 16 lines

index 8f2df1c..a6eb17f 100644

recipes/ti/matrix-gui-e_1.3.bb +2 -2
@@ -1,5 +1,5 @@
 require matrix-gui-e.inc
 
-SRCREV = "249"
-PR = "${INC_PR}.9"
+SRCREV = "257"
+PR = "${INC_PR}.10"
 
recipes/ti/matrix-gui_1.3.bb +0 -0
index f7e56a3..51678df 100644

recipes/ti/matrix-gui_1.3.bb line 4

Quoted 6 lines
recipes/ti/matrix-gui_1.3.bb +2 -2
@@ -1,4 +1,4 @@
 require matrix-gui.inc
 
-SRCREV = "249"
-PR = "${INC_PR}.5"
+SRCREV = "257"
+PR = "${INC_PR}.6"

I did not build or runtest though.

Quoted 10 lines

Thanks,

Paul

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

#4 lore raw

different addresses in author/From and Signed-off-by (was: [PATCH 1/1] matrix_gui: Update SRCREV)

Am Dienstag, den 07.06.2011, 14:44 -0400 schrieb Denys Dmytriyenko:

[…]

Quoted 3 lines

I agree with all Paul's comments, except the one requiring From and SoB fields to match - in some cases it's not possible, especially when people try to avoid inline patches being mangled by corporate mail servers...

Easy enough. Just add

From: Jeff Lance <[email protected]>

to the beginning of the message and git am will take this for the author field.

        $ git help am
        […]
                "From: " and "Subject: " lines starting the body override the
               respective commit author name and title values taken from the headers.
        […]

I do not know where this can be configured, but it should be.

Thanks,

Paul