Skip to contentSkip to conversation

UCM: get: Implement 'exact' value retrieval

PATCH In review Stephen Warren 3 participants 6 messages Jun 6, 2011 – Jun 8, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 UCM: get: Implement 'exact' value retrieval

[=]<NAME>[/[<modifier>|</device>][/<verb>]]
- value identifier <NAME>
- Search starts at given modifier or device if any, else at a verb
- Search starts at given verb if any,
else current verb
- Searches modifier/device, then verb, then defaults
- Specify a leading "=" to search only the exact device/modifier/verb specified, and not search through each object in turn.
- Examples:
"PlaybackPCM/Play Music" "CapturePCM/SPDIF"
From ValueDefaults only:

    "=Variable"
  From current active verb:
    "=Variable//"
  From verb "Verb":
    "=Variable//Verb"

From "Modifier" in current active verb:
"=Variable/Modifier/"
From "Modifier" in "Verb":
"=Variable/Modifier/Verb"

---
 include/use-case.h |   30 +++++++++++---
 src/ucm/main.c     |  110 +++++++++++++++++++++++++++++++++++++--------------
 2 files changed, 104 insertions(+), 36 deletions(-)
include/use-case.h +24 -6
index b346877..c37c842 100644
@@ -230,12 +230,30 @@ int snd_use_case_get_list(snd_use_case_mgr_t *uc_mgr,
  *   NULL 		- return current card
  *   _verb		- return current verb
  *
- *   <NAME>[/<modifier>|</device>]
- *			- value identifier <NAME> for
- *			  given modifier or device
- * 			- Examples: "PlaybackPCM/Play Music",
- *				    "CapturePCM/SPDIF"
- * 
+ *   [=]<NAME>[/[<modifier>|</device>][/<verb>]]
+ *                      - value identifier <NAME>
+ *                      - Search starts at given modifier or device if any,
+ *                          else at a verb
+ *                      - Search starts at given verb if any,
+ *                          else current verb
+ *                      - Searches modifier/device, then verb, then defaults
+ *                      - Specify a leading "=" to search only the exact
+ *                        device/modifier/verb specified, and not search
+ *                        through each object in turn.
+ *                      - Examples:
+ *                          "PlaybackPCM/Play Music"
+ *                          "CapturePCM/SPDIF"
+ *                        From ValueDefaults only:
+ *                          "=Variable"
+ *                        From current active verb:
+ *                          "=Variable//"
+ *                        From verb "Verb":
+ *                          "=Variable//Verb"
+ *                        From "Modifier" in current active verb:
+ *                          "=Variable/Modifier/"
+ *                        From "Modifier" in "Verb":
+ *                          "=Variable/Modifier/Verb"
+ *
  * Recommended names for values:
  *   TQ			- Tone Quality
  *   PlaybackPCM	- full PCM playback device name
src/ucm/main.c +80 -30

141 lines not on this page · raw message

Signature · 1 line
1.7.0.4
Acked-by on v1 1/1
#1 lore raw
Quoted 19 lines · Stephen Warren

[=]<NAME>[/[<modifier>|</device>][/<verb>]]
- value identifier <NAME>
- Search starts at given modifier or device if any, else at a verb
- Search starts at given verb if any,
else current verb
- Searches modifier/device, then verb, then defaults
- Specify a leading "=" to search only the exact device/modifier/verb specified, and not search through each object in turn.
- Examples:
"PlaybackPCM/Play Music" "CapturePCM/SPDIF"
From ValueDefaults only:

    "=Variable"
  From current active verb:
    "=Variable//"
  From verb "Verb":
    "=Variable//Verb"
Quoted 8 lines

From "Modifier" in current active verb:
"=Variable/Modifier/"
From "Modifier" in "Verb":
"=Variable/Modifier/Verb"

---

#2 lore raw
In reply to Stephen Warren

At Mon, 6 Jun 2011 14:16:57 -0600,

Quoted 20 lines · Stephen Warren

[=]<NAME>[/[<modifier>|</device>][/<verb>]]
- value identifier <NAME>
- Search starts at given modifier or device if any, else at a verb
- Search starts at given verb if any,
else current verb
- Searches modifier/device, then verb, then defaults
- Specify a leading "=" to search only the exact device/modifier/verb specified, and not search through each object in turn.
- Examples:
"PlaybackPCM/Play Music" "CapturePCM/SPDIF"
From ValueDefaults only:

    "=Variable"
  From current active verb:
    "=Variable//"
  From verb "Verb":
    "=Variable//Verb"
Quoted 6 lines

From "Modifier" in current active verb:
"=Variable/Modifier/"
From "Modifier" in "Verb":
"=Variable/Modifier/Verb"

I couldn't apply it cleanly. Any pending patch?

thanks,

Takashi

#3 lore raw

Takashi Iwai wrote at Wednesday, June 08, 2011 12:08 AM:

Quoted 26 lines
Quoted 25 lines · Stephen Warren

[=]<NAME>[/[<modifier>|</device>][/<verb>]]
- value identifier <NAME>
- Search starts at given modifier or device if any, else at a verb
- Search starts at given verb if any,
else current verb
- Searches modifier/device, then verb, then defaults
- Specify a leading "=" to search only the exact device/modifier/verb specified, and not search through each object in turn.
- Examples:
"PlaybackPCM/Play Music" "CapturePCM/SPDIF"
From ValueDefaults only:

    "=Variable"
  From current active verb:
    "=Variable//"
  From verb "Verb":
    "=Variable//Verb"

From "Modifier" in current active verb:
"=Variable/Modifier/"
From "Modifier" in "Verb":
"=Variable/Modifier/Verb"

Quoted 3 lines
Quoted 1 line

I couldn't apply it cleanly. Any pending patch?

Yes, the 5-series patchset I posted last Friday starting with:
[PATCH 1/5] UCM: Deprecate index on Section{Device,Modifier}

(since they were ACK'd by Liam before I posted this patch, I assumed they'd be applied before you attempted to apply this, so I didn't mention the dependency in the patch description.)

Thanks.

Signature · 1 line
nvpublic
#4 lore raw

At Wed, 8 Jun 2011 08:43:44 -0700,

Quoted 30 lines · Stephen Warren

Takashi Iwai wrote at Wednesday, June 08, 2011 12:08 AM:

Quoted 28 lines
Quoted 26 lines · Stephen Warren

[=]<NAME>[/[<modifier>|</device>][/<verb>]]
- value identifier <NAME>
- Search starts at given modifier or device if any, else at a verb
- Search starts at given verb if any,
else current verb
- Searches modifier/device, then verb, then defaults
- Specify a leading "=" to search only the exact device/modifier/verb specified, and not search through each object in turn.
- Examples:
"PlaybackPCM/Play Music" "CapturePCM/SPDIF"
From ValueDefaults only:

    "=Variable"
  From current active verb:
    "=Variable//"
  From verb "Verb":
    "=Variable//Verb"

From "Modifier" in current active verb:
"=Variable/Modifier/"
From "Modifier" in "Verb":
"=Variable/Modifier/Verb"

Quoted 8 lines
Quoted 1 line

I couldn't apply it cleanly. Any pending patch?

Yes, the 5-series patchset I posted last Friday starting with:
[PATCH 1/5] UCM: Deprecate index on Section{Device,Modifier}

(since they were ACK'd by Liam before I posted this patch, I assumed they'd be applied before you attempted to apply this, so I didn't mention the dependency in the patch description.)

I've overlooked these, obviously, as it was just after my vacation. I'll commit all after review.

thanks,

Takashi

#5 lore raw

At Wed, 08 Jun 2011 18:00:46 +0200,

Quoted 38 lines · Takashi Iwai

At Wed, 8 Jun 2011 08:43:44 -0700,

Quoted 35 lines · Stephen Warren

Takashi Iwai wrote at Wednesday, June 08, 2011 12:08 AM:

Quoted 26 lines
Quoted 25 lines · Stephen Warren

[=]<NAME>[/[<modifier>|</device>][/<verb>]]
- value identifier <NAME>
- Search starts at given modifier or device if any, else at a verb
- Search starts at given verb if any,
else current verb
- Searches modifier/device, then verb, then defaults
- Specify a leading "=" to search only the exact device/modifier/verb specified, and not search through each object in turn.
- Examples:
"PlaybackPCM/Play Music" "CapturePCM/SPDIF"
From ValueDefaults only:

    "=Variable"
  From current active verb:
    "=Variable//"
  From verb "Verb":
    "=Variable//Verb"

From "Modifier" in current active verb:
"=Variable/Modifier/"
From "Modifier" in "Verb":
"=Variable/Modifier/Verb"

Quoted 3 lines
Quoted 1 line

I couldn't apply it cleanly. Any pending patch?

Yes, the 5-series patchset I posted last Friday starting with:
[PATCH 1/5] UCM: Deprecate index on Section{Device,Modifier}

Quoted 6 lines
Quoted 3 lines

(since they were ACK'd by Liam before I posted this patch, I assumed they'd be applied before you attempted to apply this, so I didn't mention the dependency in the patch description.)

I've overlooked these, obviously, as it was just after my vacation. I'll commit all after review.

Done.

Takashi