Skip to contentSkip to conversation

enjoy: add alsa and autodetect gst modules. Without autodetect, enjoy segfaults. Without alsa, no sound is played

PATCH In review Pau Espin Pedrol 3 participants 10 messages Jun 13, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 enjoy: add alsa and autodetect gst modules. Without autodetect, enjoy segfaults. Without alsa, no sound is played

---
 recipes/e17/enjoy_svn.bb |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
recipes/e17/enjoy_svn.bb +2 -2
index eab81b4..d709eb7 100644
@@ -3,7 +3,7 @@ LICENSE = "LGPLv3"
 DEPENDS = "evas ecore edje elementary emotion lightmediascanner"
 SRCREV = "${EFL_SRCREV}"
 PV = "0.0+svnr${SRCPV}"
-PR = "r4"
+PR = "r5"
 
 DEPENDS += "gst-plugins-good ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'gst-plugins-ugly', d)}"
 
@@ -13,7 +13,7 @@ DEPENDS += "gst-plugins-good ${@base_conditional('ENTERPRISE_DISTRO', '1', '', '
 #4th needed for flac playback
 #5th needed binary to create db
 RDEPENDS += "\
-	gst-plugin-typefindfunctions gst-plugin-playbin gst-plugin-volume gst-plugin-decodebin2  \
+	gst-plugin-typefindfunctions gst-plugin-playbin gst-plugin-volume gst-plugin-decodebin2  gst-plugin-alsa gst-plugin-autodetect \
 	${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'gst-plugin-mad gst-plugin-id3demux', d)} \
 	gst-plugin-ogg gst-plugin-ivorbisdec \
 	gst-plugin-flac \
Signature · 1 line
1.7.5.rc3
#1 lore raw

Dear Pau,

thank you for your contribution.

Am Montag, den 13.06.2011, 19:52 +0200 schrieb Pau Espin Pedrol:

The commit summary is a bit long. Please add a blank line in between and add your Signed-off-by line according to the commit policy [1].

Please also paste the important parts of the segfault into the commit message.

What system did you use for testing?

Quoted 18 lines
---
 recipes/e17/enjoy_svn.bb |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
recipes/e17/enjoy_svn.bb +1 -1
index eab81b4..d709eb7 100644
@@ -3,7 +3,7 @@ LICENSE = "LGPLv3"
 DEPENDS = "evas ecore edje elementary emotion lightmediascanner"
 SRCREV = "${EFL_SRCREV}"
 PV = "0.0+svnr${SRCPV}"
-PR = "r4"
+PR = "r5"
 
 DEPENDS += "gst-plugins-good ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'gst-plugins-ugly', d)}"
 

recipes/e17/enjoy_svn.bb DEPENDS += "gst-plugins-good ${@base_conditional('ENTERPRISE_DISTRO', '1', '', ' · line 19

Quoted 8 lines
recipes/e17/enjoy_svn.bb +1 -1
@@ -13,7 +13,7 @@ DEPENDS += "gst-plugins-good ${@base_conditional('ENTERPRISE_DISTRO', '1', '', '
 #4th needed for flac playback
 #5th needed binary to create db
 RDEPENDS += "\
-	gst-plugin-typefindfunctions gst-plugin-playbin gst-plugin-volume gst-plugin-decodebin2  \
+	gst-plugin-typefindfunctions gst-plugin-playbin gst-plugin-volume gst-plugin-decodebin2  gst-plugin-alsa gst-plugin-autodetect \
 	${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'gst-plugin-mad gst-plugin-id3demux', d)} \
 	gst-plugin-ogg gst-plugin-ivorbisdec \
 	gst-plugin-flac \

Otherwise this looks good. Please resend as “v2” [2].

Thanks,

Paul

[1] http://openembedded.org/index.php/Commit_Policy
[2] http://openembedded.org/index.php/How_to_submit_a_patch_to_OpenEmbedded

#2 lore raw

Hi, thanks for reviewing it ;)

2011/6/13 Paul Menzel <[email protected]>

Quoted 3 lines

Please also paste the important parts of the segfault into the commit message.

I don't have the segfault right now because I've using buil enjoy with this patch for few days since now. Basically it seems that emotion is using autodetect gst pipe element, which in turn is using alsa.

I think it was this file/line in emotion:
emotion_gstreamer_pipeline.c: sink =
gst_element_factory_make("autoaudiosink", "audiosink");

I'm using SHR distro.

I'll send new patch version now.

Signature · 3 lines
Pau Espin Pedrol
mail/jabber: [email protected]
http://blog.espeweb.net
#3 lore raw

2011/6/13 Pau Espin Pedrol <[email protected]>:

Quoted 20 lines

Hi, thanks for reviewing it ;)

2011/6/13 Paul Menzel <[email protected]>

Quoted 3 lines

Please also paste the important parts of the segfault into the commit message.

I don't have the segfault right now because I've using buil enjoy with this patch for few days since now. Basically it seems that emotion is using autodetect gst pipe element, which in turn is using alsa.

I think it was this file/line in emotion:
emotion_gstreamer_pipeline.c:   sink = gst_element_factory_make("autoaudiosink", "audiosink");

I'm using SHR distro.

I'll send new patch version now.

Quoted 9 lines

--
Pau Espin Pedrol
mail/jabber: [email protected]
http://blog.espeweb.net
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

If you think there is a problem in emotion, we could fix it upstream ?

Signature · 4 lines
Nicolas Aguirre
Mail: [email protected]
Web: http://enna.geexbox.org
Blog: http://dev.enlightenment.fr/~captainigloo/
#4 lore raw

Well I wouldn't say it's a problem itself.. it's just how emotion works... it uses that gstreamer module so it's a needed dep in order to run ;)

Signature · 3 lines
Pau Espin Pedrol
mail/jabber: [email protected]
http://blog.espeweb.net
#5 lore raw

Am Montag, den 13.06.2011, 21:19 +0200 schrieb Pau Espin Pedrol:

Quoted 2 lines

Well I wouldn't say it's a problem itself.. it's just how emotion works... it uses that gstreamer module so it's a needed dep in order to run ;)

But maybe it should fail gracefully and not segfault.

Thanks,

Paul

#6 lore raw

2011/6/13 Paul Menzel <[email protected]>

Quoted 1 line

But maybe it should fail gracefully and not segfault.

For sure, but imo this has nothing to do with this patch. I'm just adding needed deps for the app to do its work as expected :)

Signature · 3 lines
Pau Espin Pedrol
mail/jabber: [email protected]
http://blog.espeweb.net
#7 lore raw

Am Montag, den 13.06.2011, 23:16 +0200 schrieb Pau Espin Pedrol:

Quoted 5 lines

2011/6/13 Paul Menzel <[email protected]>

Quoted 1 line

But maybe it should fail gracefully and not segfault.

For sure, but imo this has nothing to do with this patch. I'm just adding needed deps for the app to do its work as expected :)

Of course.

To improve Enjoy it would be perfect to report that problem to the upstream developers. This would be the perfect solution for this problem.

Thanks,

Paul

#8 lore raw

2011/6/13 Paul Menzel <[email protected]>

Quoted 15 lines

Am Montag, den 13.06.2011, 23:16 +0200 schrieb Pau Espin Pedrol:

Quoted 5 lines

2011/6/13 Paul Menzel <[email protected]>

Quoted 1 line

But maybe it should fail gracefully and not segfault.

For sure, but imo this has nothing to do with this patch. I'm just adding

needed deps for the app to do its work as expected :)

Of course.

To improve Enjoy it would be perfect to report that problem to the upstream developers. This would be the perfect solution for this problem.

Quoted 10 lines

Thanks,

Paul

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

I might find time to write and send a patch for that to emotion guys :)

Signature · 3 lines
Pau Espin Pedrol
mail/jabber: [email protected]
http://blog.espeweb.net
#9 lore raw

Am Dienstag, den 14.06.2011, 00:08 +0200 schrieb Pau Espin Pedrol:

Quoted 10 lines

2011/6/13 Paul Menzel <[email protected]>

Quoted 8 lines

Am Montag, den 13.06.2011, 23:16 +0200 schrieb Pau Espin Pedrol:

Quoted 5 lines

2011/6/13 Paul Menzel <[email protected]>

Quoted 1 line

But maybe it should fail gracefully and not segfault.

For sure, but imo this has nothing to do with this patch. I'm just adding

needed deps for the app to do its work as expected :)

Quoted 7 lines
Quoted 5 lines

Of course.

To improve Enjoy it would be perfect to report that problem to the upstream developers. This would be the perfect solution for this problem.

I might find time to write and send a patch for that to emotion guys :)

Awesome! A report would be fine too. Maybe a developer already tackled that or they have different ideas.

Thanks,

Paul