mfd: Add Makefile and Kconfig Entries for tps65911 comparator

Base on Mark's comment [1], I make the Kconfig entry invisible to users.
[1] https://lkml.org/lkml/2011/5/14/136

---
Hi Jorge,
I don't have this device handy, can you help to test this serial of patches? Thanks,
Axel

 drivers/mfd/Kconfig  |    3 +++
 drivers/mfd/Makefile |    1 +
 2 files changed, 4 insertions(+), 0 deletions(-)

index 519ebab..76a7223 100644
@@ -751,6 +751,9 @@ config MFD_TPS65910
 	  if you say yes here you get support for the TPS65910 series of
 	  Power Management chips.
 
+config TPS65911_COMPARATOR
+	tristate
+
 endif # MFD_SUPPORT
 
 menu "Multimedia Capabilities Port drivers"

index 5309ec3..35c5476 100644
@@ -99,3 +99,4 @@ obj-$(CONFIG_MFD_OMAP_USB_HOST)	+= omap-usb-host.o
 obj-$(CONFIG_MFD_PM8921_CORE) 	+= pm8921-core.o
 obj-$(CONFIG_MFD_PM8XXX_IRQ) 	+= pm8xxx-irq.o
 obj-$(CONFIG_MFD_TPS65910)	+= tps65910.o tps65910-irq.o
+obj-$(CONFIG_TPS65911_COMPARATOR)	+= tps65911-comparator.o

1.7.4.1

Fix below build error:
CC drivers/mfd/tps65911-comparator.o
drivers/mfd/tps65911-comparator.c: In function 'tps65911_comparator_probe':
drivers/mfd/tps65911-comparator.c:131: error: 'struct tps65910_platform_data' has no member named 'vmbch_threshold' drivers/mfd/tps65911-comparator.c:137: error: 'struct tps65910_platform_data' has no member named 'vmbch2_threshold' make[2]: *** [drivers/mfd/tps65911-comparator.o] Error 1
make[1]: *** [drivers/mfd] Error 2
make: *** [drivers] Error 2

---
 drivers/mfd/tps65911-comparator.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

index 3d2dc56..283ac67 100644
@@ -125,7 +125,7 @@ static DEVICE_ATTR(comp2_threshold, S_IRUGO, comp_threshold_show, NULL);
 static __devinit int tps65911_comparator_probe(struct platform_device *pdev)
 {
 	struct tps65910 *tps65910 = dev_get_drvdata(pdev->dev.parent);
-	struct tps65910_platform_data *pdata = dev_get_platdata(tps65910->dev);
+	struct tps65910_board *pdata = dev_get_platdata(tps65910->dev);
 	int ret;
 
 	ret = comp_threshold_set(tps65910, COMP1,  pdata->vmbch_threshold);

1.7.4.1

---
 drivers/mfd/tps65911-comparator.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

index 283ac67..e7ff783 100644
@@ -157,6 +157,8 @@ static __devexit int tps65911_comparator_remove(struct platform_device *pdev)
 	struct tps65910 *tps65910;
 
 	tps65910 = dev_get_drvdata(pdev->dev.parent);
+	device_remove_file(&pdev->dev, &dev_attr_comp2_threshold);
+	device_remove_file(&pdev->dev, &dev_attr_comp1_threshold);
 
 	return 0;
 }

1.7.4.1

2011/6/23 <[email protected]>:

I was thinking the driver that adds "tps65911-comparator" device should select CONFIG_TPS65911_COMPARATOR symbol.

Or maybe it is ok just make config TPS65911_COMPARATOR visible to users and make it depend on MFD_TPS65910.

Comments?

Regards,
Axel

Hi Axel,

Thanks for the patches. All 3 applied, with #1 and #2 queued to my for-linus branch.

Cheers,
Samuel.

Intel Open Source Technology Centre
http://oss.intel.com/