Skip to contentSkip to conversation

poky-lsb.conf: Instead of += with _append

PATCH Applied Xiaofeng Yan 2 participants 3 messages Jun 23, 2011

lore
Share & tools
lore
#0 lore raw

cover poky-lsb.conf: Instead of += with _append

From: Xiaofeng Yan <[email protected]>

Hi Richard,

The variable "DISTRO_FEATURES += " lost its function because it has been moved to defaultsetup.conf. Defaultsetup.conf is included after poky-lsb.conf. So the variable is empty. I use "_append" to take place of "+=". Please check patch for detailed information.

Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: xiaofeng/poky-lsb
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=xiaofeng/poky-lsb

Thanks,
Xiaofeng Yan <[email protected]>
---

Xiaofeng Yan (1):
poky-lsb.conf: Instead of += with _append

 meta-yocto/conf/distro/poky-lsb.conf |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
#1 lore raw

PATCH 1/1 poky-lsb.conf: Instead of += with _append

From: Xiaofeng Yan <[email protected]>

The default variable DISTRO_FEATURES was set in poky.conf before \
moving to defaultsetup.conf. Defaultsetup.conf is included after poky-lsb.conf \
So poky-lsb.conf sets the variable using += but since its empty, \
it might as well be an = and then the later ?= doesn't do anything since the \
variable is already set.

---
 meta-yocto/conf/distro/poky-lsb.conf |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
meta-yocto/conf/distro/poky-lsb.conf +1 -1
index eb1cf82..49d12da 100644
@@ -3,7 +3,7 @@ require conf/distro/poky.conf
 DISTRO = "poky-lsb"
 DISTROOVERRIDES = "poky:linuxstdbase"
 
-DISTRO_FEATURES += "pam largefile"
+DISTRO_FEATURES_append = " pam largefile"
 PREFERRED_PROVIDER_virtual/libx11 = "libx11"
 
 
Signature · 1 line
1.7.0.4
#2 lore raw
In reply to Xiaofeng Yan
Quoted 12 lines · Xiaofeng Yan

From: Xiaofeng Yan <[email protected]>

Hi Richard,

The variable "DISTRO_FEATURES += " lost its function because it has been moved to defaultsetup.conf. Defaultsetup.conf is included after poky-lsb.conf. So the variable is empty. I use "_append" to take place of "+=". Please check patch for detailed information.

Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: xiaofeng/poky-lsb
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=xiaofeng/poky-lsb

Quoted 7 lines

Thanks,
Xiaofeng Yan <[email protected]>
---

Xiaofeng Yan (1):
poky-lsb.conf: Instead of += with _append

Merged to master, thanks.

Richard