kernel-yocto: Fix case where recipe is always reparsed
PATCH 1/2 kernel-yocto: Fix case where recipe is always reparsed
If you include a bitbake variable as a comment in a shell function then it gets expanded by the bitbake signature handling code.
This could be classed as a bug or a feature depending on your viewpoint (e.g. a multiline variable included in a comment could actually contain executable code).
Since we don't always want kernel-yocto to reparse this changes the syntax of the comment so it doesn't trigger the problem.
--- meta/classes/kernel-yocto.bbclass | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
meta/classes/kernel-yocto.bbclass +1 -1
@@ -136,7 +136,7 @@ do_validate_branches() { return fi - # nothing to do if SRCREV=${AUTOREV} + # nothing to do if SRCREV is AUTOREV if [ "${SRCREV_machine}" = "AUTOINC" ]; then # restore the branch for builds git checkout -f ${KBRANCH}
Quoted 9 lines · Richard Purdie
If you include a bitbake variable as a comment in a shell function then it gets expanded by the bitbake signature handling code.
This could be classed as a bug or a feature depending on your viewpoint (e.g. a multiline variable included in a comment could actually contain executable code).
Since we don't always want kernel-yocto to reparse this changes the syntax of the comment so it doesn't trigger the problem.
Indeed! I had no idea. But this makes sense to me. I haven't checked to see if this is already in the tree, but I can add my Acked-by to this.
Cheers,
Bruce
Quoted 26 lines
Signed-off-by Richard Purdie <[email protected]>---
meta/classes/kernel-yocto.bbclass | 2 +-1 files changed, 1 insertions(+), 1 deletions(-)meta/classes/kernel-yocto.bbclass +0
-0@@ -136,7 +136,7 @@ do_validate_branches() {return
fi- # nothing to do if SRCREV=${AUTOREV}
+ # nothing to do if SRCREV is AUTOREV if [ "${SRCREV_machine}" = "AUTOINC" ]; then# restore the branch for builds git checkout -f ${KBRANCH}_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Signature · 2 lines
"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"