Skip to contentSkip to conversation

input : wacom - Add serial number for Graphire4 and old Bamboo

PATCH Applied Ping Cheng 2 participants 2 messages Jul 5, 2011 – Jul 6, 2011

Subsystems (2)
HID Input drivers
lore
Share & tools
lore

Ping Cheng

author
#0 lore raw

PATCH v2 1/3 input : wacom - Add serial number for Graphire4 and old Bamboo

With the removal of BTN_TOOL_FINGER for tablet buttons and expresskeys, serial number is needed to distingush if the events were from a regular tool (stylus, eraser, or mouse) or the attribures (buttons, strips, or wheels) on the tablet since there are overlapped events between the tools and the tablet attributes.

Signed-off-by Ping Cheng <[email protected]>
---
 drivers/input/tablet/wacom_wac.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/input/tablet/wacom_wac.c +1 -0
index 7ce1294..b93501a 100644
@@ -265,6 +265,7 @@ static int wacom_graphire_irq(struct wacom_wac *wacom)
 			wacom->id[0] = 0;
 		input_report_abs(input, ABS_MISC, wacom->id[0]); /* report tool id */
 		input_report_key(input, wacom->tool[0], prox);
+		input_event(input, EV_MSC, MSC_SERIAL, 1);
 		input_sync(input); /* sync last event */
 	}
Signature · 1 line
1.7.5.4
Reviewed-by on v2 1/3
#1 lore raw
Quoted 8 lines · Ping Cheng

With the removal of BTN_TOOL_FINGER for tablet buttons and expresskeys, serial number is needed to distingush if the events were from a regular tool (stylus, eraser, or mouse) or the attribures (buttons, strips, or wheels) on the tablet since there are overlapped events between the tools and the tablet attributes.

Signed-off-by Ping Cheng <[email protected]>

This patch I believe will even work in isolation of others in series and will fix some pad button issues reported by various graphire users.

Reviewed-by Chris Bagwell <[email protected]>
Quoted 16 lines

---
 drivers/input/tablet/wacom_wac.c |    1 +

 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/input/tablet/wacom_wac.c +0 -0
index 7ce1294..b93501a 100644
@@ -265,6 +265,7 @@ static int wacom_graphire_irq(struct wacom_wac *wacom)
                        wacom->id[0] = 0;

               input_report_abs(input, ABS_MISC, wacom->id[0]); /* report tool id */ input_report_key(input, wacom->tool[0], prox);
+               input_event(input, EV_MSC, MSC_SERIAL, 1); input_sync(input); /* sync last event */
       }

Quoted 8 lines

--
1.7.5.4

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html