dbus-glib-native and dbus-glib corrected
cover dbus-glib-native and dbus-glib corrected
Hi all,
dbus-glib-native and dbus-glib were not compiling.
Reason were in how the dbus-glib.inc and dbus-glib_0.86.bb were wrote. The patch clears what the recipe has to do for each target compilation.
More info from http://www.mail-archive.com/[email protected]/msg10184.html
[cut]
Quoted 4 lines
I suspect that code could well have come from Poky. In this case the native recipe generates a file which is then used by the target builds. It can't be generated in the target recipe as that would mean running target binaries.
[cut]
Patch compiles and dbus-glib works on target device (tested with mini2440).
Regards,
Alessandro
Alessandro Sappia (1):
dbus-glib-native and dbus-glib were not compiling. This patch
corrects dbus-glib-native to install required files in order to let dbus-glib to compile on target.
recipes/dbus/dbus-glib.inc | 4 ++-- recipes/dbus/dbus-glib_0.86.bb | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
Signature · 1 line
1.7.4.1
A message that is not in the archive (sent off-list or not yet received): d0771ab59e5a19cd41045ecaf5f390926a78e229.1309949770.git.a.sappia@biotechware.com
Re: [PATCH 1/1] dbus-glib-native and dbus-glib were not compiling. This patch corrects dbus-glib-native to install required files in order to let dbus-glib to compile on target.
Dear Alessandro,
Am Mittwoch, den 06.07.2011, 13:12 +0200 schrieb Alessandro Sappia:
unfortunately you seem to have forgotten to insert line breaks when composing the commit message. Please correct that for example using git commit --amend.
Please also follow OE’s commit policy [1] and resend your patch as v2 [2].
Quoted 5 lines
Signed-off-by Alessandro Sappia <[email protected]>--- recipes/dbus/dbus-glib.inc | 4 ++-- recipes/dbus/dbus-glib_0.86.bb | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
Thanks,
Paul
[1] http://openembedded.org/index.php/Commit_Policy
[2] http://openembedded.org/index.php/How_to_submit_a_patch_to_OpenEmbedded
PATCH v2 1/1 dbus-glib: install required files for target on native build
dbus-glib-native and dbus-glib were not compiling. This patch corrects dbus-glib-native to install required files in order to let dbus-glib to compile on target.
--- recipes/dbus/dbus-glib.inc | 4 ++-- recipes/dbus/dbus-glib_0.86.bb | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
recipes/dbus/dbus-glib.inc +2 -2
@@ -21,10 +21,10 @@ inherit autotools pkgconfig gettext BBCLASSEXTEND = "native" -do_configure_prepend() { +do_configure() { install -m 0644 ${STAGING_DATADIR_NATIVE}/dbus/dbus-bus-introspect.xml ${S}/tools/ install -m 0644 ${STAGING_DATADIR_NATIVE}/dbus/dbus-glib-bindings.h ${S}/tools/ - + autotools_do_configure } do_configure_virtclass-native() {
recipes/dbus/dbus-glib_0.86.bb +2 -2
@@ -1,10 +1,10 @@ require dbus-glib.inc -PR = "${INC_PR}.1" +PR = "${INC_PR}.2" SRC_URI_virtclass-native += "file://run-with-tmp-session-bus.patch" -do_install_virtclass-native_prepend() { +do_install_append_virtclass-native() { install -d ${D}${datadir}/dbus install -m 0644 dbus-bus-introspect.xml ${D}${datadir}/dbus }
Signature · 1 line
1.7.4.1
Re: [PATCH v2] dbus-glib: install required files for target on native build
Quoted 15 lines · Alessandro Sappia
dbus-glib-native and dbus-glib were not compiling. This patch corrects dbus-glib-native to install required files in order to let dbus-glib to compile on target.
Signed-off-by Alessandro Sappia <[email protected]>--- recipes/dbus/dbus-glib.inc | 4 ++-- recipes/dbus/dbus-glib_0.86.bb | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)recipes/dbus/dbus-glib.inc +0
-0
recipes/dbus/dbus-glib.inc inherit autotools pkgconfig gettext · line 28
Quoted 10 lines
recipes/dbus/dbus-glib.inc +2
-2@@ -21,10 +21,10 @@ inherit autotools pkgconfig gettext BBCLASSEXTEND = "native" -do_configure_prepend() { +do_configure() { install -m 0644 ${STAGING_DATADIR_NATIVE}/dbus/dbus-bus-introspect.xml ${S}/tools/ install -m 0644 ${STAGING_DATADIR_NATIVE}/dbus/dbus-glib-bindings.h ${S}/tools/ - + autotools_do_configure }
^^^^^^^^^^^^^
Why you changed this? The code in resulting shellfile should be looking the same, but using the prepend is normaly the better way.
Quoted 9 lines
recipes/dbus/dbus-glib.inc +0
-0do_configure_virtclass-native() {recipes/dbus/dbus-glib_0.86.bb +0
-0@@ -1,10 +1,10 @@ require dbus-glib.inc
recipes/dbus/dbus-glib_0.86.bb line 10
Quoted 10 lines
recipes/dbus/dbus-glib_0.86.bb +2
-2-PR = "${INC_PR}.1" +PR = "${INC_PR}.2" SRC_URI_virtclass-native += "file://run-with-tmp-session-bus.patch" -do_install_virtclass-native_prepend() { +do_install_append_virtclass-native() { install -d ${D}${datadir}/dbus install -m 0644 dbus-bus-introspect.xml ${D}${datadir}/dbus }
I hope this works, there was some problems with the whole introspection stuff.
Bye henning
Re: [PATCH v2] dbus-glib: install required files for target on native build
Il giorno mer, 06/07/2011 alle 14.11 +0200, Henning Heinold ha scritto:
Quoted 28 lines · Alessandro Sappia
Quoted 15 lines
dbus-glib-native and dbus-glib were not compiling. This patch corrects dbus-glib-native to install required files in order to let dbus-glib to compile on target.
Signed-off-by Alessandro Sappia <[email protected]>--- recipes/dbus/dbus-glib.inc | 4 ++-- recipes/dbus/dbus-glib_0.86.bb | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)recipes/dbus/dbus-glib.inc +0
-0recipes/dbus/dbus-glib.inc inherit autotools pkgconfig gettext · line 28
Quoted 10 lines
recipes/dbus/dbus-glib.inc +2
-2@@ -21,10 +21,10 @@ inherit autotools pkgconfig gettext BBCLASSEXTEND = "native" -do_configure_prepend() { +do_configure() { install -m 0644 ${STAGING_DATADIR_NATIVE}/dbus/dbus-bus-introspect.xml ${S}/tools/ install -m 0644 ${STAGING_DATADIR_NATIVE}/dbus/dbus-glib-bindings.h ${S}/tools/ - + autotools_do_configure }^^^^^^^^^^^^^
Quoted 3 lines
Why you changed this? The code in resulting shellfile should be looking the same, but using the prepend is normaly the better way.
Because later in the file there is do_configure_virtclass-native() function.
The whole things is:do_comfigure() is for cross compilation targets, while do_configure_virtclass-native() is for native
OE enviroment.
This is because the do_configure_prepend() was executed also on native target, which we need to avoid.
If there was a virtclass-cross available (is it there ?) the patch may be simplified in
do_configure_prepend_virtclass-cross(){
install -m 0644 {STAGING_DATADIR_NATIVE}/dbus/dbus-bus-introspect.xml
${S}/tools/
install -m 0644 ${STAGING_DATADIR_NATIVE}/dbus/dbus-glib-bindings.h ${S}/tools/
}
I'd like more to do this way, but this requires the definition of virtclass-cross (or whatever the name it is if such a class exists already): I wasn't able to find the correct virtclass for writing the patch this way.
Quoted 28 lines
Quoted 9 lines
recipes/dbus/dbus-glib.inc +0
-0do_configure_virtclass-native() {recipes/dbus/dbus-glib_0.86.bb +0
-0@@ -1,10 +1,10 @@ require dbus-glib.increcipes/dbus/dbus-glib_0.86.bb line 10
Quoted 10 lines
recipes/dbus/dbus-glib_0.86.bb +2
-2-PR = "${INC_PR}.1" +PR = "${INC_PR}.2" SRC_URI_virtclass-native += "file://run-with-tmp-session-bus.patch" -do_install_virtclass-native_prepend() { +do_install_append_virtclass-native() { install -d ${D}${datadir}/dbus install -m 0644 dbus-bus-introspect.xml ${D}${datadir}/dbus }I hope this works, there was some problems with the whole introspection stuff.
Bye henning
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel