QA warning fixes

I found a couple of issues with the recent insane.bbclass changes. The following patches fix them as well as add a warning fix for something I noticed when building a kernel with LIRC support.

The following changes since commit f1fc6d084b079dea21ff1a30b815496452042490:

pulseaudio: add 0.9.23 (2011-07-07 13:44:36 +0100)

are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib paule/qa-dev-deps
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/qa-dev-deps

Paul Eggleton (3):
insane.bbclass: allow dev-deps to be skipped via INSANE_SKIP insane.bbclass: fix error/warning status being inverted kernel.bbclass: prevent QA warning about kernel-module-lirc-dev

 meta/classes/insane.bbclass |    6 +++---
 meta/classes/kernel.bbclass |    4 ++++
 2 files changed, 7 insertions(+), 3 deletions(-)

1.7.4.1

Add the missing check in package_qa_check_rdepends to allow dependencies from non-development packages on development packages to be skipped.

---
 meta/classes/insane.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

index c1db1ca..1cf7014 100644
@@ -443,7 +443,7 @@ def package_qa_check_rdepends(pkg, pkgdest, skip, d):
             if "-dbg" in rdepend and "debug-deps" not in skip:
                 error_msg = "%s rdepends on %s" % (pkgname,rdepend)
                 sane = package_qa_handle_error("debug-deps", error_msg, d)
-            if (not "-dev" in pkg and not "-staticdev" in pkg) and rdepend.endswith("-dev"):
+            if (not "-dev" in pkg and not "-staticdev" in pkg) and rdepend.endswith("-dev") and "dev-deps" not in skip:
                 error_msg = "%s rdepends on %s" % (pkgname, rdepend)
                 sane = package_qa_handle_error("dev-deps", error_msg, d)
 

1.7.4.1

Fix package_qa_handle_error so that it returns the correct values in order to determine error/warning status.

---
 meta/classes/insane.bbclass |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

index 1cf7014..1567f36 100644
@@ -112,10 +112,10 @@ def package_qa_handle_error(error_class, error_msg, d):
     package_qa_write_error(error_msg, d)
     if error_class in (d.getVar("ERROR_QA", True) or "").split():
         bb.error("QA Issue: %s" % error_msg)
-        return True
+        return False
     else:
         bb.warn("QA Issue: %s" % error_msg)
-        return False
+        return True
 
 QAPATHTEST[rpaths] = "package_qa_check_rpath"
 def package_qa_check_rpath(file,name, d, elf, messages):

1.7.4.1

kernel-module-lirc-dev is not a development package (it's a package for a kernel module called lirc_dev) so add an INSANE_SKIP that will prevent it from being flagged up.

---
 meta/classes/kernel.bbclass |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

index 943252a..318f5c2 100644
@@ -503,3 +503,7 @@ PACKAGES =+ "perf-dbg perf"
 FILES_perf = "${bindir}/* \
               ${libexecdir}"
 FILES_perf-dbg = "${FILES_${PN}-dbg}"
+
+# We don't want a warning for kernel-module-lirc-dev
+INSANE_SKIP_kernel-module-ir-lirc-codec += "dev-deps"
+

1.7.4.1

Yeah, or try to be smarter about determining what exactly is a "dev" package, e.g. by some sort of flag variable rather than by trying to guess from the name.

p.

I've taken the first two patches, thanks. In the third case, I think we have bigger problems for both -dbg and -dev packages matching in kernel module space. We should probably disable those two checks for all kernel modules somehow...

Cheers,

Richard