Skip to contentSkip to conversation

dell-laptop - using buffer without mutex_lock

PATCH In review Jose Alonso 2 participants 2 messages Jul 8, 2011 – Jul 9, 2011

lore
Share & tools
lore

Jose Alonso

author
#0 lore raw

PATCH 1/1 dell-laptop - using buffer without mutex_lock

Using buffer->output[1] without mutex_lock()

--- linux-3.0-rc6/drivers/platform/x86/dell-laptop.c.ORIG

2011-07-04 19:56:24.000000000 -0300
+++ linux-3.0-rc6/drivers/platform/x86/dell-laptop.c    2011-07-08
18:27:02.420791868 -0300
@@ -560,11 +560,11 @@
        else
                dell_send_request(buffer, 0, 1);

+ ret = buffer->output[1];
+
out:

        release_buffer();

- if (ret)
- return ret;
- return buffer->output[1];
+ return ret;
}

static const struct backlight_ops dell_ops = {

#1 lore raw

Hi Jose,

Quoted 14 lines · Jose Alonso

Using buffer->output[1] without mutex_lock()

--- linux-3.0-rc6/drivers/platform/x86/dell-laptop.c.ORIG

2011-07-04 19:56:24.000000000 -0300

+++ linux-3.0-rc6/drivers/platform/x86/dell-laptop.c 2011-07-08
18:27:02.420791868 -0300

(quoted diff) +2 -0
@@ -560,11 +560,11 @@
        else
                dell_send_request(buffer, 0, 1);
 
+       ret = buffer->output[1];
+
 out:
        release_buffer();

Review

Quoted 10 lines
(quoted diff) +1 -4
-       if (ret)
-               return ret;
-       return buffer->output[1];
+       return ret;
 }
 
 static const struct backlight_ops dell_ops = {
 
 
--

You should run this patch through scripts/checkpatch.pl as it reports a few style issues for your patch including a missing signed-off-by line and some spaces that should be converted to tabs.

Greg