Skip to contentSkip to conversation

pcsc-lite and ccid support

PATCH New ruckuus at gmail.com 2 participants 5 messages Jul 12, 2011 – Jul 13, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pcsc-lite and ccid support

From: Dwi Sasongko S <[email protected]>

This is support for a generic usb smartcard reader.

See the project page:
http://pcsclite.alioth.debian.org/

List of supported hardware:
http://pcsclite.alioth.debian.org/ccid/section.html

---
 package/Config.in              |    2 ++
 package/ccid/Config.in         |   15 +++++++++++++++
 package/ccid/ccid.mk           |   13 +++++++++++++
 package/pcsc-lite/Config.in    |    8 ++++++++
 package/pcsc-lite/pcsc-lite.mk |   13 +++++++++++++
 5 files changed, 51 insertions(+), 0 deletions(-)
 create mode 100644 package/ccid/Config.in
 create mode 100644 package/ccid/ccid.mk
 create mode 100644 package/pcsc-lite/Config.in
 create mode 100644 package/pcsc-lite/pcsc-lite.mk
package/Config.in +2 -0
index 09aa76a..db82d95 100644
@@ -303,6 +303,7 @@ source "package/libiqrf/Config.in"
 source "package/libusb/Config.in"
 source "package/libusb-compat/Config.in"
 source "package/python-serial/Config.in"
+source "package/pcsc-lite/Config.in"
 endmenu
 
 if BROKEN
@@ -342,6 +343,7 @@ source "package/libnspr/Config.in"
 source "package/liboil/Config.in"
 source "package/libsigc/Config.in"
 source "package/startup-notification/Config.in"
+source "package/ccid/Config.in"
 endmenu
 
 menu "Text and terminal handling"
package/ccid/Config.in new file +15 -0
new file mode 100644
index 0000000..35bec37
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_CCID
+	bool "ccid"
+	select BR2_PACKAGE_PKG_CONFIG
+	select BR2_PACKAGE_LIBUSB
+	select BR2_PACKAGE_PCSC_LITE
+	help
+	  This package provides the source code for a generic USB CCID 
+	  (Chip/Smart Card Interface Device) driver and ICCD (Integrated Circuit(s) Card Devices)
+	  
+	  For more information, please visit the project page: 
+	  http://pcsclite.alioth.debian.org/ccid.html
+
+	  List of supported hardware:
+	  http://pcsclite.alioth.debian.org/ccid/section.html
+
package/ccid/ccid.mk new file +13 -0
new file mode 100644
index 0000000..3263ccd
@@ -0,0 +1,13 @@
+##########################################################
+#
+# CCID
+#
+# ########################################################
+CCID_VERSION = 1.4.4 
+CCID_SOURCE = ccid-$(CCID_VERSION).tar.bz2
+CCID_SITE = https://alioth.debian.org/frs/download.php/3579
+CCID_INSTALL_STAGING = YES
+CCID_INSTALL_TARGET = YES
+CCID_DEPENDENCIES = pkg-config libusb pcsc-lite
+
+$(eval $(call AUTOTARGETS, package, ccid))
package/pcsc-lite/Config.in new file +8 -0
new file mode 100644
index 0000000..55ac6d3
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_PCSC_LITE
+	bool "pcsc-lite"
+	select BR2_PACKAGE_LIBUSB
+	help
+	  Middleware to access a smart card using SCard API (PC/SC).
+	  For more information, please visit:
+	  http://pcsclite.alioth.debian.org/pcsclite.html
+
package/pcsc-lite/pcsc-lite.mk new file +13 -0
new file mode 100644
index 0000000..2fdda5f
@@ -0,0 +1,13 @@
+##########################################################
+#
+# PCSC-Lite
+#
+# ########################################################
+PCSC_LITE_VERSION = 1.7.4
+PCSC_LITE_SOURCE = pcsc-lite-$(PCSC_LITE_VERSION).tar.bz2
+PCSC_LITE_SITE = https://alioth.debian.org/frs/download.php/3598
+PCSC_LITE_INSTALL_STAGING = YES
+PCSC_LITE_INSTALL_TARGET = YES
+PCSC_LITE_CONF_OPT = --disable-libudev --enable-libusb --enable-embedded
+
+$(eval $(call AUTOTARGETS, package, pcsc-lite))
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 pcsc-lite and ccid support

Le Tue, 12 Jul 2011 17:10:37 +0700,
ruckuus at gmail.com a ?crit :

package/ccid/Config.in line 3

Quoted 3 lines
package/ccid/Config.in new file +3 -0
+config BR2_PACKAGE_CCID
+	bool "ccid"
+	select BR2_PACKAGE_PKG_CONFIG

No, I don't think you need pkg-config on the target.

Quoted 1 line

+CCID_DEPENDENCIES = pkg-config libusb pcsc-lite

Are you really sure you need pkg-config on the target ? Usually, pkg-config is needed in the host. In this case, add "host-pkg-config" to the DEPENDENCIES variable, and do not "select" anything related to BR2_PACKAGE_PKG_CONFIG in the Config.in file.

Quoted 1 line

+$(eval $(call AUTOTARGETS, package, ccid))

No space after the commas:

$(eval $(call AUTOTARGETS,package,ccid))

Quoted 21 lines
package/pcsc-lite/Config.in new file +8 -0
new file mode 100644
index 0000000..55ac6d3
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_PCSC_LITE
+	bool "pcsc-lite"
+	select BR2_PACKAGE_LIBUSB
+	help
+	  Middleware to access a smart card using SCard API (PC/SC).
+	  For more information, please visit:
+	  http://pcsclite.alioth.debian.org/pcsclite.html
+
package/pcsc-lite/pcsc-lite.mk new file +1 -0
new file mode 100644
index 0000000..2fdda5f
@@ -0,0 +1,13 @@
+##########################################################

package/pcsc-lite/pcsc-lite.mk line 11

Quoted 10 lines
package/pcsc-lite/pcsc-lite.mk new file +10 -0
+#
+# PCSC-Lite
+#
+# ########################################################
+PCSC_LITE_VERSION = 1.7.4
+PCSC_LITE_SOURCE = pcsc-lite-$(PCSC_LITE_VERSION).tar.bz2
+PCSC_LITE_SITE = https://alioth.debian.org/frs/download.php/3598
+PCSC_LITE_INSTALL_STAGING = YES
+PCSC_LITE_INSTALL_TARGET = YES
+PCSC_LITE_CONF_OPT = --disable-libudev --enable-libusb --enable-embedded

According to your Config.in, this package depends on LIBUSB. If it is indeed the case, then libusb should be in the DEPENDENCIES variable of this package.

package/pcsc-lite/pcsc-lite.mk line 13

Quoted 1 line
package/pcsc-lite/pcsc-lite.mk new file +1 -0
+$(eval $(call AUTOTARGETS, package, pcsc-lite))

No spaces after commas.

$(eval $(call AUTOTARGETS,package,pcsc-lite))

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 1/1 pcsc-lite and ccid support

Quoted 7 lines · Thomas Petazzoni

Le Tue, 12 Jul 2011 17:10:37 +0700,
ruckuus at gmail.com a ?crit :

Quoted 3 lines

+config BR2_PACKAGE_CCID
+ ? ? bool "ccid"
+ ? ? select BR2_PACKAGE_PKG_CONFIG

Quoted 9 lines

No, I don't think you need pkg-config on the target.

Quoted 1 line

+CCID_DEPENDENCIES = pkg-config libusb pcsc-lite

Are you really sure you need pkg-config on the target ? Usually, pkg-config is needed in the host. In this case, add "host-pkg-config" to the DEPENDENCIES variable, and do not "select" anything related to BR2_PACKAGE_PKG_CONFIG in the Config.in file.

Ok. Actually no need pkg-config on the target, you are right, I need host-pkg-config instead.

Quoted 33 lines
Quoted 1 line

+$(eval $(call AUTOTARGETS, package, ccid))

No space after the commas:

$(eval $(call AUTOTARGETS,package,ccid))

Quoted 27 lines
package/pcsc-lite/Config.in new file +8 -0
new file mode 100644
index 0000000..55ac6d3
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_PCSC_LITE
+ ? ? bool "pcsc-lite"
+ ? ? select BR2_PACKAGE_LIBUSB
+ ? ? help
+ ? ? ? Middleware to access a smart card using SCard API (PC/SC).
+ ? ? ? For more information, please visit:
+ ? ? ? http://pcsclite.alioth.debian.org/pcsclite.html
+
package/pcsc-lite/pcsc-lite.mk new file +7 -0
new file mode 100644
index 0000000..2fdda5f
@@ -0,0 +1,13 @@
+##########################################################
+#
+# PCSC-Lite
+#
+# ########################################################
+PCSC_LITE_VERSION = 1.7.4
+PCSC_LITE_SOURCE = pcsc-lite-$(PCSC_LITE_VERSION).tar.bz2
Quoted 9 lines

package/pcsc-lite/pcsc-lite.mk line 11

Quoted 4 lines
package/pcsc-lite/pcsc-lite.mk new file +4 -0
+PCSC_LITE_SITE = https://alioth.debian.org/frs/download.php/3598
+PCSC_LITE_INSTALL_STAGING = YES
+PCSC_LITE_INSTALL_TARGET = YES
+PCSC_LITE_CONF_OPT = --disable-libudev --enable-libusb --enable-embedded

According to your Config.in, this package depends on LIBUSB. If it is indeed the case, then libusb should be in the DEPENDENCIES variable of this package.

Yes, I forgot this. Now it is corrected.

Quoted 6 lines

package/pcsc-lite/pcsc-lite.mk line 13

Quoted 1 line
package/pcsc-lite/pcsc-lite.mk new file +1 -0
+$(eval $(call AUTOTARGETS, package, pcsc-lite))

No spaces after commas.

$(eval $(call AUTOTARGETS,package,pcsc-lite))

Thanks for your patience reviewing my patch.

The updated version is already submitted.

Best regards,

Signature · 1 line
Dwi Sasongko S
#3 lore raw

PATCH 1/1 pcsc-lite and ccid support

Hello Thomas,

Quoted 69 lines · Dwi Sasongko Supriyadi
Quoted 7 lines · Thomas Petazzoni

Le Tue, 12 Jul 2011 17:10:37 +0700,
ruckuus at gmail.com a ?crit :

Quoted 3 lines

+config BR2_PACKAGE_CCID
+ ? ? bool "ccid"
+ ? ? select BR2_PACKAGE_PKG_CONFIG

Quoted 9 lines

No, I don't think you need pkg-config on the target.

Quoted 1 line

+CCID_DEPENDENCIES = pkg-config libusb pcsc-lite

Are you really sure you need pkg-config on the target ? Usually, pkg-config is needed in the host. In this case, add "host-pkg-config" to the DEPENDENCIES variable, and do not "select" anything related to BR2_PACKAGE_PKG_CONFIG in the Config.in file.

Ok. Actually no need pkg-config on the target, you are right, I need host-pkg-config instead.

Quoted 33 lines
Quoted 1 line

+$(eval $(call AUTOTARGETS, package, ccid))

No space after the commas:

$(eval $(call AUTOTARGETS,package,ccid))

Quoted 27 lines
package/pcsc-lite/Config.in new file +8 -0
new file mode 100644
index 0000000..55ac6d3
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_PCSC_LITE
+ ? ? bool "pcsc-lite"
+ ? ? select BR2_PACKAGE_LIBUSB
+ ? ? help
+ ? ? ? Middleware to access a smart card using SCard API (PC/SC).
+ ? ? ? For more information, please visit:
+ ? ? ? http://pcsclite.alioth.debian.org/pcsclite.html
+
package/pcsc-lite/pcsc-lite.mk new file +7 -0
new file mode 100644
index 0000000..2fdda5f
@@ -0,0 +1,13 @@
+##########################################################
+#
+# PCSC-Lite
+#
+# ########################################################
+PCSC_LITE_VERSION = 1.7.4
+PCSC_LITE_SOURCE = pcsc-lite-$(PCSC_LITE_VERSION).tar.bz2
Quoted 9 lines

package/pcsc-lite/pcsc-lite.mk line 11

Quoted 4 lines
package/pcsc-lite/pcsc-lite.mk new file +4 -0
+PCSC_LITE_SITE = https://alioth.debian.org/frs/download.php/3598
+PCSC_LITE_INSTALL_STAGING = YES
+PCSC_LITE_INSTALL_TARGET = YES
+PCSC_LITE_CONF_OPT = --disable-libudev --enable-libusb --enable-embedded

According to your Config.in, this package depends on LIBUSB. If it is indeed the case, then libusb should be in the DEPENDENCIES variable of this package.

Yes, I forgot this. Now it is corrected.

Quoted 2 lines
Quoted 1 line
package/pcsc-lite/pcsc-lite.mk new file +1 -0
+$(eval $(call AUTOTARGETS, package, pcsc-lite))
Quoted 9 lines
Quoted 4 lines

No spaces after commas.

$(eval $(call AUTOTARGETS,package,pcsc-lite))

Thanks for your patience reviewing my patch.

The updated version is already submitted.

Enclosed is the modified version. I have sent the patch previously via git send-email (yesterday) but there was no response. Please let me know should I miss anything.

Thanks and regards,

Signature · 8 lines
Dwi Sasongko S
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Support-for-a-generic-usb-smartcard-reader.patch
Type: text/x-patch
Size: 3937 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20110713/41cbfafd/attachment.bin>
#4 lore raw

PATCH 1/1 pcsc-lite and ccid support

Hello,

Le Wed, 13 Jul 2011 14:38:21 +0700,
Dwi Sasongko Supriyadi <[email protected]> a ?crit :

Quoted 3 lines

Enclosed is the modified version. I have sent the patch previously via git send-email (yesterday) but there was no response. Please let me know should I miss anything.

You didn't miss anything. From a review perspective, the patches look fine to me.

Now, it's up to Peter, the project maintainer, to merge them when he finds the time to review/test them.

Regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com