Skip to contentSkip to conversation

Final Visual studio compile fixes

PATCH In review [email protected]... 2 participants 4 messages Jul 14, 2011

lore
Share & tools
lore

[email protected]...

author
#0 lore raw

cover Final Visual studio compile fixes

These two patches fix two remaining Visual Studio compile issues. When these are applied on top of the existing patches in tmp/winbuildfix (openvpn-testing.git repo), Visual Studio builds finally work.

author
#1 lore raw

PATCH 1/2 Additional Visual Studio 2008 build fixes to tun.c

From: Samuli Seppänen <[email protected]...>

Signed-off-by Gert Doering <[email protected]...>
Tested-by Samuli Seppänen <[email protected]...>
Signed-off-by Samuli Seppänen <[email protected]...>
---
 tun.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
tun.c +2 -1
index 8cdd248..3cf2e3e 100644
@@ -4865,6 +4865,7 @@ close_tun (struct tuntap *tt)
     {
       if ( tt->ipv6 && tt->did_ifconfig_ipv6_setup )
         {
+	  const char *ifconfig_ipv6_local;
 	  struct argv argv;
 	  argv_init (&argv);
 

@@ -4872,7 +4873,7 @@ close_tun (struct tuntap *tt)
 	  delete_route_connected_v6_net(tt, NULL);
 
 	  /* netsh interface ipv6 delete address \"%s\" %s */
-	  const char * ifconfig_ipv6_local = print_in6_addr (tt->local_ipv6, 0, &gc);
+	  ifconfig_ipv6_local = print_in6_addr (tt->local_ipv6, 0,  &gc);
 	  argv_printf (&argv,
 		    "%s%sc interface ipv6 delete address %s %s",
 		     get_win_sys_path(),
Signature · 1 line
1.7.4.1
author
#2 lore raw

PATCH 2/2 Fixed a typo in win32.h that prevented building with Visual Studio

In reply to [email protected]...

From: Samuli Seppänen <[email protected]...>

Signed-off-by Samuli Seppänen <[email protected]...>
Tested-by Samuli Seppänen <[email protected]...>
---
 win32.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
win32.h +1 -1
index ca6dd32..528af6c 100644
@@ -272,7 +272,7 @@ char *get_win_sys_path (void);
 
 /* call self in a subprocess */
 void fork_to_self (const char *cmdline);
-#ifndef _MSV_VER
+#ifndef _MSC_VER
 const char *inet_ntop(int af, const void *src, char *dst, socklen_t size);
 int inet_pton(int af, const char *src, void *st);
 #endif
Signature · 1 line
1.7.4.1
#3 lore raw
In reply to [email protected]...

Hi,

Quoted 3 lines · On Wed, Jul 13, 2011 at 05:12:27PM -0700, [email protected]... wrote:

These two patches fix two remaining Visual Studio compile issues. When these are applied on top of the existing patches in tmp/winbuildfix (openvpn-testing.git repo), Visual Studio builds finally work.

ACK!

(First one is an oversight - GNU C accepts variable declarations in the middle of a block, MS VC not - and the second is just a typo)

gert

Signature · 4 lines
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             [email protected]...
fax: +49-89-35655025                        [email protected]...