Skip to contentSkip to conversation

dmaengine: use DEFINE_IDR for static initialization

PATCH New Axel Lin 1 participant 1 message Jul 20, 2011 dmaengine

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 dmaengine: use DEFINE_IDR for static initialization

We could use DEFINE_IDR for statically allocated idr that allow us to save a few lines of code.

And also remove unneeded mutex_init() for dma_list_mutex, as dma_list_mutex is initialized automatically by DEFINE_MUTEX().

---
 drivers/dma/dmaengine.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
drivers/dma/dmaengine.c +1 -3
index 26374b2..b48967b 100644
@@ -62,9 +62,9 @@
 #include <linux/slab.h>
 
 static DEFINE_MUTEX(dma_list_mutex);
+static DEFINE_IDR(dma_idr);
 static LIST_HEAD(dma_device_list);
 static long dmaengine_ref_count;
-static struct idr dma_idr;
 
 /* --- sysfs implementation --- */
 
@@ -1050,8 +1050,6 @@ EXPORT_SYMBOL_GPL(dma_run_dependencies);
 
 static int __init dma_bus_init(void)
 {
-	idr_init(&dma_idr);
-	mutex_init(&dma_list_mutex);
 	return class_register(&dma_devclass);
 }
 arch_initcall(dma_bus_init);
Signature · 1 line
1.7.4.1