gpe-mini-browser2_svn : remove fixes SRCREV
PATCH 1/1 gpe-mini-browser2_svn : remove fixes SRCREV
* SCREV points to a broken revision which crashes due to badly initialized g_threads See http://bugs.openembedded.org/show_bug.cgi?id=5409
--- recipes/gpe-mini-browser/gpe-mini-browser2_svn.bb | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
recipes/gpe-mini-browser/gpe-mini-browser2_svn.bb +0 -2
@@ -2,8 +2,6 @@ DEPENDS = "gtk+ glib-2.0 libgpewidget webkit-gtk" PV = "0.0.1+svnr${SRCPV}" PR = "r0" -SRCREV = "9900" - inherit autotools SRC_URI = "${GPE_EXTRA_SVN}"
Signature · 1 line
1.7.2.5
Dear Philippe,
thank you for your patch.
Am Freitag, den 22.07.2011, 01:31 +0300 schrieb Philippe De Swert:
Quoted 13 lines
* SCREV points to a broken revision which crashes due to badly initialized
g_threadsSee http://bugs.openembedded.org/show_bug.cgi?id=5409Signed-off-by Philippe De Swert <[email protected]>--- recipes/gpe-mini-browser/gpe-mini-browser2_svn.bb | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)recipes/gpe-mini-browser/gpe-mini-browser2_svn.bb +0
-0
recipes/gpe-mini-browser/gpe-mini-browser2_svn.bb DEPENDS = "gtk+ glib-2.0 libgpewidget webkit-gtk" · line 6
Quoted 5 lines
recipes/gpe-mini-browser/gpe-mini-browser2_svn.bb +0
-2@@ -2,8 +2,6 @@ DEPENDS = "gtk+ glib-2.0 libgpewidget webkit-gtk" PV = "0.0.1+svnr${SRCPV}" PR = "r0" -SRCREV = "9900" -
Please do not remove the SRCREV but replace it by a valid and working revision. Otherwise the builds would not be reproducible.
recipes/gpe-mini-browser/gpe-mini-browser2_svn.bb DEPENDS = "gtk+ glib-2.0 libgpewidget webkit-gtk" · line 7
Quoted 3 lines
recipes/gpe-mini-browser/gpe-mini-browser2_svn.bb +0
-0inherit autotools SRC_URI = "${GPE_EXTRA_SVN}"
Thanks,
Paul
Hi Paul,
Quoted 1 line · Paul Menzel
thank you for your patch.
Thank you for the review.
Quoted 3 lines
Please do not remove the
SRCREVbut replace it by a valid and working revision. Otherwise the builds would not be reproducible.
I already wondered who added one (as I originally added the svn recipe). Anyway I thought the whole idea of _svn etc were to have bleeding edge builds. If we wanted stable there would be a versioned recipe.
Of course I can add a new SRCREV but it defeats the whole purpose of the recipe...
Cheers,
Philippe
Quoted 7 lines · Philippe De Swert
Hi Paul,
Quoted 1 line · Paul Menzel
thank you for your patch.
Thank you for the review.
Quoted 8 lines
Quoted 3 lines
Please do not remove the
SRCREVbut replace it by a valid and working revision. Otherwise the builds would not be reproducible.I already wondered who added one (as I originally added the svn recipe). Anyway I thought the whole idea of
_svnetc were to have bleeding edge builds. If we wanted stable there would be a versioned recipe.
If you want it bleeding then you or your distribution will set
SRCREV_pn-gpe-mini-browser2 = "${AUTOREV}"
in local.conf or some distro .inc file
like there is
conf/distro/include/shr-autorev.inc
conf/distro/include/fso-autorev.inc
etc.
but for rest of world is better to say which SRCREV was tested and should work for everybody.
Quoted 2 lines
Of course I can add a new SRCREV but it defeats the whole purpose of the recipe...
Main purpose of _svn recipes is to allow build project without proper release or old release etc.. picking random bleeding edge revision and expect to get building image with it everytime I need to build newer images is not purpose but insanity :).
Regards,
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]
Hi,
Thanks for clarifying Martin.
Quoted 10 lines · Martin Jansa
Quoted 4 lines · Philippe De Swert
I already wondered who added one (as I originally added the svn recipe). Anyway I thought the whole idea of
_svnetc were to have bleeding edge builds. If we wanted stable there would be a versioned recipe.If you want it bleeding then you or your distribution will set
SRCREV_pn-gpe-mini-browser2 = "${AUTOREV}"
Quoted 8 lines
in local.conf or some distro .inc file
like there is
conf/distro/include/shr-autorev.inc
conf/distro/include/fso-autorev.inc
etc.but for rest of world is better to say which SRCREV was tested and should work for everybody.
Ok so things have changed since I made the recipe. Still catching up on all the new things in OE.
I'll make a new patch with a fixed up SRCREV then. Discard this one.
Cheers,
Philippe
Quoted 21 lines · Philippe De Swert
Hi,
Thanks for clarifying Martin.
Quoted 16 lines · Martin Jansa
Quoted 4 lines · Philippe De Swert
I already wondered who added one (as I originally added the svn recipe). Anyway I thought the whole idea of
_svnetc were to have bleeding edge builds. If we wanted stable there would be a versioned recipe.If you want it bleeding then you or your distribution will set
SRCREV_pn-gpe-mini-browser2 = "${AUTOREV}"
in local.conf or some distro .inc file
like there is
conf/distro/include/shr-autorev.inc
conf/distro/include/fso-autorev.inc
etc.
Quoted 5 lines
Quoted 2 lines
but for rest of world is better to say which SRCREV was tested and should work for everybody.
Ok so things have changed since I made the recipe. Still catching up on all the new things in OE.
BTW: let's go to catch some oe-core :)
Looking on that commit it was me changing SRCREV in recipe
gpe-mini-browser2_svn
-SRCREV = "9819"
+SRCREV = "9900"
because there was
-SRCREV_pn-gpe-mini-browser2 ?= "9900"
in conf/distro/include/sane-srcrevs.inc which was included by default and removed later after moving all SRCREVs to corresponding recipes.
and before that it was converted from SRCDATE to SRCREV (+ in recipe SRCREV was added)
http://git.openembedded.org/cgit.cgi/openembedded/commit/?id=e7814af646745ab8c6884c817d00475be3cd94e1
later SRCREV upgraded to 9900 by
http://git.openembedded.org/cgit.cgi/openembedded/commit/?id=e7814af646745ab8c6884c817d00475be3cd94e1
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]