Skip to contentSkip to conversation

bpfilter: document build requirements for bpfilter_umh

PATCH In review Valdis Kl=?utf-8?Q?=c4=93?=tnieks 2 participants 2 messages May 9, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bpfilter: document build requirements for bpfilter_umh

It's not intuitively obvious that bpfilter_umh is a statically linked binary. Mention the toolchain requirement in the Kconfig help, so people have an easier time figuring out what's needed.

net/bpfilter/Kconfig +4 -0
index fed9290e3b41..0ec6c7958c20 100644
@@ -13,4 +13,8 @@ config BPFILTER_UMH
 	default m
 	help
 	  This builds bpfilter kernel module with embedded user mode helper
+
+	  Note: your toolchain must support building static binaries, since
+	  rootfs isn't mounted at the time when __init functions are called
+	  and do_execv won't be able to find the elf interpreter.
 endif
#1 lore raw
Quoted 7 lines · Valdis Klētnieks

It's not intuitively obvious that bpfilter_umh is a statically linked binary. Mention the toolchain requirement in the Kconfig help, so people have an easier time figuring out what's needed.

Applied to linux-kbuild.
Thanks.

Quoted 14 lines
net/bpfilter/Kconfig +4 -0
index fed9290e3b41..0ec6c7958c20 100644
@@ -13,4 +13,8 @@ config BPFILTER_UMH
        default m
        help
          This builds bpfilter kernel module with embedded user mode helper
+
+         Note: your toolchain must support building static binaries, since
+         rootfs isn't mounted at the time when __init functions are called
+         and do_execv won't be able to find the elf interpreter.
 endif
Signature · 2 lines
Best Regards
Masahiro Yamada