regulator: Ensure enough enable time for max8649

PATCH Applied Axel Lin 3 participants 3 messages Aug 2, 2011 – Aug 8, 2011 Voltage and current regulator framework

Share & tools

Axel Lin

author

2011-08-02 04:55 UTC #0 lore raw

PATCH 1/1 regulator: Ensure enough enable time for max8649

Integer division may truncate the result, thus max8649_enable_time() may return slightly shorter enable time. This patch fixes it.

Signed-off-by Axel Lin <[email protected]>

---
 drivers/regulator/max8649.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

drivers/regulator/max8649.c +1 -1

index 30eb9e5..1062cf9 100644
@@ -221,7 +221,7 @@ static int max8649_enable_time(struct regulator_dev *rdev)
 	ret = (ret & MAX8649_RAMP_MASK) >> 5;
 	rate = (32 * 1000) >> ret;	/* uV/uS */
 
-	return (voltage / rate);
+	return DIV_ROUND_UP(voltage, rate);
 }
 
 static int max8649_set_mode(struct regulator_dev *rdev, unsigned int mode)

Signature · 1 line

1.7.4.1

Mark Brown

Acked-by on v1 1/1

2011-08-02 06:01 UTC #1 lore raw

Quoted 4 lines · Axel Lin

Integer division may truncate the result, thus max8649_enable_time() may return slightly shorter enable time. This patch fixes it.
Signed-off-by Axel Lin <[email protected]>

Acked-by Mark Brown <[email protected]>

Liam Girdwood

Applied

2011-08-08 16:44 UTC #2 lore raw

In reply to Axel Lin

Quoted 13 lines · Axel Lin

Integer division may truncate the result, thus max8649_enable_time() may return slightly shorter enable time. This patch fixes it.
Signed-off-by Axel Lin <[email protected]>
---
 drivers/regulator/max8649.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/regulator/max8649.c +0 -0
index 30eb9e5..1062cf9 100644

drivers/regulator/max8649.c static int max8649_enable_time(struct regulator_dev *rdev) · line 227

Quoted 8 lines

drivers/regulator/max8649.c +1 -1

@@ -221,7 +221,7 @@ static int max8649_enable_time(struct regulator_dev *rdev)
 	ret = (ret & MAX8649_RAMP_MASK) >> 5;
 	rate = (32 * 1000) >> ret;	/* uV/uS */
 
-	return (voltage / rate);
+	return DIV_ROUND_UP(voltage, rate);
 }
 
 static int max8649_set_mode(struct regulator_dev *rdev, unsigned int mode)

Applied.

Thanks

Liam