Skip to contentSkip to conversation

omap1: select GENERIC_IRQ_CHIP for TI OMAP1

PATCH RESEND In review Axel Lin 2 participants 2 messages Aug 3, 2011

Subsystems (2)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH RESEND 1/1 omap1: select GENERIC_IRQ_CHIP for TI OMAP1

The gpio-omap driver has been converted to use generic IRQ chip. Thus select GENERIC_IRQ_CHIP for TI OMAP1 to fix below build error.

LD vmlinux
drivers/built-in.o: In function `omap_mpuio_alloc_gc':
drivers/gpio/gpio-omap.c:1087: undefined reference to irq_alloc_generic_chip' drivers/gpio/gpio-omap.c:1100: undefined reference to irq_setup_generic_chip' drivers/built-in.o: In function `omap_gpio_show_rev':
drivers/gpio/gpio-omap.c:998: undefined reference to irq_gc_mask_clr_bit' drivers/gpio/gpio-omap.c:998: undefined reference to irq_gc_mask_set_bit'
make: *** [vmlinux] Error 1

---
Kevin already sent a similar patch. http://marc.info/?l=linux-omap&m=130749135312468&w=2
But I still have the build error with make omap1_defconfig in today's linux-next tree. So here is a resend.

Regards,
Axel

 arch/arm/plat-omap/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/plat-omap/Kconfig +1 -0
index 6e6735f..bb8f4a6 100644
@@ -13,6 +13,7 @@ config ARCH_OMAP1
 	bool "TI OMAP1"
 	select CLKDEV_LOOKUP
 	select CLKSRC_MMIO
+	select GENERIC_IRQ_CHIP
 	help
 	  "Systems based on omap7xx, omap15xx or omap16xx"
 
Signature · 1 line
1.7.4.1
#1 lore raw

Hi Axel,

Quoted 12 lines · Axel Lin

The gpio-omap driver has been converted to use generic IRQ chip. Thus select GENERIC_IRQ_CHIP for TI OMAP1 to fix below build error.

LD vmlinux
drivers/built-in.o: In function `omap_mpuio_alloc_gc':
drivers/gpio/gpio-omap.c:1087: undefined reference to irq_alloc_generic_chip' drivers/gpio/gpio-omap.c:1100: undefined reference to irq_setup_generic_chip' drivers/built-in.o: In function `omap_gpio_show_rev':
drivers/gpio/gpio-omap.c:998: undefined reference to irq_gc_mask_clr_bit' drivers/gpio/gpio-omap.c:998: undefined reference to irq_gc_mask_set_bit'
make: *** [vmlinux] Error 1

Quoted 5 lines

---
Kevin already sent a similar patch. http://marc.info/?l=linux-omap&m=130749135312468&w=2
But I still have the build error with make omap1_defconfig in today's linux-next tree. So here is a resend.

Tony didn't pick this up for v3.1, so I now have the original in my fixies queue for v3.1-rc, which will be posted shortly.

Sorry this has slipped through the cracks.

Kevin