Skip to contentSkip to conversation

of: add a dummy implementation of of_get_property() in of.h

RFC PATCH In review Axel Lin 2 participants 2 messages Aug 5, 2011

Subsystems (2)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

RFC PATCH 1/1 of: add a dummy implementation of of_get_property() in of.h

Then we can avoid having #ifdef CONFIG_OF splattered around the place calling of_get_property(), it leads to errors.

---
This patch fixes below build error with "make tegra_defconfig;make".

CC drivers/i2c/busses/i2c-tegra.o
drivers/i2c/busses/i2c-tegra.c: In function 'tegra_i2c_probe':
drivers/i2c/busses/i2c-tegra.c:615: error: implicit declaration of function 'of_get_property' drivers/i2c/busses/i2c-tegra.c:616: warning: assignment makes pointer from integer without a cast make[3]: *** [drivers/i2c/busses/i2c-tegra.o] Error 1
make[2]: *** [drivers/i2c/busses] Error 2
make[1]: *** [drivers/i2c] Error 2
make: *** [drivers] Error 2

Regards,
Axel

 include/linux/of.h |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
include/linux/of.h +6 -0
index 0085bb0..320cbad 100644
@@ -256,6 +256,12 @@ static inline int of_property_read_string(struct device_node *np,
 	return -ENOSYS;
 }
 
+static inline const void *of_get_property(const struct device_node *np,
+					  const char *name, int *lenp)
+{
+	return NULL;
+}
+
 #endif /* CONFIG_OF */
 
 static inline int of_property_read_u32(const struct device_node *np,
Signature · 1 line
1.7.4.1
#1 lore raw
Quoted 2 lines · Axel Lin

Then we can avoid having #ifdef CONFIG_OF splattered around the place calling of_get_property(), it leads to errors.

You shouldn't redefine of_get_property in the driver. Rather add a wrapper function to the driver which will extract the device tree information in CONFIG_OF is enabled and which will just return -ENODEV if CONFIG_OF is not set.

Cheers
Tobias