Skip to contentSkip to conversation

ipmi: use kstrdup()

PATCH New Thomas Meyer 1 participant 1 message Aug 6, 2011 IPMI

lore
Share & tools
lore

Thomas Meyer

author
#0 lore raw

PATCH 1/1 ipmi: use kstrdup()

From: Thomas Meyer <[email protected]>

Use kstrdup rather than duplicating its implementation

The semantic patch that makes this output is available in scripts/coccinelle/api/kstrdup.cocci.

More information about semantic patching is available at
http://coccinelle.lip6.fr/

Signed-off-by Thomas Meyer <[email protected]>

---

drivers/char/ipmi/ipmi_msghandler.c 2011-08-01 21:10:43.970134537 +0200 renamed from drivers/char/ipmi/ipmi_msghandler.c 2011-05-27 19:17:04.559520123 +0200 +1 -2
diff -u -p a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
@@ -2030,12 +2030,11 @@ int ipmi_smi_add_proc_entry(ipmi_smi_t s
 	entry = kmalloc(sizeof(*entry), GFP_KERNEL);
 	if (!entry)
 		return -ENOMEM;
-	entry->name = kmalloc(strlen(name)+1, GFP_KERNEL);
+	entry->name = kstrdup(name, GFP_KERNEL);
 	if (!entry->name) {
 		kfree(entry);
 		return -ENOMEM;
 	}
-	strcpy(entry->name, name);
 
 	file = proc_create_data(name, 0, smi->proc_dir, proc_ops, data);
 	if (!file) {