Missing put_cpu() in arch/s390/oprofile/hwsampler.c?

The function hws_oom_callback() seems to miss a corresponding put_cpu().

Or is this done in another function? I didn't find it.

thomas

---

Check for get/put_cpu() imbalances

The simplified semantic patch that makes this report is:

* get_cpu()
... when != put_cpu()
? get_cpu()

drivers/crypto/n2_core.c:986:25-26: WARNING: Possible missing put_cpu()! drivers/crypto/n2_core.c:1041:25-26: WARNING: Possible missing put_cpu()! drivers/scsi/fcoe/fcoe.c:1163:29-30: WARNING: Possible missing put_cpu()! drivers/scsi/fcoe/fcoe.c:1630:47-48: WARNING: Possible missing put_cpu()! arch/um/sys-i386/ldt.c:53:17-18: WARNING: Possible missing put_cpu()! arch/powerpc/kernel/machine_kexec_64.c:188:18-19: WARNING: Possible missing put_cpu()! arch/ia64/sn/kernel/sn2/sn_hwperf.c:618:52-53: WARNING: Possible missing put_cpu()! arch/s390/oprofile/hwsampler.c:553:16-17: WARNING: Possible missing put_cpu()! arch/s390/kernel/vtime.c:430:22-23: WARNING: Possible missing put_cpu()! arch/s390/kernel/vtime.c:473:15-16: WARNING: Possible missing put_cpu()! arch/blackfin/kernel/cplbinfo.c:89:9-10: WARNING: Possible missing put_cpu()!

This list contains some false positives.

Thanks to Julia for the semantic patch to find these kind of errors!

Yes, it looks broken.

Heinz, can you send a fix please?

Thanks,

-Robert

Advanced Micro Devices, Inc.
Operating System Research Center