Skip to contentSkip to conversation

bitbake/ui/knotty: Ensure previous failures aren't masked by a final successful command

PATCH In review Richard Purdie 2 participants 2 messages Aug 9, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bitbake/ui/knotty: Ensure previous failures aren't masked by a final successful command

When running bitbake in -k mode, the last command might succeed but we still need to preserve any previous failure codes.

---

bitbake/lib/bb/ui/knotty.py +2 -1
index 63b8dc6..7a2681d 100644
@@ -188,7 +188,8 @@ def main(server, eventHandler):
                 logger.error("Command execution failed: %s", event.error)
                 break
             if isinstance(event, bb.command.CommandExit):
-                return_value = event.exitcode
+                if not return_value:
+                    return_value = event.exitcode
                 continue
             if isinstance(event, bb.cooker.CookerExit):
                 break
#1 lore raw
Quoted 4 lines · Richard Purdie

When running bitbake in -k mode, the last command might succeed but we still need to preserve any previous failure codes.

Quoted 22 lines

---

bitbake/lib/bb/ui/knotty.py +2 -1
index 63b8dc6..7a2681d 100644
@@ -188,7 +188,8 @@ def main(server, eventHandler):
                 logger.error("Command execution failed: %s", event.error)
                 break
             if isinstance(event, bb.command.CommandExit):
-                return_value = event.exitcode
+                if not return_value:
+                    return_value = event.exitcode
                 continue
             if isinstance(event, bb.cooker.CookerExit):
                 break

_______________________________________________
bitbake-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/bitbake-devel

Signature · 3 lines
Joshua Lock
        Yocto Project "Johannes factotum"
        Intel Open Source Technology Centre