drivers/char: don't use IS_ERR()

PATCH New Thomas Meyer 1 participant 1 message Aug 10, 2011 Char and misc drivers

lore

Share & tools

lore

Thomas Meyer

author

2011-08-10 17:42 UTC #0 lore raw

PATCH 1/1 drivers/char: don't use IS_ERR()

From: Thomas Meyer <[email protected]>

The various basic memory allocation functions don't return ERR_PTR

The semantic patch that makes this change is available in scripts/coccinelle/null/eno.cocci.

More information about semantic patching is available at
http://coccinelle.lip6.fr/

Signed-off-by Thomas Meyer <[email protected]>

---

drivers/char/msm_smd_pkt.c +2 -3

index b6f8a65..ceece48 100644
@@ -379,9 +379,8 @@ static int __init smd_pkt_init(void)
 	for (i = 0; i < NUM_SMD_PKT_PORTS; ++i) {
 		smd_pkt_devp[i] = kzalloc(sizeof(struct smd_pkt_dev),
 					  GFP_KERNEL);
-		if (IS_ERR(smd_pkt_devp[i])) {
-			r = PTR_ERR(smd_pkt_devp[i]);
-			pr_err("kmalloc() failed %d\n", r);
+		if (!smd_pkt_devp[i]) {
+			pr_err("kmalloc() failed\n");
 			goto clean_cdevs;
 		}