Skip to contentSkip to conversation

Alpha: unbreak osf_setsysinfo(SSI_NVPAIRS, [SSIN_UACPROC, UAC_SIGBUS])

PATCH New [email protected] 1 participant 1 message Aug 11, 2011 Alpha port

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 Alpha: unbreak osf_setsysinfo(SSI_NVPAIRS, [SSIN_UACPROC, UAC_SIGBUS])

From: Sergei Trofimovich <[email protected]>

Update 'UAC_SHIFT' to match 'ALPHA_UAC_SHIFT'.

I don't know why kernel maintains 2 copies of the same constant. One (UAC_SHIFT) is used to shift bits in syscall definition, and another is in trap handler (ALPHA_UAC_SHIFT).

Was broken by

Quoted 10 lines

commit 745dd2405e281d96c0a449103bdf6a895048f28c

Author: Michael Cree <[email protected]>
Date:   Mon Nov 30 22:44:40 2009 -0500

Alpha: Rearrange thread info flags fixing two regressions

Both regressions fixed by (1) rearranging TIF_NOTIFY_RESUME flag to be in lower 8 bits of the thread info flags, and (2) making sure that ALPHA_UAC_SHIFT matches the rearrangement of the thread info flags.

Quoted 5 lines
Signed-off-by Michael Cree <[email protected]>
Cc Richard Henderson <[email protected]>
Cc Ivan Kokshaysky <[email protected]>
Cc David Howells <[email protected]>,
Signed-off-by Matt Turner <[email protected]>
Signed-off-by Sergei Trofimovich <[email protected]>
Cc Michael Cree <[email protected]>
Cc Richard Henderson <[email protected]>
Cc Ivan Kokshaysky <[email protected]>
Cc David Howells <[email protected]>,
Cc Matt Turner <[email protected]>
---
 arch/alpha/include/asm/sysinfo.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/alpha/include/asm/sysinfo.h +1 -1
index 086aba2..42b3edc 100644
@@ -32,7 +32,7 @@
 
 /* This is the shift that is applied to the UAC bits as stored in the
    per-thread flags.  See thread_info.h.  */
-#define UAC_SHIFT			6
+#define UAC_SHIFT			10
 
 #endif
Signature · 1 line
1.7.3.4