meta-yocto: remove apm from beagleboard MACHINE_FEATURES

PATCH In review Bruce Ashfield 2 participants 6 messages Aug 11, 2011 – Aug 12, 2011

lore

Share & tools

lore

Bruce Ashfield

author

2011-08-11 19:15 UTC #0 lore raw

cover meta-yocto: remove apm from beagleboard MACHINE_FEATURES

Richard/Saul,

Just repeating the patch contents here:

[
Fixes [YOCTO: #916]

apm is not something that we require in our yocto reference beagleboard BSP. It currently is listed in the MACHINE_FEATURES for the board, which leads to the runtime message:

Starting advanced power management daemon: No APM support in kernel

Since "/proc/apm" is not present. The board config we are targeting does not have the hardware to back this, so adding the emulation support wouldn't yield useful data. We'll leave this extended functionality for other more appropriate beagleboard configs
]

The following changes since commit 0350be945877b61eb8125663887fd7ed1c3923ab:
Khem Raj (1):
scripts/runqemu: Make it run on ubuntu 11.10

are available in the git repository at:

git://git.pokylinux.org/poky-contrib zedd/apm
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=zedd/apm

Bruce Ashfield (1):
meta-yocto: remove apm from beagleboard MACHINE_FEATURES

 meta-yocto/conf/machine/beagleboard.conf |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Bruce Ashfield

author

2011-08-11 19:15 UTC #1 lore raw

PATCH 1/1 meta-yocto: remove apm from beagleboard MACHINE_FEATURES

Fixes [YOCTO: #916]

apm is not something that we require in our yocto reference beagleboard BSP. It currently is listed in the MACHINE_FEATURES for the board, which leads to the runtime message:

Starting advanced power management daemon: No APM support in kernel

Signed-off-by Bruce Ashfield <[email protected]>

---
 meta-yocto/conf/machine/beagleboard.conf |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

meta-yocto/conf/machine/beagleboard.conf +1 -1

index 0b3cebc..fc0ecc7 100644
@@ -36,4 +36,4 @@ UBOOT_MACHINE = "omap3_beagle_config"
 UBOOT_ENTRYPOINT = "0x80008000"
 UBOOT_LOADADDRESS = "0x80008000"
 
-MACHINE_FEATURES = "kernel26 apm usbgadget usbhost vfat alsa"
+MACHINE_FEATURES = "kernel26 usbgadget usbhost vfat alsa"

Signature · 1 line

1.7.0.4

Richard Purdie

2011-08-11 23:48 UTC #2 lore raw

Quoted 6 lines · Bruce Ashfield

Fixes [YOCTO: #916]
apm is not something that we require in our yocto reference beagleboard BSP. It currently is listed in the MACHINE_FEATURES for the board, which leads to the runtime message:

Quoted 6 lines

Starting advanced power management daemon: No APM support in kernel
Since "/proc/apm" is not present. The board config we are targeting does not have the hardware to back this, so adding the emulation support wouldn't yield useful data. We'll leave this extended functionality for other more appropriate beagleboard configs.

On arm it used to be the case that this was the only way to expose user interface to suspend/resume the machine. Its not so much about their being hardware present for it as the whole kernel side was emulation of the user space notification part.

Has something changed in recent kernels in this area?

Cheers,

Richard

Bruce Ashfield

author

2011-08-12 00:51 UTC #3 lore raw

Quoted 14 lines · Richard Purdie

Quoted 6 lines · Bruce Ashfield
Fixes [YOCTO: #916]
apm is not something that we require in our yocto reference beagleboard BSP. It currently is listed in the MACHINE_FEATURES for the board, which leads to the runtime message:
Quoted 6 lines
Starting advanced power management daemon: No APM support in kernel
Since "/proc/apm" is not present. The board config we are targeting does not have the hardware to back this, so adding the emulation support wouldn't yield useful data. We'll leave this extended functionality for other more appropriate beagleboard configs.

Quoted 6 lines

On arm it used to be the case that this was the only way to expose user interface to suspend/resume the machine. Its not so much about their being hardware present for it as the whole kernel side was emulation of the user space notification part.
Has something changed in recent kernels in this area?

I won't claim to be an expert here .. but I haven't used apmd on many machines in quite a while. Assuming suspend_ops is implemented, it is typically just something ike this:

echo mem > /sys/power/state

echo standby > /sys/power/state

With a wakeup via the rtc, or whatever the board offers. I'm cc'ing Liming on this, since he's been poking at the board recently and may have more hands on information to share.

If we ARE removing this capability, then we'll take the other option that we had for this case and enable the emulation.

Cheers,

Bruce

Quoted 7 lines

Cheers,
Richard

Richard Purdie

2011-08-12 13:08 UTC #4 lore raw

Quoted 30 lines · Bruce Ashfield

Quoted 14 lines · Richard Purdie
Quoted 6 lines · Bruce Ashfield
Fixes [YOCTO: #916]
apm is not something that we require in our yocto reference beagleboard BSP. It currently is listed in the MACHINE_FEATURES for the board, which leads to the runtime message:
Quoted 6 lines
Starting advanced power management daemon: No APM support in kernel
Since "/proc/apm" is not present. The board config we are targeting does not have the hardware to back this, so adding the emulation support wouldn't yield useful data. We'll leave this extended functionality for other more appropriate beagleboard configs.
Quoted 6 lines
On arm it used to be the case that this was the only way to expose user interface to suspend/resume the machine. Its not so much about their being hardware present for it as the whole kernel side was emulation of the user space notification part.
Has something changed in recent kernels in this area?
I won't claim to be an expert here .. but I haven't used apmd on many machines in quite a while. Assuming suspend_ops is implemented, it is typically just something ike this:
echo mem > /sys/power/state
or

Quoted 8 lines

echo standby > /sys/power/state
With a wakeup via the rtc, or whatever the board offers. I'm cc'ing Liming on this, since he's been poking at the board recently and may have more hands on information to share.
If we ARE removing this capability, then we'll take the other option that we had for this case and enable the emulation.

I have a suspicion that certain parts of the sato code do assume /dev/apm_bios device emulation is present to get userspace notification of suspend/resume events which the above doesn't provide last I checked.

Likely this isn't an issue and I think that code in sato (matchbox panel app iirc) is toggled by the MACHINE_FEATURES but its certainly worth keeping in mind...

Cheers,

Richard

Bruce Ashfield

author

2011-08-12 13:13 UTC #5 lore raw

Quoted 40 lines · Richard Purdie

Quoted 30 lines · Bruce Ashfield
Quoted 14 lines · Richard Purdie
Quoted 6 lines · Bruce Ashfield
Fixes [YOCTO: #916]
apm is not something that we require in our yocto reference beagleboard BSP. It currently is listed in the MACHINE_FEATURES for the board, which leads to the runtime message:
Quoted 6 lines
Starting advanced power management daemon: No APM support in kernel
Since "/proc/apm" is not present. The board config we are targeting does not have the hardware to back this, so adding the emulation support wouldn't yield useful data. We'll leave this extended functionality for other more appropriate beagleboard configs.
Quoted 6 lines
On arm it used to be the case that this was the only way to expose user interface to suspend/resume the machine. Its not so much about their being hardware present for it as the whole kernel side was emulation of the user space notification part.
Has something changed in recent kernels in this area?
I won't claim to be an expert here .. but I haven't used apmd on many machines in quite a while. Assuming suspend_ops is implemented, it is typically just something ike this:
echo mem> /sys/power/state
or
Quoted 8 lines
echo standby> /sys/power/state
With a wakeup via the rtc, or whatever the board offers. I'm cc'ing Liming on this, since he's been poking at the board recently and may have more hands on information to share.
If we ARE removing this capability, then we'll take the other option that we had for this case and enable the emulation.

Quoted 8 lines

I have a suspicion that certain parts of the sato code do assume /dev/apm_bios device emulation is present to get userspace notification of suspend/resume events which the above doesn't provide last I checked.
Likely this isn't an issue and I think that code in sato (matchbox panel app iirc) is toggled by the MACHINE_FEATURES but its certainly worth keeping in mind...

Ack'd. We'll have a look at this. Drop my current pull request, and this can stand a deeper look.

Bruce

Quoted 7 lines

Cheers,
Richard