igb: Improve cable length function for I210, etc.
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 3/5 igb: Improve cable length function for I210, etc.
From: Joe Schultz <[email protected]>
Previously, the PHY-specific code to get the cable length for the I210 internal and related PHYs was reporting the cable length of a single pair and reporting it as the min, max, and total cable length. Update it so that all four pairs are checked so the true min, max, and average cable lengths are reported.
--- drivers/net/ethernet/intel/igb/e1000_defines.h | 5 ++- drivers/net/ethernet/intel/igb/e1000_hw.h | 1 + drivers/net/ethernet/intel/igb/e1000_phy.c | 54 ++++++++++++++++++++++---- 3 files changed, 51 insertions(+), 9 deletions(-)
drivers/net/ethernet/intel/igb/e1000_defines.h +4 -1
@@ -927,7 +927,10 @@/* Intel i347-AT4 Registers */ -#define I347AT4_PCDL 0x10/* PHY Cable Diagnostics Length */ +#define I347AT4_PCDL0 0x10/* Pair 0 PHY Cable Diagnostics Length */ +#define I347AT4_PCDL1 0x11/* Pair 1 PHY Cable Diagnostics Length */ +#define I347AT4_PCDL2 0x12/* Pair 2 PHY Cable Diagnostics Length */ +#define I347AT4_PCDL3 0x13/* Pair 3 PHY Cable Diagnostics Length */ #define I347AT4_PCDC 0x15/* PHY Cable Diagnostics Control */ #define I347AT4_PAGE_SELECT 0x16
drivers/net/ethernet/intel/igb/e1000_hw.h +1 -0
@@ -441,6 +441,7 @@ struct e1000_phy_info {u16 cable_length;u16 max_cable_length;u16 min_cable_length; +u16 pair_length[4 ];u8 mdix;
drivers/net/ethernet/intel/igb/e1000_phy.c +46 -8
73 lines not on this page · raw message
Signature · 1 line
1.9.1
Brown
PATCH 3/5 igb: Improve cable length function for I210, etc.
Quoted 14 lines
From: Intel-wired-lan [intel-wired-lan-bounces at lists.osuosl.org] on behalf of Aaron Sierra [asierra at xes-inc.com]
Sent: Tuesday, November 03, 2015 10:37 AM
To: Kirsher, Jeffrey T; intel-wired-lan at lists.osuosl.org
Cc: Joe Schultz
Subject: [Intel-wired-lan] [PATCH 3/5] igb: Improve cable length function for I210, etc.From: Joe Schultz <[email protected]>
Previously, the PHY-specific code to get the cable length for the I210 internal and related PHYs was reporting the cable length of a single pair and reporting it as the min, max, and total cable length. Update it so that all four pairs are checked so the true min, max, and average cable lengths are reported.
Quoted 7 lines
Signed-off-by Joe Schultz <[email protected]>Signed-off-by Aaron Sierra <[email protected]>--- drivers/net/ethernet/intel/igb/e1000_defines.h | 5 ++- drivers/net/ethernet/intel/igb/e1000_hw.h | 1 + drivers/net/ethernet/intel/igb/e1000_phy.c | 54 ++++++++++++++++++++++---- 3 files changed, 51 insertions(+), 9 deletions(-)