Skip to contentSkip to conversation

staging: rts_pstor: dont cast void* from kmalloc()

PATCH New Thomas Meyer 1 participant 1 message Aug 13, 2011 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rts_pstor: dont cast void* from kmalloc()

From: Thomas Meyer <[email protected]>

Casting (void *) value returned by kmalloc is useless as mentioned in Documentation/CodingStyle, Chap 14.

The semantic patch that makes this output is available in scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci.

More information about semantic patching is available at
http://coccinelle.lip6.fr/

---

drivers/staging/rts_pstor/sd.c 2011-08-01 19:57:13.347362265 +0200 renamed from drivers/staging/rts_pstor/sd.c 2011-07-28 15:32:18.233251740 +0200 +2 -2
diff -u -p a/drivers/staging/rts_pstor/sd.c b/drivers/staging/rts_pstor/sd.c
@@ -4139,7 +4139,7 @@ int sd_execute_read_data(struct scsi_cmn
 		cmd[3] = srb->cmnd[5];
 		cmd[4] = srb->cmnd[6];
 
-		buf = (u8 *)kmalloc(data_len, GFP_KERNEL);
+		buf = kmalloc(data_len, GFP_KERNEL);
 		if (buf == NULL) {
 			TRACE_RET(chip, TRANSPORT_ERROR);
 		}
@@ -4385,7 +4385,7 @@ int sd_execute_write_data(struct scsi_cm
 		u16 i;
 		u8 *buf;
 
-		buf = (u8 *)kmalloc(data_len, GFP_KERNEL);
+		buf = kmalloc(data_len, GFP_KERNEL);
 		if (buf == NULL) {
 			TRACE_RET(chip, TRANSPORT_ERROR);
 		}