lightmediascanner: added recipe for v0.4.3
PATCH 1/2 lightmediascanner: added recipe for v0.4.3
--- .../recipes-efl/e17/lightmediascanner_0.4.3.0.bb | 29 ++++++++++++++++++++ 1 files changed, 29 insertions(+), 0 deletions(-) create mode 100644 meta-efl/recipes-efl/e17/lightmediascanner_0.4.3.0.bb
meta-efl/recipes-efl/e17/lightmediascanner_0.4.3.0.bb new file +29 -0
@@ -0,0 +1,29 @@ +DESCRIPTION = "Lightweight media scanner meant to be used in not-so-powerful devices" +SECTION = "libs/multimedia" +AUTHOR = "Profusion" +LICENSE = "LGPLv2.1+" +DEPENDS = "sqlite3 flac" +SRC_URI = "https://garage.maemo.org/frs/download.php/9439/lightmediascanner-${PV}.tar.bz2" + +PE = "1" + +inherit autotools pkgconfig + +do_install_append() { + install -d ${D}/${bindir}/ + install -m 755 ${WORKDIR}/${PN}-${PV}/src/bin/.libs/test ${D}/${bindir}/test-lms +} + + +LIC_FILES_CHKSUM = "file://COPYING;md5=a6f89e2100d9b6cdffcea4f398e37343" + +PACKAGES =+ "${PN}-test" + +FILES_${PN}-test = "${bindir}/test-lms" + +FILES_${PN}-dbg += "${libdir}/${PN}/plugins/.debug" + +SRC_URI[md5sum] = "188ff5188cfa0f2504a42934c969cb77" +SRC_URI[sha256sum] = "bdbe76655ad212b936fb3cf6a9ca725e318ddeb57cd7d950d9c8409297d3b0da" + +
Signature · 1 line
1.7.6
PATCH 2/2 enjoy: make it work with shr-core
* added LIC_FILES_CHKSUM
* added virtual/gettext as it seems it is needed now (it didn't build fine without it)
* RDEPENDS: added new gstreamer module gst-plugins-good-autodetect needed for enjoy to be able to play files
* RDEPENDS: updated all other module names because they changed in shr-core
--- meta-efl/recipes-efl/e17/enjoy_svn.bb | 13 ++++++++----- 1 files changed, 8 insertions(+), 5 deletions(-)
meta-efl/recipes-efl/e17/enjoy_svn.bb +8 -5
@@ -5,7 +5,10 @@ SRCREV = "${EFL_SRCREV}" PV = "0.0+svnr${SRCPV}" PR = "r4" -DEPENDS += "gst-plugins-good ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'gst-plugins-ugly', d)}" +LIC_FILES_CHKSUM = "file://COPYING;md5=0f507c68d42d1cc0fcb507d007112bf2" + + +DEPENDS += "virtual/gettext gst-plugins-good ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'gst-plugins-ugly', d)}" #1st needed for all formats #2nd needed for mp3 playback
@@ -13,10 +16,10 @@ DEPENDS += "gst-plugins-good ${@base_conditional('ENTERPRISE_DISTRO', '1', '', ' #4th needed for flac playback #5th needed binary to create db RDEPENDS += "\ - gst-plugin-typefindfunctions gst-plugin-playbin gst-plugin-volume gst-plugin-decodebin2 \ - ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'gst-plugin-mad gst-plugin-id3demux', d)} \ - gst-plugin-ogg gst-plugin-ivorbisdec \ - gst-plugin-flac \ + gst-plugins-base-typefindfunctions gst-plugins-base-playbin gst-plugins-base-volume gst-plugins-base-decodebin2 gst-plugins-good-autodetect \ + ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'gst-plugins-ugly-mad gst-plugins-good-id3demux', d)} \ + gst-plugins-base-ogg gst-plugins-base-ivorbisdec \ + gst-plugins-good-flac \ lightmediascanner-test \ "
Signature · 1 line
1.7.6
Re: [PATCH 2/2] enjoy: make it work with shr-core
Dear Pau,
thank you for your patches.
Am Mittwoch, den 17.08.2011, 06:51 +0200 schrieb Pau Espin Pedrol:
Quoted 1 line
* added
LIC_FILES_CHKSUM
Please always use present tense in commit messages.
Quoted 1 line
* added virtual/gettext as it seems it is needed now (it didn't build fine without it)
What is the exact error? It built fine in oe.dev as far as I remember. Additionally should inherit gettext be used?
Quoted 2 lines
* RDEPENDS: added new gstreamer module gst-plugins-good-autodetect needed for enjoy to be able to play files
* RDEPENDS: updated all other module names because they changed in shr-core
Please always send one patch for one change, which makes it easier to review. It would be great if you could resend your patch as three patches (license, build fix and if feasible each RDEPENDS).
Quoted 10 lines
Signed-off-by Pau Espin Pedrol <[email protected]>--- meta-efl/recipes-efl/e17/enjoy_svn.bb | 13 ++++++++----- 1 files changed, 8 insertions(+), 5 deletions(-)meta-efl/recipes-efl/e17/enjoy_svn.bb +0
-0
meta-efl/recipes-efl/e17/enjoy_svn.bb SRCREV = "${EFL_SRCREV}" · line 8
Quoted 5 lines
meta-efl/recipes-efl/e17/enjoy_svn.bb +1
-1@@ -5,7 +5,10 @@ SRCREV = "${EFL_SRCREV}" PV = "0.0+svnr${SRCPV}" PR = "r4" -DEPENDS += "gst-plugins-good ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'gst-plugins-ugly', d)}" +LIC_FILES_CHKSUM = "file://COPYING;md5=0f507c68d42d1cc0fcb507d007112bf2"
Please look at the style guide where to add such fields. In this case it is not listed directly but it should go right below LICENSE.
Quoted 10 lines
meta-efl/recipes-efl/e17/enjoy_svn.bb +3
-0+ + +DEPENDS += "virtual/gettext gst-plugins-good ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'gst-plugins-ugly', d)}" #1st needed for all formats #2nd needed for mp3 playback@@ -13,10 +16,10 @@ DEPENDS += "gst-plugins-good ${@base_conditional('ENTERPRISE_DISTRO', '1', '', ' #4th needed for flac playback #5th needed binary to create db RDEPENDS += "\
meta-efl/recipes-efl/e17/enjoy_svn.bb DEPENDS += "gst-plugins-good ${@base_conditional('ENTERPRISE_DISTRO', '1', '', ' · line 24
Quoted 10 lines
meta-efl/recipes-efl/e17/enjoy_svn.bb +4
-4- gst-plugin-typefindfunctions gst-plugin-playbin gst-plugin-volume gst-plugin-decodebin2 \ - ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'gst-plugin-mad gst-plugin-id3demux', d)} \ - gst-plugin-ogg gst-plugin-ivorbisdec \ - gst-plugin-flac \ + gst-plugins-base-typefindfunctions gst-plugins-base-playbin gst-plugins-base-volume gst-plugins-base-decodebin2 gst-plugins-good-autodetect \ + ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'gst-plugins-ugly-mad gst-plugins-good-id3demux', d)} \ + gst-plugins-base-ogg gst-plugins-base-ivorbisdec \ + gst-plugins-good-flac \ lightmediascanner-test \ "
Thanks,
Paul
Note these 2 patches should be applied to meta-efl repo. I thought the prefix would be added, sorry for the inconvenience ;)
Signature · 3 lines
Pau Espin Pedrol mail/jabber: [email protected] http://blog.espeweb.net
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Op 17-08-11 06:51, Pau Espin Pedrol schreef:
Quoted 4 lines
meta-efl/recipes-efl/e17/lightmediascanner_0.4.3.0.bb new file mode 100644 index 0000000..dd0b283 --- /dev/null +++ b/meta-efl/recipes-efl/e17/lightmediascanner_0.4.3.0.bb @@ -0,0 +1,29 @@ +DESCRIPTION = "Lightweight media renamed from meta-efl/recipes-efl/e17/lightmediascanner_0.4.3.0.bb +0
-0scanner meant to be used in not-so-powerful devices" +SECTION = "libs/multimedia" +AUTHOR = "Profusion"
Maybe profusion.mobi might be clearer
Quoted 1 line
+LICENSE = "LGPLv2.1+" +DEPENDS = "sqlite3 flac" +SRC_URI = "https://garage.maemo.org/frs/download.php/9439/lightmediascanner-${PV}.tar.bz2" + +PE = "1"
meta-efl is a fresh start, so PE can be dropped
Quoted 1 line
+ +inherit autotools pkgconfig + +do_install_append() { + install -d ${D}/${bindir}/ + install -m 755 ${WORKDIR}/${PN}-${PV}/src/bin/.libs/test ${D}/${bindir}/test-lms +} + + +LIC_FILES_CHKSUM = "file://COPYING;md5=a6f89e2100d9b6cdffcea4f398e37343"
Move that next to LICENSE
Quoted 1 line
+PACKAGES =+ "${PN}-test" + +FILES_${PN}-test = "${bindir}/test-lms" + +FILES_${PN}-dbg += "${libdir}/${PN}/plugins/.debug" + +SRC_URI[md5sum] = "
188ff5188cfa0f2504a42934c969cb77" +SRC_URI[sha256sum] = "bdbe76655ad212b936fb3cf6a9ca725e318ddeb57cd7d950d9c8409297d3b0da"
And move those next to SRC_URI
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFOS24VMkyGM64RGpERAlquAJ97wZaWiNLYg41n3q3O9vGiqJ6qaQCfVO5+ h0YoTC9/SmvV07UKzu/qdLo=
=55Qv
-----END PGP SIGNATURE-----
Quoted 21 lines · Koen Kooi
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1Op 17-08-11 06:51, Pau Espin Pedrol schreef:
Quoted 4 lines
meta-efl/recipes-efl/e17/lightmediascanner_0.4.3.0.bb new file mode 100644 index 0000000..dd0b283 --- /dev/null +++ b/meta-efl/recipes-efl/e17/lightmediascanner_0.4.3.0.bb @@ -0,0 +1,29 @@ +DESCRIPTION = "Lightweight media renamed from meta-efl/recipes-efl/e17/lightmediascanner_0.4.3.0.bb +0
-0scanner meant to be used in not-so-powerful devices" +SECTION = "libs/multimedia" +AUTHOR = "Profusion"
Maybe profusion.mobi might be clearer
Quoted 1 line
+LICENSE = "LGPLv2.1+" +DEPENDS = "sqlite3 flac" +SRC_URI = "https://garage.maemo.org/frs/download.php/9439/lightmediascanner-${PV}.tar.bz2" + +PE = "1"
meta-efl is a fresh start, so PE can be dropped
Quoted 1 line
+ +inherit autotools pkgconfig + +do_install_append() { + install -d ${D}/${bindir}/ + install -m 755 ${WORKDIR}/${PN}-${PV}/src/bin/.libs/test ${D}/${bindir}/test-lms +} + + +LIC_FILES_CHKSUM = "file://COPYING;md5=a6f89e2100d9b6cdffcea4f398e37343"
Move that next to LICENSE
Quoted 1 line
+PACKAGES =+ "${PN}-test" + +FILES_${PN}-test = "${bindir}/test-lms" + +FILES_${PN}-dbg += "${libdir}/${PN}/plugins/.debug" + +SRC_URI[md5sum] = "
188ff5188cfa0f2504a42934c969cb77" +SRC_URI[sha256sum] = "bdbe76655ad212b936fb3cf6a9ca725e318ddeb57cd7d950d9c8409297d3b0da"
Quoted 8 lines
And move those next to
SRC_URI
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)iD8DBQFOS24VMkyGM64RGpERAlquAJ97wZaWiNLYg41n3q3O9vGiqJ6qaQCfVO5+ h0YoTC9/SmvV07UKzu/qdLo=
=55Qv
-----END PGP SIGNATURE-----
+ I've already talked with pespin about moving it from recipes-efl/e17 to recipes-multimedia or something like that.
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]
Am Mittwoch, den 17.08.2011, 09:30 +0200 schrieb Koen Kooi:
Quoted 7 lines
Op 17-08-11 06:51, Pau Espin Pedrol schreef:
Quoted 4 lines
meta-efl/recipes-efl/e17/lightmediascanner_0.4.3.0.bb new file mode 100644 index 0000000..dd0b283 --- /dev/null +++ b/meta-efl/recipes-efl/e17/lightmediascanner_0.4.3.0.bb @@ -0,0 +1,29 @@ +DESCRIPTION = "Lightweight media renamed from meta-efl/recipes-efl/e17/lightmediascanner_0.4.3.0.bb +0
-0scanner meant to be used in not-so-powerful devices" +SECTION = "libs/multimedia" +AUTHOR = "Profusion"
Maybe profusion.mobi might be clearer
According to their contact page the correct spelling is ProFUSION [1][2].
[…]
Thanks,
Paul
PS: Koen, somehow some of your messages seem to remove line breaks in the citation.
[1] http://profusion.mobi/contact
[2] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=29c4f7b7a2d5ff06e3c6573f9da2ac0e68800c06
Am Mittwoch, den 17.08.2011, 06:51 +0200 schrieb Pau Espin Pedrol:
Please consider the following commit message when resending and please read the policies [1–4].
lightmediascanner: Add version 0.4.3.0 (initial recipe)
Quoted 5 lines
Signed-off-by Pau Espin Pedrol <[email protected]>--- .../recipes-efl/e17/lightmediascanner_0.4.3.0.bb | 29 ++++++++++++++++++++ 1 files changed, 29 insertions(+), 0 deletions(-) create mode 100644 meta-efl/recipes-efl/e17/lightmediascanner_0.4.3.0.bb
I cleaned up the recipes in oe.dev. Please base your next patch on these [5].
[…]
Thanks,
Paul
[1] http://wiki.openembedded.org/index.php/Styleguide
[2] http://wiki.openembedded.org/index.php/Commit_Patch_Message_Guidelines
[3] http://wiki.openembedded.org/index.php/Commit_Policy
[4] http://wiki.openembedded.org/index.php/Commit_log_example
[5] http://cgit.openembedded.org/cgit.cgi/openembedded/log/recipes/lightmediascanner/
Ok thanks for all the feedback ;)
Signature · 3 lines
Pau Espin Pedrol mail/jabber: [email protected] http://blog.espeweb.net